* [PATCH] Fix kobject_get oopses triggered by i2c in 2.5.65-bk
@ 2003-03-21 19:51 Petr Vandrovec
2003-03-21 20:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Petr Vandrovec @ 2003-03-21 19:51 UTC (permalink / raw)
To: torvalds; +Cc: greg, linux-kernel
Hi,
i2c initialization must not use module_init now, when it was converted
to the kobject interface. There are dozens of users which need it working
much sooner. i2c is subsystem after all, isn't it?
Fixes kernel oopses in kobject_get during system init which were happening
to me.
Petr Vandrovec
vandrove@vc.cvut.cz
--- vger/drivers/i2c/i2c-core.c 2003-03-21 19:06:32.000000000 +0100
+++ linux/drivers/i2c/i2c-core.c 2003-03-21 20:42:13.000000000 +0100
@@ -675,7 +675,7 @@
bus_unregister(&i2c_bus_type);
}
-module_init(i2c_init);
+subsys_initcall(i2c_init);
module_exit(i2c_exit);
/* ----------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix kobject_get oopses triggered by i2c in 2.5.65-bk
2003-03-21 19:51 [PATCH] Fix kobject_get oopses triggered by i2c in 2.5.65-bk Petr Vandrovec
@ 2003-03-21 20:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-03-21 20:23 UTC (permalink / raw)
To: Petr Vandrovec; +Cc: torvalds, linux-kernel
On Fri, Mar 21, 2003 at 08:51:14PM +0100, Petr Vandrovec wrote:
> Hi,
>
> i2c initialization must not use module_init now, when it was converted
> to the kobject interface. There are dozens of users which need it working
> much sooner. i2c is subsystem after all, isn't it?
>
> Fixes kernel oopses in kobject_get during system init which were happening
> to me.
Thanks, I've added this to my tree, and will send it on to Linus in the
next round of i2c changes.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-21 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-21 19:51 [PATCH] Fix kobject_get oopses triggered by i2c in 2.5.65-bk Petr Vandrovec
2003-03-21 20:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).