From: Arjan van de Ven <arjanv@redhat.com>
To: Arjan van de Ven <arjanv@redhat.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.4+ptrace exploit fix breaks root's ability to strace
Date: Sat, 22 Mar 2003 17:28:54 +0000 [thread overview]
Message-ID: <20030322172854.B12071@devserv.devel.redhat.com> (raw)
In-Reply-To: <20030322171312.H8712@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Sat, Mar 22, 2003 at 05:13:12PM +0000
On Sat, Mar 22, 2003 at 05:13:12PM +0000, Russell King wrote:
>
> int ptrace_check_attach(struct task_struct *child, int kill)
> {
> ...
> + if (!is_dumpable(child))
> + return -EPERM;
> }
>
> So, we went from being able to ptrace daemons as root, to being able to
> attach daemons and then being unable to do anything with them, even if
> you're root (or have the CAP_SYS_PTRACE capability). I think this
> behaviour is getting on for being described as "insane" 8) and is
> clearly wrong.
ok it seems this check is too strong. It *has* to check
child->task_dumpable and return -EPERM, but child->mm->dumpable is not
needed.
next prev parent reply other threads:[~2003-03-22 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-22 10:31 2.4+ptrace exploit fix breaks root's ability to strace Russell King
2003-03-22 14:58 ` Alan Cox
2003-03-22 14:10 ` Russell King
2003-03-22 15:28 ` Arjan van de Ven
2003-03-22 17:13 ` Russell King
2003-03-22 17:28 ` Arjan van de Ven [this message]
2003-03-22 19:09 ` Alan Cox
2003-03-22 18:01 ` Russell King
2003-03-23 10:31 ` Lists (lst)
2003-03-23 10:38 ` Russell King
2003-03-23 11:11 ` Martin Loschwitz
2003-03-23 10:43 ` Arjan van de Ven
2003-04-17 5:46 Yusuf Wilajati Purna
2003-04-19 5:57 ` Bernhard Kaindl
2003-04-22 5:03 ` Yusuf Wilajati Purna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030322172854.B12071@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).