2.5.67 compile problem...

2.5.67 compile problem...

[Bruno Boettcher]

Hello!

after the yesterday cramfs problem, (BTW thanks for those who helped me
    iron that out) here another compile problem, with
the patched 2.5.66 thus mathing a 67 kernel:

In file included from include/linux/mca.h:132,
                 from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:10:2: warning: #warning "MCA legacy - please move your driver to the new sysfs api"
drivers/block/ps2esdi.c:182: redefinition of `init_module'
drivers/block/ps2esdi.c:168: `init_module' previously defined here
drivers/block/ps2esdi.c: In function `init_module':
drivers/block/ps2esdi.c:186: warning: initialization from incompatible pointer type
drivers/block/ps2esdi.c:189: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:189: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:190: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:193: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:194: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:196: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c: In function `cleanup_module':
drivers/block/ps2esdi.c:212: `i' undeclared (first use in this function)
drivers/block/ps2esdi.c:212: (Each undeclared identifier is reported only once
drivers/block/ps2esdi.c:212: for each function it appears in.)
drivers/block/ps2esdi.c: In function `do_ps2esdi_request':
drivers/block/ps2esdi.c:502: warning: long long unsigned int format, different type arg (arg 3)
drivers/block/ps2esdi.c: In function `ps2esdi_out_cmd_blk':
drivers/block/ps2esdi.c:623: warning: comparison of distinct pointer types lacks a cast
drivers/block/ps2esdi.c:646: warning: comparison of distinct pointer types lacks a cast
make[2]: *** [drivers/block/ps2esdi.o] Fehler 1


again if someone has a suggestion....
and please add me as CC to any reply

-- 
ciao bboett
==============================================================
bboett@adlp.org
http://inforezo.u-strasbg.fr/~bboett
===============================================================

Re: 2.5.67 compile problem...

[Michael Buesch]

On Tuesday 08 April 2003 20:06, Bruno Boettcher wrote:
> Hello!
>
> after the yesterday cramfs problem, (BTW thanks for those who helped me
>     iron that out) here another compile problem, with
> the patched 2.5.66 thus mathing a 67 kernel:
>
> [...]
>
> again if someone has a suggestion....
> and please add me as CC to any reply


This may fix it. (It's not tested)

Regards Michael Buesch.



--- drivers/block/ps2esdi.c.orig	2003-04-08 20:50:17.000000000 +0200
+++ drivers/block/ps2esdi.c	2003-04-08 20:52:43.000000000 +0200
@@ -165,7 +165,6 @@
 	return 0;
 }				/* ps2esdi_init */
 
-module_init(ps2esdi_init);
 
 #ifdef MODULE
 
@@ -200,6 +199,8 @@
 
 void
 cleanup_module(void) {
+	int i;
+
 	if(ps2esdi_slot) {
 		mca_mark_as_unused(ps2esdi_slot);
 		mca_set_adapter_procfn(ps2esdi_slot, NULL, NULL);
@@ -214,6 +215,8 @@
 		put_disk(ps2esdi_gendisk[i]);
 	}
 }
+#else /* MODULE */
+module_init(ps2esdi_init);
 #endif /* MODULE */
 
 /* handles boot time command line parameters */

Re: 2.5.67 compile problem...

[Bruno Boettcher]

On Tue, Apr 08, 2003 at 08:56:12PM +0200, Michael Buesch wrote:
> This may fix it. (It's not tested)
partly :D


In file included from include/linux/mca.h:132,
                 from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:10:2: warning: #warning "MCA legacy - please move your driver to the new sysfs api"
drivers/block/ps2esdi.c: In function `init_module':
drivers/block/ps2esdi.c:185: warning: initialization from incompatible pointer type
drivers/block/ps2esdi.c:188: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:188: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:189: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:192: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:193: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:195: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c: In function `do_ps2esdi_request':
drivers/block/ps2esdi.c:505: warning: long long unsigned int format, different type arg (arg 3)
drivers/block/ps2esdi.c: In function `ps2esdi_out_cmd_blk':
drivers/block/ps2esdi.c:626: warning: comparison of distinct pointer types lacks a cast
drivers/block/ps2esdi.c:649: warning: comparison of distinct pointer types lacks a cast
make[2]: *** [drivers/block/ps2esdi.o] Fehler 1

besides debugging this one....
for what is it needed, and can i safely (question there, where?) switch it off, to be able to at least give this 2.5 kernel a test shot?

please add me through CC to any answer

-- 
ciao bboett
==============================================================
bboett@adlp.org
http://inforezo.u-strasbg.fr/~bboett
===============================================================

Re: 2.5.67 compile problem...

[Michael Buesch]

On Thursday 10 April 2003 16:25, Bruno Boettcher wrote:
> On Tue, Apr 08, 2003 at 08:56:12PM +0200, Michael Buesch wrote:
> > This may fix it. (It's not tested)
>
> partly :D
oops. :) Give this one a try:
(patch against 2.5.67)

--- drivers/block/ps2esdi.c.orig	2003-04-10 17:44:57.000000000 +0200
+++ drivers/block/ps2esdi.c	2003-04-10 18:01:48.000000000 +0200
@@ -107,7 +107,7 @@
 static int ps2esdi_slot = -1;
 static int tp720esdi = 0;	/* Is it Integrated ESDI of ThinkPad-720? */
 static int intg_esdi = 0;       /* If integrated adapter */
-struct ps2esdi_i_struct {
+struct ps2_esdi_i_struct {
 	unsigned int head, sect, cyl, wpcom, lzone, ctl;
 };
 static spinlock_t ps2esdi_lock = SPIN_LOCK_UNLOCKED;
@@ -165,7 +165,6 @@
 	return 0;
 }				/* ps2esdi_init */
 
-module_init(ps2esdi_init);
 
 #ifdef MODULE
 
@@ -200,6 +199,8 @@
 
 void
 cleanup_module(void) {
+	int i;
+
 	if(ps2esdi_slot) {
 		mca_mark_as_unused(ps2esdi_slot);
 		mca_set_adapter_procfn(ps2esdi_slot, NULL, NULL);
@@ -214,6 +215,8 @@
 		put_disk(ps2esdi_gendisk[i]);
 	}
 }
+#else /* MODULE */
+module_init(ps2esdi_init);
 #endif /* MODULE */
 
 /* handles boot time command line parameters */



Regards
Michael Buesch.

-- 
My homepage: http://www.8ung.at/tuxsoft
fighting for peace is like fu**ing for virginity

Re: 2.5.67 compile problem...

[Michael Buesch]

On Thursday 10 April 2003 18:06, Michael Buesch wrote:
> On Thursday 10 April 2003 16:25, Bruno Boettcher wrote:
> > On Tue, Apr 08, 2003 at 08:56:12PM +0200, Michael Buesch wrote:
> > > This may fix it. (It's not tested)
> >
> > partly :D
>
> oops. :) Give this one a try:
> (patch against 2.5.67)
sorry prevoiusly posted patch was wrong.
I hope this one is correct. :D

--- drivers/block/ps2esdi.c.orig	2003-04-10 17:44:57.000000000 +0200
+++ drivers/block/ps2esdi.c	2003-04-10 18:10:13.000000000 +0200
@@ -165,7 +165,6 @@
 	return 0;
 }				/* ps2esdi_init */
 
-module_init(ps2esdi_init);
 
 #ifdef MODULE
 
@@ -183,7 +182,7 @@
 	int drive;
 
 	for(drive = 0; drive < MAX_HD; drive++) {
-	        struct ps2_esdi_i_struct *info = &ps2esdi_info[drive];
+	        struct ps2esdi_i_struct *info = &ps2esdi_info[drive];
 
         	if (cyl[drive] != -1) {
 		  	info->cyl = info->lzone = cyl[drive];
@@ -200,6 +199,8 @@
 
 void
 cleanup_module(void) {
+	int i;
+
 	if(ps2esdi_slot) {
 		mca_mark_as_unused(ps2esdi_slot);
 		mca_set_adapter_procfn(ps2esdi_slot, NULL, NULL);
@@ -214,6 +215,8 @@
 		put_disk(ps2esdi_gendisk[i]);
 	}
 }
+#else /* MODULE */
+module_init(ps2esdi_init);
 #endif /* MODULE */
 
 /* handles boot time command line parameters */



Regards
Michael Buesch.

-- 
My homepage: http://www.8ung.at/tuxsoft
fighting for peace is like fu**ing for virginity