* [PATCH] compile fix ipfw
@ 2003-04-17 1:11 Rik van Riel
2003-04-17 1:13 ` David S. Miller
2003-04-17 5:16 ` [netfilter-core] " Rusty Russell
0 siblings, 2 replies; 4+ messages in thread
From: Rik van Riel @ 2003-04-17 1:11 UTC (permalink / raw)
To: coreteam; +Cc: linux-kernel, David S. Miller
In the patch that went to marcelo a few days ago the reset
argument to ip_chain_procinfo() got removed, but there's still
a code block inside the function that references that variable.
This patch gets rid of that (presumably old) code block. Note
that I didn't cc this to Marcelo because I'm not 100% sure, so
please check it.
--- linux-2.4.20/net/ipv4/netfilter/ipfwadm_core.c.compile 2003-04-16 21:04:30.000000000 -0400
+++ linux-2.4.20/net/ipv4/netfilter/ipfwadm_core.c 2003-04-16 21:05:24.000000000 -0400
@@ -1176,12 +1176,6 @@ static int ip_chain_procinfo(int stage,
len = last_len;
break;
}
- else if(reset)
- {
- /* This needs to be done at this specific place! */
- i->fw_pcnt=0L;
- i->fw_bcnt=0L;
- }
last_len = len;
i=i->fw_next;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] compile fix ipfw
2003-04-17 1:11 [PATCH] compile fix ipfw Rik van Riel
@ 2003-04-17 1:13 ` David S. Miller
2003-04-17 5:16 ` [netfilter-core] " Rusty Russell
1 sibling, 0 replies; 4+ messages in thread
From: David S. Miller @ 2003-04-17 1:13 UTC (permalink / raw)
To: riel; +Cc: coreteam, linux-kernel
From: Rik van Riel <riel@surriel.com>
Date: Wed, 16 Apr 2003 21:11:31 -0400 (EDT)
This patch gets rid of that (presumably old) code block. Note
that I didn't cc this to Marcelo because I'm not 100% sure, so
please check it.
Thanks, I got this fix independantly already. It is correct.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [netfilter-core] [PATCH] compile fix ipfw
2003-04-17 1:11 [PATCH] compile fix ipfw Rik van Riel
2003-04-17 1:13 ` David S. Miller
@ 2003-04-17 5:16 ` Rusty Russell
2003-04-18 8:39 ` David S. Miller
1 sibling, 1 reply; 4+ messages in thread
From: Rusty Russell @ 2003-04-17 5:16 UTC (permalink / raw)
To: Rik van Riel; +Cc: linux-kernel, David S. Miller, coreteam
In message <Pine.LNX.4.44.0304162109530.12650-100000@chimarrao.boston.redhat.co
m> you write:
>
> In the patch that went to marcelo a few days ago the reset
> argument to ip_chain_procinfo() got removed, but there's still
> a code block inside the function that references that variable.
>
> This patch gets rid of that (presumably old) code block. Note
> that I didn't cc this to Marcelo because I'm not 100% sure, so
> please check it.
This looks fine to me: there used to be magic in 2.0 which meant when
you opened the proc file for writing as well as reading, it'd reset
the counters.
These days, the infrastructure doesn't support such a hack.
Please fwd to Marcelo.
Thanks!
Rusty.
> @@ -1176,12 +1176,6 @@ static int ip_chain_procinfo(int stage,
> len = last_len;
> break;
> }
> - else if(reset)
> - {
> - /* This needs to be done at this specific place! */
> - i->fw_pcnt=0L;
> - i->fw_bcnt=0L;
> - }
> last_len = len;
> i=i->fw_next;
> }
>
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-04-18 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-17 1:11 [PATCH] compile fix ipfw Rik van Riel
2003-04-17 1:13 ` David S. Miller
2003-04-17 5:16 ` [netfilter-core] " Rusty Russell
2003-04-18 8:39 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).