archive mirror
 help / color / mirror / Atom feed
From: "YOSHIFUJI Hideaki / 吉藤英明" <>
Subject: Re: IPsecv6 integrity failures not dropped
Date: Sat, 19 Apr 2003 11:50:53 +0900 (JST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

In article <> (at Fri, 18 Apr 2003 15:17:04 -0500), says:

> incoming packet fails, result is an ICMPv6 Parameter problem 
> of Unknown-Next-Header, instead of just dropping packet. This 
> is because xfrm6_rcv() expects an unsigned-8-bit return value 
> from the input handler, i.e. ah6_input() or esp6_input(). But handler 
> returns a signed int (-EINVAL) that seems to be getting converted into 
> a "u8" via 2's complement, because ah6_input() says it is returning
> -EINVAL/-22, but xfrm6_rcv() says it got a return value of 234,
> which it believes to be valid and passes to ip6_input() who thinks it is 
> the next header.  
> I modified ah6_input() and esp6_input() to return zero instead of -EINVAL
> in the fix below. I tested it and it works.

just change u8 nexthdr = 0 to int nexthdr = 0, in xfrm6_rcv() is fine, 
isn't it?

Hideaki YOSHIFUJI @ USAGI Project <>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

  parent reply	other threads:[~2003-04-19  2:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-18 20:17 latten
2003-04-18 21:10 ` David S. Miller
2003-04-19  2:12   ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-19  2:17     ` YOSHIFUJI Hideaki / 吉藤英明
2003-04-19  2:50 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2003-04-20  3:35   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: IPsecv6 integrity failures not dropped' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).