* [PATCH] C99 initializers for drivers/scsi
@ 2003-04-22 16:02 Art Haas
0 siblings, 0 replies; 2+ messages in thread
From: Art Haas @ 2003-04-22 16:02 UTC (permalink / raw)
To: linux-kernel, linux-scsi
Hi.
This set of 4 patches convert files to use C99 initializers. The patches
are against the current BK.
Art Haas
===== drivers/scsi/aic7xxx_old/aic7xxx.h 1.12 vs edited =====
--- 1.12/drivers/scsi/aic7xxx_old/aic7xxx.h Fri Dec 20 20:00:57 2002
+++ edited/drivers/scsi/aic7xxx_old/aic7xxx.h Sat Mar 1 15:43:30 2003
@@ -30,26 +30,26 @@
* to do with card config are filled in after the card is detected.
*/
#define AIC7XXX { \
- proc_info: aic7xxx_proc_info, \
- detect: aic7xxx_detect, \
- release: aic7xxx_release, \
- info: aic7xxx_info, \
- queuecommand: aic7xxx_queue, \
- slave_alloc: aic7xxx_slave_alloc, \
- slave_configure: aic7xxx_slave_configure, \
- slave_destroy: aic7xxx_slave_destroy, \
- bios_param: aic7xxx_biosparam, \
- eh_abort_handler: aic7xxx_abort, \
- eh_device_reset_handler: aic7xxx_bus_device_reset, \
- eh_host_reset_handler: aic7xxx_reset, \
- can_queue: 255, /* max simultaneous cmds */\
- this_id: -1, /* scsi id of host adapter */\
- sg_tablesize: 0, /* max scatter-gather cmds */\
- max_sectors: 2048, /* max physical sectors in 1 cmd */\
- cmd_per_lun: 3, /* cmds per lun (linked cmds) */\
- present: 0, /* number of 7xxx's present */\
- unchecked_isa_dma: 0, /* no memory DMA restrictions */\
- use_clustering: ENABLE_CLUSTERING, \
+ .proc_info = aic7xxx_proc_info, \
+ .detect = aic7xxx_detect, \
+ .release = aic7xxx_release, \
+ .info = aic7xxx_info, \
+ .queuecommand = aic7xxx_queue, \
+ .slave_alloc = aic7xxx_slave_alloc, \
+ .slave_configure = aic7xxx_slave_configure, \
+ .slave_destroy = aic7xxx_slave_destroy, \
+ .bios_param = aic7xxx_biosparam, \
+ .eh_abort_handler = aic7xxx_abort, \
+ .eh_device_reset_handler = aic7xxx_bus_device_reset, \
+ .eh_host_reset_handler = aic7xxx_reset, \
+ .can_queue = 255, /* max simultaneous cmds */\
+ .this_id = -1, /* scsi id of host adapter */\
+ .sg_tablesize = 0, /* max scatter-gather cmds */\
+ .max_sectors = 2048, /* max physical sectors in 1 cmd */\
+ .cmd_per_lun = 3, /* cmds per lun (linked cmds) */\
+ .present = 0, /* number of 7xxx's present */\
+ .unchecked_isa_dma = 0, /* no memory DMA restrictions */\
+ .use_clustering = ENABLE_CLUSTERING, \
}
extern int aic7xxx_queue(Scsi_Cmnd *, void (*)(Scsi_Cmnd *));
===== drivers/scsi/sym53c8xx_2/sym53c8xx.h 1.7 vs edited =====
--- 1.7/drivers/scsi/sym53c8xx_2/sym53c8xx.h Thu Nov 21 23:34:45 2002
+++ edited/drivers/scsi/sym53c8xx_2/sym53c8xx.h Sat Mar 1 15:48:32 2003
@@ -106,22 +106,22 @@
#include <scsi/scsicam.h>
#define SYM53C8XX { \
- name: "sym53c8xx", \
- detect: sym53c8xx_detect, \
- release: sym53c8xx_release, \
- info: sym53c8xx_info, \
- queuecommand: sym53c8xx_queue_command, \
- slave_configure: sym53c8xx_slave_configure, \
- eh_abort_handler: sym53c8xx_eh_abort_handler, \
- eh_device_reset_handler:sym53c8xx_eh_device_reset_handler, \
- eh_bus_reset_handler: sym53c8xx_eh_bus_reset_handler, \
- eh_host_reset_handler: sym53c8xx_eh_host_reset_handler, \
- can_queue: 0, \
- this_id: 7, \
- sg_tablesize: 0, \
- cmd_per_lun: 0, \
- use_clustering: DISABLE_CLUSTERING, \
- highmem_io: 1}
+ .name = "sym53c8xx", \
+ .detect = sym53c8xx_detect, \
+ .release = sym53c8xx_release, \
+ .info = sym53c8xx_info, \
+ .queuecommand = sym53c8xx_queue_command, \
+ .slave_configure = sym53c8xx_slave_configure, \
+ .eh_abort_handler = sym53c8xx_eh_abort_handler, \
+ .eh_device_reset_handler = sym53c8xx_eh_device_reset_handler,\
+ .eh_bus_reset_handler = sym53c8xx_eh_bus_reset_handler, \
+ .eh_host_reset_handler = sym53c8xx_eh_host_reset_handler, \
+ .can_queue = 0, \
+ .this_id = 7, \
+ .sg_tablesize = 0, \
+ .cmd_per_lun = 0, \
+ .use_clustering = DISABLE_CLUSTERING, \
+ .highmem_io = 1}
#endif /* defined(HOSTS_C) || defined(MODULE) */
===== drivers/scsi/3w-xxxx.c 1.28 vs edited =====
--- 1.28/drivers/scsi/3w-xxxx.c Wed Mar 26 14:10:23 2003
+++ edited/drivers/scsi/3w-xxxx.c Wed Apr 2 07:15:18 2003
@@ -226,10 +226,10 @@
/* File operations struct for character device */
static struct file_operations tw_fops = {
- owner: THIS_MODULE,
- ioctl: tw_chrdev_ioctl,
- open: tw_chrdev_open,
- release: tw_chrdev_release
+ .owner = THIS_MODULE,
+ .ioctl = tw_chrdev_ioctl,
+ .open = tw_chrdev_open,
+ .release = tw_chrdev_release
};
/* Globals */
===== drivers/scsi/gdth.c 1.22 vs edited =====
--- 1.22/drivers/scsi/gdth.c Thu Mar 6 17:11:01 2003
+++ edited/drivers/scsi/gdth.c Wed Apr 2 07:14:37 2003
@@ -747,9 +747,9 @@
#ifdef GDTH_IOCTL_CHRDEV
/* ioctl interface */
static struct file_operations gdth_fops = {
- ioctl:gdth_ioctl,
- open:gdth_open,
- release:gdth_close,
+ .ioctl = gdth_ioctl,
+ .open = gdth_open,
+ .release = gdth_close,
};
#endif
--
To announce that there must be no criticism of the President, or that we
are to stand by the President, right or wrong, is not only unpatriotic
and servile, but is morally treasonable to the American public.
-- Theodore Roosevelt, Kansas City Star, 1918
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] C99 initializers for drivers/scsi
@ 2002-11-18 17:29 Art Haas
0 siblings, 0 replies; 2+ messages in thread
From: Art Haas @ 2002-11-18 17:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Torvalds
Hi.
Here's a set of patches for drivers/scsi that switch the files to use
C99 initializers. The patches are against 2.5.48.
Art Haas
--- linux-2.5.48/drivers/scsi/NCR53c406a.c.old 2002-11-11 07:14:43.000000000 -0600
+++ linux-2.5.48/drivers/scsi/NCR53c406a.c 2002-11-18 01:11:24.000000000 -0600
@@ -1070,23 +1070,23 @@
static Scsi_Host_Template driver_template =
{
- proc_name: "NCR53c406a" /* proc_name */,
- name: "NCR53c406a" /* name */,
- detect: NCR53c406a_detect /* detect */,
- info: NCR53c406a_info /* info */,
- command: NCR53c406a_command /* command */,
- queuecommand: NCR53c406a_queue /* queuecommand */,
- eh_abort_handler: NCR53c406a_abort /* abort */,
- eh_bus_reset_handler: NCR53c406a_bus_reset /* reset */,
- eh_device_reset_handler: NCR53c406a_device_reset /* reset */,
- eh_host_reset_handler: NCR53c406a_host_reset /* reset */,
- bios_param: NCR53c406a_biosparm /* biosparm */,
- can_queue: 1 /* can_queue */,
- this_id: 7 /* SCSI ID of the chip */,
- sg_tablesize: 32 /*SG_ALL*/ /*SG_NONE*/,
- cmd_per_lun: 1 /* commands per lun */,
- unchecked_isa_dma: 1 /* unchecked_isa_dma */,
- use_clustering: ENABLE_CLUSTERING
+ .proc_name = "NCR53c406a" /* proc_name */,
+ .name = "NCR53c406a" /* name */,
+ .detect = NCR53c406a_detect /* detect */,
+ .info = NCR53c406a_info /* info */,
+ .command = NCR53c406a_command /* command */,
+ .queuecommand = NCR53c406a_queue /* queuecommand */,
+ .eh_abort_handler = NCR53c406a_abort /* abort */,
+ .eh_bus_reset_handler = NCR53c406a_bus_reset /* reset */,
+ .eh_device_reset_handler = NCR53c406a_device_reset /* reset */,
+ .eh_host_reset_handler = NCR53c406a_host_reset /* reset */,
+ .bios_param = NCR53c406a_biosparm /* biosparm */,
+ .can_queue = 1 /* can_queue */,
+ .this_id = 7 /* SCSI ID of the chip */,
+ .sg_tablesize = 32 /*SG_ALL*/ /*SG_NONE*/,
+ .cmd_per_lun = 1 /* commands per lun */,
+ .unchecked_isa_dma = 1 /* unchecked_isa_dma */,
+ .use_clustering = ENABLE_CLUSTERING
};
#include "scsi_module.c"
--- linux-2.5.48/drivers/scsi/dpt_i2o.c.old 2002-11-18 01:02:08.000000000 -0600
+++ linux-2.5.48/drivers/scsi/dpt_i2o.c 2002-11-18 10:38:43.000000000 -0600
@@ -112,9 +112,9 @@
static int hba_count = 0;
static struct file_operations adpt_fops = {
- ioctl: adpt_ioctl,
- open: adpt_open,
- release: adpt_close
+ .ioctl = adpt_ioctl,
+ .open = adpt_open,
+ .release = adpt_close
};
#ifdef REBOOT_NOTIFIER
--- linux-2.5.48/drivers/scsi/ide-scsi.c.old 2002-11-05 09:33:43.000000000 -0600
+++ linux-2.5.48/drivers/scsi/ide-scsi.c 2002-11-18 01:10:40.000000000 -0600
@@ -859,20 +859,20 @@
}
static Scsi_Host_Template idescsi_template = {
- module: THIS_MODULE,
- name: "idescsi",
- detect: idescsi_detect,
- release: idescsi_release,
- info: idescsi_info,
- ioctl: idescsi_ioctl,
- queuecommand: idescsi_queue,
- bios_param: idescsi_bios,
- can_queue: 10,
- this_id: -1,
- sg_tablesize: 256,
- cmd_per_lun: 5,
- use_clustering: DISABLE_CLUSTERING,
- emulated: 1,
+ .module = THIS_MODULE,
+ .name = "idescsi",
+ .detect = idescsi_detect,
+ .release = idescsi_release,
+ .info = idescsi_info,
+ .ioctl = idescsi_ioctl,
+ .queuecommand = idescsi_queue,
+ .bios_param = idescsi_bios,
+ .can_queue = 10,
+ .this_id = -1,
+ .sg_tablesize = 256,
+ .cmd_per_lun = 5,
+ .use_clustering = DISABLE_CLUSTERING,
+ .emulated = 1,
};
static int __init init_idescsi_module(void)
--- linux-2.5.48/drivers/scsi/imm.c.old 2002-10-31 16:20:05.000000000 -0600
+++ linux-2.5.48/drivers/scsi/imm.c 2002-11-18 10:40:05.000000000 -0600
@@ -47,17 +47,9 @@
} imm_struct;
#define IMM_EMPTY \
-{ dev: NULL, \
- base: -1, \
- base_hi: 0, \
- mode: IMM_AUTODETECT, \
- host: -1, \
- cur_cmd: NULL, \
- jstart: 0, \
- failed: 0, \
- dp: 0, \
- rd: 0, \
- p_busy: 0 \
+ .base = -1, \
+ .mode = IMM_AUTODETECT, \
+ .host = -1, \
}
#include "imm.h"
--- linux-2.5.48/drivers/scsi/ips.c.old 2002-10-31 16:20:05.000000000 -0600
+++ linux-2.5.48/drivers/scsi/ips.c 2002-11-18 01:10:38.000000000 -0600
@@ -317,24 +317,24 @@
static void __devexit ips_remove_device(struct pci_dev *pci_dev);
struct pci_driver ips_pci_driver = {
- name: ips_hot_plug_name,
- id_table: ips_pci_table,
- probe: ips_insert_device,
- remove: __devexit_p(ips_remove_device),
+ .name = ips_hot_plug_name,
+ .id_table = ips_pci_table,
+ .probe = ips_insert_device,
+ .remove = __devexit_p(ips_remove_device),
};
struct pci_driver ips_pci_driver_5i = {
- name: ips_hot_plug_name,
- id_table: ips_pci_table_5i,
- probe: ips_insert_device,
- remove: __devexit_p(ips_remove_device),
+ .name = ips_hot_plug_name,
+ .id_table = ips_pci_table_5i,
+ .probe = ips_insert_device,
+ .remove = __devexit_p(ips_remove_device),
};
struct pci_driver ips_pci_driver_i960 = {
- name: ips_hot_plug_name,
- id_table: ips_pci_table_i960,
- probe: ips_insert_device,
- remove: __devexit_p(ips_remove_device),
+ .name = ips_hot_plug_name,
+ .id_table = ips_pci_table_i960,
+ .probe = ips_insert_device,
+ .remove = __devexit_p(ips_remove_device),
};
#endif
--- linux-2.5.48/drivers/scsi/nsp32.c.old 2002-10-31 16:20:06.000000000 -0600
+++ linux-2.5.48/drivers/scsi/nsp32.c 2002-11-18 01:11:31.000000000 -0600
@@ -2066,53 +2066,53 @@
static struct pci_device_id nsp32_pci_table[] __devinitdata = {
{
- vendor: PCI_VENDOR_ID_IODATA,
- device: PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
- driver_data: MODEL_IODATA,
+ .vendor = PCI_VENDOR_ID_IODATA,
+ .device = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = MODEL_IODATA,
},
{
- vendor: PCI_VENDOR_ID_WORKBIT,
- device: PCI_DEVICE_ID_NINJASCSI_32BI_KME,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
- driver_data: MODEL_KME,
+ .vendor = PCI_VENDOR_ID_WORKBIT,
+ .device = PCI_DEVICE_ID_NINJASCSI_32BI_KME,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = MODEL_KME,
},
{
- vendor: PCI_VENDOR_ID_WORKBIT,
- device: PCI_DEVICE_ID_NINJASCSI_32BI_WBT,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
- driver_data: MODEL_WORKBIT,
+ .vendor = PCI_VENDOR_ID_WORKBIT,
+ .device = PCI_DEVICE_ID_NINJASCSI_32BI_WBT,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = MODEL_WORKBIT,
},
{
- vendor: PCI_VENDOR_ID_WORKBIT,
- device: PCI_DEVICE_ID_WORKBIT_STANDARD,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
- driver_data: MODEL_PCI_WORKBIT,
+ .vendor = PCI_VENDOR_ID_WORKBIT,
+ .device = PCI_DEVICE_ID_WORKBIT_STANDARD,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = MODEL_PCI_WORKBIT,
},
{
- vendor: PCI_VENDOR_ID_WORKBIT,
- device: PCI_DEVICE_ID_NINJASCSI_32BI_LOGITEC,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
- driver_data: MODEL_EXT_ROM,
+ .vendor = PCI_VENDOR_ID_WORKBIT,
+ .device = PCI_DEVICE_ID_NINJASCSI_32BI_LOGITEC,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = MODEL_EXT_ROM,
},
{
- vendor: PCI_VENDOR_ID_WORKBIT,
- device: PCI_DEVICE_ID_NINJASCSI_32BIB_LOGITEC,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
- driver_data: MODEL_PCI_LOGITEC,
+ .vendor = PCI_VENDOR_ID_WORKBIT,
+ .device = PCI_DEVICE_ID_NINJASCSI_32BIB_LOGITEC,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = MODEL_PCI_LOGITEC,
},
{
- vendor: PCI_VENDOR_ID_WORKBIT,
- device: PCI_DEVICE_ID_NINJASCSI_32UDE_MELCO,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
- driver_data: MODEL_PCI_MELCO,
+ .vendor = PCI_VENDOR_ID_WORKBIT,
+ .device = PCI_DEVICE_ID_NINJASCSI_32UDE_MELCO,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .driver_data = MODEL_PCI_MELCO,
},
{0,0,},
};
--- linux-2.5.48/drivers/scsi/osst.c.old 2002-11-18 01:02:09.000000000 -0600
+++ linux-2.5.48/drivers/scsi/osst.c 2002-11-18 01:11:03.000000000 -0600
@@ -160,13 +160,13 @@
struct Scsi_Device_Template osst_template =
{
- module: THIS_MODULE,
- list: LIST_HEAD_INIT(osst_template.list),
- name: "OnStream tape",
- tag: "osst",
- scsi_type: TYPE_TAPE,
- attach: osst_attach,
- detach: osst_detach
+ .module = THIS_MODULE,
+ .list = LIST_HEAD_INIT(osst_template.list),
+ .name = "OnStream tape",
+ .tag = "osst",
+ .scsi_type = TYPE_TAPE,
+ .attach = osst_attach,
+ .detach = osst_detach
};
static int osst_int_ioctl(OS_Scsi_Tape *STp, Scsi_Request ** aSRpnt, unsigned int cmd_in,unsigned long arg);
@@ -5354,12 +5354,12 @@
static struct file_operations osst_fops = {
- read: osst_read,
- write: osst_write,
- ioctl: osst_ioctl,
- open: os_scsi_tape_open,
- flush: os_scsi_tape_flush,
- release: os_scsi_tape_close,
+ .read = osst_read,
+ .write = osst_write,
+ .ioctl = osst_ioctl,
+ .open = os_scsi_tape_open,
+ .flush = os_scsi_tape_flush,
+ .release = os_scsi_tape_close,
};
static int osst_supports(Scsi_Device * SDp)
--- linux-2.5.48/drivers/scsi/ppa.c.old 2002-10-31 16:20:07.000000000 -0600
+++ linux-2.5.48/drivers/scsi/ppa.c 2002-11-18 10:41:16.000000000 -0600
@@ -38,16 +38,11 @@
} ppa_struct;
#define PPA_EMPTY \
-{ dev: NULL, \
- base: -1, \
- mode: PPA_AUTODETECT, \
- host: -1, \
- cur_cmd: NULL, \
- ppa_tq: { func: ppa_interrupt }, \
- jstart: 0, \
- recon_tmo: PPA_RECON_TMO, \
- failed: 0, \
- p_busy: 0 \
+ .base = -1, \
+ .mode = PPA_AUTODETECT, \
+ .host = -1, \
+ .ppa_tq = { .func = ppa_interrupt }, \
+ .recon_tmo = PPA_RECON_TMO, \
}
#include "ppa.h"
--- linux-2.5.48/drivers/scsi/scsi.c.old 2002-11-18 01:02:09.000000000 -0600
+++ linux-2.5.48/drivers/scsi/scsi.c 2002-11-18 10:42:42.000000000 -0600
@@ -2199,8 +2199,8 @@
}
struct bus_type scsi_driverfs_bus_type = {
- name: "scsi",
- match: scsi_bus_match,
+ .name = "scsi",
+ .match = scsi_bus_match,
};
static int __init init_scsi(void)
--- linux-2.5.48/drivers/scsi/tmscsim.c.old 2002-11-18 01:02:10.000000000 -0600
+++ linux-2.5.48/drivers/scsi/tmscsim.c 2002-11-18 10:43:07.000000000 -0600
@@ -276,10 +276,10 @@
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,3,99)
static struct pci_device_id tmscsim_pci_tbl[] __initdata = {
{
- vendor: PCI_VENDOR_ID_AMD,
- device: PCI_DEVICE_ID_AMD53C974,
- subvendor: PCI_ANY_ID,
- subdevice: PCI_ANY_ID,
+ .vendor = PCI_VENDOR_ID_AMD,
+ .device = PCI_DEVICE_ID_AMD53C974,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
},
{ } /* Terminating entry */
};
--
They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety.
-- Benjamin Franklin, Historical Review of Pennsylvania, 1759
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-22 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-22 16:02 [PATCH] C99 initializers for drivers/scsi Art Haas
-- strict thread matches above, loose matches on Subject: below --
2002-11-18 17:29 Art Haas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).