[2.4] Memleak in Essential RoadRunner HIPPI board driver (resend)

[2.4] Memleak in Essential RoadRunner HIPPI board driver (resend)

[Oleg Drokin]

Hello!

  I got no reply on the first try. Also the patch is not present neither
  in current 2.4 bk nor in 2.4.21-pre7-ac2, so I am resending.

----- Forwarded message from Oleg Drokin <green@linuxhacker.ru> -----

Date: Wed, 12 Mar 2003 22:08:46 +0300
From: Oleg Drokin <green@linuxhacker.ru>
To: alan@redhat.com, linux-kernel@vger.kernel.org, Jes.Sorensen@cern.ch
Subject: [2.4] Memleak in Essential RoadRunner HIPPI board driver
User-Agent: Mutt/1.4i

Hello!

   There is memleak on error exit path. Seems there was some confusion
   in the mind of whoever added that zeroing statement.
   The patch is trivial, 2.5 is not affected.
   Found with help of smatch + enhanced unfree script

Bye,
    Oleg

===== drivers/net/rrunner.c 1.6 vs edited =====
--- 1.6/drivers/net/rrunner.c	Thu Feb 28 16:57:24 2002
+++ edited/drivers/net/rrunner.c	Wed Mar 12 22:05:15 2003
@@ -1216,7 +1216,6 @@
 
 	rrpriv->info = kmalloc(sizeof(struct rr_info), GFP_KERNEL);
 	if (!rrpriv->info){
-		rrpriv->rx_ctrl = NULL;
 		ecode = -ENOMEM;
 		goto error;
 	}

----- End forwarded message -----