From: Duncan Sands <baldrick@wanadoo.fr>
To: linux-usb-devel@lists.sourceforge.net
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] USB speedtouch: crc optimization
Date: Wed, 23 Apr 2003 10:50:53 +0200 [thread overview]
Message-ID: <200304231050.53630.baldrick@wanadoo.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
speedtch.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
+++ b/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
@@ -406,11 +406,12 @@
** encode **
*************/
+static const unsigned char zeros[ATM_CELL_PAYLOAD];
+
static void udsl_groom_skb (struct atm_vcc *vcc, struct sk_buff *skb)
{
struct udsl_control *ctrl = UDSL_SKB (skb);
- unsigned int i, zero_padding;
- unsigned char zero = 0;
+ unsigned int zero_padding;
u32 crc;
ctrl->atm_data.vcc = vcc;
@@ -436,8 +437,7 @@
ctrl->aal5_trailer [3] = skb->len;
crc = crc32_be (~0, skb->data, skb->len);
- for (i = 0; i < zero_padding; i++)
- crc = crc32_be (crc, &zero, 1);
+ crc = crc32_be (crc, zeros, zero_padding);
crc = crc32_be (crc, ctrl->aal5_trailer, 4);
crc = ~crc;
[-- Attachment #2: send-2.4.diff --]
[-- Type: text/x-diff, Size: 901 bytes --]
speedtouch.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/speedtouch.c b/drivers/usb/speedtouch.c
--- a/drivers/usb/speedtouch.c Wed Apr 23 10:48:28 2003
+++ b/drivers/usb/speedtouch.c Wed Apr 23 10:48:28 2003
@@ -406,11 +406,12 @@
** encode **
*************/
+static const unsigned char zeros[ATM_CELL_PAYLOAD];
+
static void udsl_groom_skb (struct atm_vcc *vcc, struct sk_buff *skb)
{
struct udsl_control *ctrl = UDSL_SKB (skb);
- unsigned int i, zero_padding;
- unsigned char zero = 0;
+ unsigned int zero_padding;
u32 crc;
ctrl->atm_data.vcc = vcc;
@@ -436,8 +437,7 @@
ctrl->aal5_trailer [3] = skb->len;
crc = crc32_be (~0, skb->data, skb->len);
- for (i = 0; i < zero_padding; i++)
- crc = crc32_be (crc, &zero, 1);
+ crc = crc32_be (crc, zeros, zero_padding);
crc = crc32_be (crc, ctrl->aal5_trailer, 4);
crc = ~crc;
[-- Attachment #3: send-2.5.diff --]
[-- Type: text/x-diff, Size: 911 bytes --]
speedtch.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
+++ b/drivers/usb/misc/speedtch.c Wed Apr 23 10:48:07 2003
@@ -406,11 +406,12 @@
** encode **
*************/
+static const unsigned char zeros[ATM_CELL_PAYLOAD];
+
static void udsl_groom_skb (struct atm_vcc *vcc, struct sk_buff *skb)
{
struct udsl_control *ctrl = UDSL_SKB (skb);
- unsigned int i, zero_padding;
- unsigned char zero = 0;
+ unsigned int zero_padding;
u32 crc;
ctrl->atm_data.vcc = vcc;
@@ -436,8 +437,7 @@
ctrl->aal5_trailer [3] = skb->len;
crc = crc32_be (~0, skb->data, skb->len);
- for (i = 0; i < zero_padding; i++)
- crc = crc32_be (crc, &zero, 1);
+ crc = crc32_be (crc, zeros, zero_padding);
crc = crc32_be (crc, ctrl->aal5_trailer, 4);
crc = ~crc;
next reply other threads:[~2003-04-23 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 8:50 Duncan Sands [this message]
2003-04-23 19:34 ` [PATCH] USB speedtouch: crc optimization Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304231050.53630.baldrick@wanadoo.fr \
--to=baldrick@wanadoo.fr \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).