linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Collins <bcollins@debian.org>
To: Stelian Pop <stelian.pop@fr.alcove.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ]
Date: Wed, 23 Apr 2003 09:54:48 -0400	[thread overview]
Message-ID: <20030423135448.GI354@phunnypharm.org> (raw)
In-Reply-To: <20030423135814.GJ820@hottah.alcove-fr>

On Wed, Apr 23, 2003 at 03:58:14PM +0200, Stelian Pop wrote:
> On Wed, Apr 23, 2003 at 09:32:56AM -0400, Ben Collins wrote:
> 
> > > Can we see it please ?
> > 
> > Stelia,
> > 
> > http://www.linux1394.org/viewcvs/ieee1394/branches/linux-2.4
> > 
> > Click the "Download tarball" link and replace drivers/ieee1394 with what
> > you get.
> 
> Hey, that's a whole new version of ieee1394 subsystem, see below the
> diffstat.
> 
> There is *NO WAY* Marcelo will accept such a patch in the -rc stage.
> 
> >From a quick reading, your version seem to do exactly the same thing
> that my patch suggested (removing the spinlock around kernel_thread()),
> possibly with the locking being moved to the upper layer.
> 
> Do you have a stripped down patch correcting only the outstanding issues ?
> If you haven't, the choice will be either accepting my patch or 
> reverting your entire ieee1394 changes for the time being.
> 

Your patch leaves a race condition open. And no, I don't have a stripped
down patch. It's impossible for me to syncronize layers of linux1394
development with the timing of 2.4/2.5 development. The size of the
current 2.4 diff is only because of the amount of stuff merged from our
2.5 tree and a serious code cleanup (fixing locking problems like you saw
here).

Fixing your particular locking problem required removal of some shared
data, which required an additional API in the lowlevel subsystem. It's
not trivial to extrapolate just this from the patch.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/

  reply	other threads:[~2003-04-23 13:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-23 12:29 IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ] Tony Spinillo
2003-04-23 12:53 ` Stelian Pop
2003-04-23 13:01   ` Ben Collins
2003-04-23 13:22     ` Stelian Pop
2003-04-23 13:32       ` Ben Collins
2003-04-23 13:46         ` Ben Collins
2003-04-23 13:58         ` Stelian Pop
2003-04-23 13:54           ` Ben Collins [this message]
2003-04-23 14:21             ` Stelian Pop
2003-04-23 14:23               ` Ben Collins
2003-04-23 14:51                 ` Stelian Pop
2003-04-23 14:44                   ` Ben Collins
2003-04-23 14:48                   ` Ben Collins
2003-04-23 15:29                     ` Stelian Pop
2003-04-23 19:13                       ` Marcelo Tosatti
2003-04-23 19:05                         ` Ben Collins
2003-04-23 19:27                           ` Marcelo Tosatti
2003-04-23 20:20                         ` Stelian Pop
2003-04-23 20:24                           ` Ben Collins
2003-04-23 20:42                             ` Stelian Pop
2003-04-26  8:29                               ` The IEEE-1394 saga continued... [ was: IEEE-1394 problem on init ] Stelian Pop
2003-04-26 14:34                                 ` Ben Collins
2003-04-26 16:10                                   ` Stelian Pop
2003-04-26 16:12                                     ` Ben Collins
2003-04-26 17:00                                       ` Stelian Pop
2003-04-26 16:59                                         ` Ben Collins
2003-04-26 14:40                                 ` Ben Collins
2003-04-26 16:23                                   ` Stelian Pop
2003-04-26 16:25                                     ` Ben Collins
2003-04-26 17:15                                       ` Stelian Pop
2003-04-24 21:44                         ` IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ] Bill Davidsen
2003-04-24 21:41                           ` Ben Collins
2003-04-25 18:06                             ` Bill Davidsen
2003-04-25 18:16                               ` Ben Collins
2003-04-26 10:36                                 ` Bill Davidsen
  -- strict thread matches above, loose matches on Subject: below --
2003-04-21 18:47 Linux 2.4.21-rc1 Marcelo Tosatti
2003-04-23  7:59 ` IEEE-1394 problem on init [ was Re: Linux 2.4.21-rc1 ] Stelian Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030423135448.GI354@phunnypharm.org \
    --to=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stelian.pop@fr.alcove.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).