From: Jens Axboe <axboe@kernel.org>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: mikem@beardog.cca.cpqcorp.net, linux-kernel@vger.kernel.org,
mike.miller@hp.com, steve.cameron@hp.com
Subject: Re: RE:cciss patches for 2.4.21-rc1, 4 of 4
Date: Fri, 25 Apr 2003 16:32:21 +0200 [thread overview]
Message-ID: <20030425143221.GQ1012@suse.de> (raw)
In-Reply-To: <1051279472.1391.15.camel@laptop.fenrus.com>
On Fri, Apr 25 2003, Arjan van de Ven wrote:
> On Fri, 2003-04-25 at 00:12, mikem@beardog.cca.cpqcorp.net wrote:
> > 20030424
> >
> > Changes:
> > 1. Sets the DMA mask to 64 bits. Removes RH's code for the DMA mask.
> >
> > diff -urN lx2421rc1-p3/drivers/block/cciss.c lx2421rc1/drivers/block/cciss.c
> > --- lx2421rc1-p3/drivers/block/cciss.c Wed Apr 23 14:40:48 2003
> > +++ lx2421rc1/drivers/block/cciss.c Wed Apr 23 14:51:55 2003
> > @@ -106,7 +106,7 @@
> > #define NR_CMDS 128 /* #commands that can be outstanding */
> > #define MAX_CTLR 8
> >
> > -#define CCISS_DMA_MASK 0xFFFFFFFF /* 32 bit DMA */
> > +#define CCISS_DMA_MASK 0xFFFFFFFFFFFFFFFF /* 64 bit DMA */
> >
> > static ctlr_info_t *hba[MAX_CTLR];
> >
> > @@ -2861,17 +2861,6 @@
> > hba[i]->ctlr = i;
> > hba[i]->pdev = pdev;
> >
> > - /* configure PCI DMA stuff */
> > - if (!pci_set_dma_mask(pdev, (u64) 0xffffffffffffffff))
> > - printk("cciss: using DAC cycles\n");
> > - else if (!pci_set_dma_mask(pdev, (u64) 0xffffffff))
> > - printk("cciss: not using DAC cycles\n");
> > - else {
> > - printk("cciss: no suitable DMA available\n");
> > - free_hba(i);
> > - return -ENODEV;
> > - }
> > -
>
>
> this is wrong. The code there is EXACTLY what is needed as per
> Documentation/DMA-mapping.txt, removing it is a bug.
Agree, besides, it was never RH code, dunno where that idea came from?
--
Jens Axboe
prev parent reply other threads:[~2003-04-25 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-24 22:12 RE:cciss patches for 2.4.21-rc1, 4 of 4 mikem
2003-04-25 14:04 ` Arjan van de Ven
2003-04-25 14:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030425143221.GQ1012@suse.de \
--to=axboe@kernel.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=mikem@beardog.cca.cpqcorp.net \
--cc=steve.cameron@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).