linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: Dipankar Sarma <dipankar@in.ibm.com>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reducing overheads in fget/fput
Date: Mon, 28 Apr 2003 20:32:28 +0100	[thread overview]
Message-ID: <20030428193228.GP10374@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030428165240.GA1105@in.ibm.com>

On Mon, Apr 28, 2003 at 10:22:40PM +0530, Dipankar Sarma wrote:
> Does this approach make sense ? Or am I missing some big gotcha
> somewhere ? Oh, btw the patch survives LTP.

You are.  Have a process share file table at the time of call and
have its sibling die in the middle.  Oops - condition that had
been true at time of fget_light() (->files->count > 1) is false
at the time we fput_light().  Have fun - we had just leaked a
reference to struct file.

  reply	other threads:[~2003-04-28 19:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-28 16:52 [PATCH] reducing overheads in fget/fput Dipankar Sarma
2003-04-28 19:32 ` viro [this message]
2003-04-28 19:58   ` Dipankar Sarma
2003-05-02 17:17     ` Dipankar Sarma
2003-05-02 20:54       ` Andrew Morton
2003-05-03  3:53         ` Dipankar Sarma
2003-05-03  4:00           ` Andrew Morton
2003-05-03  4:24             ` Dipankar Sarma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030428193228.GP10374@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=akpm@digeo.com \
    --cc=dipankar@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).