From: Andrew Morton <akpm@digeo.com>
To: dipankar@in.ibm.com
Cc: viro@parcelfarce.linux.theplanet.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reducing overheads in fget/fput
Date: Fri, 2 May 2003 21:00:03 -0700 [thread overview]
Message-ID: <20030502210003.7ab96802.akpm@digeo.com> (raw)
In-Reply-To: <20030503035300.GA1407@in.ibm.com>
Dipankar Sarma <dipankar@in.ibm.com> wrote:
>
> On Fri, May 02, 2003 at 01:54:04PM -0700, Andrew Morton wrote:
> > Dipankar Sarma <dipankar@in.ibm.com> wrote:
> > > Here is a patch that fixes that.
> >
> > This patch is fairly foul.
>
> Not sure what your grouse is, but I don't like the fget_ligth()/fput_light
> semantics myself. They don't seem natural, but I can't think of
> better way to do this.
Precisely.
> >
> > > kernel sys time std-dev
> > > ------------ -------- -------
> > > UP - vanilla 2.104 0.028
> > > SMP - vanilla 2.976 0.023
> > > UP - file 1.867 0.019
> > > SMP - file 2.719 0.026
> >
> > But it is localised, and makes a substantial difference.
>
> If I haven't broken too many things, then I will try to get some
> performance results from large machines.
P4's will like it more.
> >
> > I inlined fput_light:
>
> Looks good.
I also renamed `flag' to `fput_needed' everywhere.
next prev parent reply other threads:[~2003-05-03 3:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-28 16:52 [PATCH] reducing overheads in fget/fput Dipankar Sarma
2003-04-28 19:32 ` viro
2003-04-28 19:58 ` Dipankar Sarma
2003-05-02 17:17 ` Dipankar Sarma
2003-05-02 20:54 ` Andrew Morton
2003-05-03 3:53 ` Dipankar Sarma
2003-05-03 4:00 ` Andrew Morton [this message]
2003-05-03 4:24 ` Dipankar Sarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030502210003.7ab96802.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).