* Re: [PATCH] Linux 2.5.68 - Fix module_put after return statement
2003-05-01 19:48 [PATCH] Linux 2.5.68 - Fix module_put after return statement Gabriel Devenyi
@ 2003-04-30 21:59 ` Francois Romieu
0 siblings, 0 replies; 2+ messages in thread
From: Francois Romieu @ 2003-04-30 21:59 UTC (permalink / raw)
To: Gabriel Devenyi; +Cc: khc, linux-kernel
Gabriel Devenyi <devenyga@mcmaster.ca> :
[linux-2.5.68/drivers/net/wan/c101.c]
Already fixed in Linus's repository.
--
Ueimor
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] Linux 2.5.68 - Fix module_put after return statement
@ 2003-05-01 19:48 Gabriel Devenyi
2003-04-30 21:59 ` Francois Romieu
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Devenyi @ 2003-05-01 19:48 UTC (permalink / raw)
To: khc; +Cc: linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch applies to 2.5.68. Its listed on kbugs.org. The function module_put is never called because it is after return.
Please CC me with any discussion.
- --
Building the Future,
Gabriel Devenyi
devenyga@mcmaster.ca
- ---FILE---
- --- linux-2.5.68/drivers/net/wan/c101.c 2003-04-19 22:50:34.000000000 -0400
+++ linux-2.5.68-changed/drivers/net/wan/c101.c 2003-05-01 15:04:23.000000000 -0400
@@ -161,8 +161,8 @@
int result = hdlc_open(hdlc);
if (result) {
- - return result;
module_put(THIS_MODULE);
+ return result;
}
writeb(1, port->win0base + C101_DTR);
- ---ENDFILE---
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+sXn/7I5UBdiZaF4RAitxAJ9UHBL/iO7nuElsJkIBTqivnGoGDQCfQYbj
6ZrVhEXv1ir82/V/KKHjEQI=
=xOsM
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-30 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-01 19:48 [PATCH] Linux 2.5.68 - Fix module_put after return statement Gabriel Devenyi
2003-04-30 21:59 ` Francois Romieu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).