[PATCH][v850] Add leading underline to new linker-script symbols on the v850

[PATCH][v850] Add leading underline to new linker-script symbols on the v850

[Miles Bader]

This is needed to match the output of the C compiler.

diff -ruN -X../cludes linux-2.5.69-uc0/arch/v850/vmlinux.lds.S linux-2.5.69-uc0-v850-20030506/arch/v850/vmlinux.lds.S
--- linux-2.5.69-uc0/arch/v850/vmlinux.lds.S	2003-04-21 10:52:40.000000000 +0900
+++ linux-2.5.69-uc0-v850-20030506/arch/v850/vmlinux.lds.S	2003-05-06 10:40:26.000000000 +0900
@@ -105,9 +110,9 @@
 #define RAMK_INIT_CONTENTS_NO_END					      \
 		. = ALIGN (4096) ;					      \
 		__init_start = . ;					      \
-			_sinittext = .;					      \
+			__sinittext = .;				      \
 			*(.init.text)	/* 2.5 convention */		      \
-			_einittext = .;					      \
+			__einittext = .;				      \
 			*(.init.data)					      \
 			*(.text.init)	/* 2.4 convention */		      \
 			*(.data.init)					      \

Re: [PATCH][v850] Add leading underline to new linker-script symbols on the v850

[David S. Miller]

Why are you submitting patches that define
flush_page_to_ram() to anything?

That interface is deleted in 2.5.x, no platform
should define it and nothing in the kernel invokes
it.

If you need something like that internally, use a
name such as v850_flush_page_to_ram().

Re: [PATCH][v850] Add leading underline to new linker-script symbols on the v850

[Miles Bader]

"David S. Miller" <davem@redhat.com> writes:
> Why are you submitting patches that define flush_page_to_ram() to
> anything?
> 
> That interface is deleted in 2.5.x, no platform should define it and
> nothing in the kernel invokes it.

I think in this case it's because I try to keep the v850 arch files
identical on 2.4.x and 2.5.x (as much as is possible), which sometimes
results in unused #defines on one or the other.

-Miles
-- 
[|nurgle|]  ddt- demonic? so quake will have an evil kinda setting? one that
            will  make every christian in the world foamm at the mouth?
[iddt]      nurg, that's the goal

Re: [PATCH][v850] Add leading underline to new linker-script symbols on the v850

[David S. Miller]

   From: Miles Bader <miles@lsi.nec.co.jp>
   Date: 06 May 2003 14:12:40 +0900
   
   I think in this case it's because I try to keep the v850 arch files
   identical on 2.4.x and 2.5.x (as much as is possible), which sometimes
   results in unused #defines on one or the other.

Please don't do that, 2.4.x and 2.5.x are different kernel.
There will be differences, just accept them.

Some of us use grepping tools to see if arch's depend upon
deleted interfaces still existing, and once we start adding
exceptions such as yours the tools become less and less useful.

Therefore, please delete the flush_page_to_ram define on v850.
Thank you.

Re: [PATCH][v850] Add leading underline to new linker-script symbols on the v850

[Miles Bader]

"David S. Miller" <davem@redhat.com> writes:
>    I think in this case it's because I try to keep the v850 arch files
>    identical on 2.4.x and 2.5.x (as much as is possible), which sometimes
>    results in unused #defines on one or the other.
> 
> Please don't do that, 2.4.x and 2.5.x are different kernel.
> There will be differences, just accept them.

I will happily do so when requested.

> Therefore, please delete the flush_page_to_ram define on v850.

OK.

-Miles
-- 
`To alcohol!  The cause of, and solution to,
 all of life's problems' --Homer J. Simpson

[PATCH][v850] Add leading underline to new linker-script symbols on the v850

[Miles Bader]

This is needed to match the output of the C compiler.

diff -ruN -X../cludes linux-2.5.70/arch/v850/vmlinux.lds.S linux-2.5.70-v850-20030527/arch/v850/vmlinux.lds.S
--- linux-2.5.70/arch/v850/vmlinux.lds.S	2003-04-21 10:52:40.000000000 +0900
+++ linux-2.5.70-v850-20030527/arch/v850/vmlinux.lds.S	2003-05-27 16:09:43.000000000 +0900
@@ -105,9 +110,9 @@
 #define RAMK_INIT_CONTENTS_NO_END					      \
 		. = ALIGN (4096) ;					      \
 		__init_start = . ;					      \
-			_sinittext = .;					      \
+			__sinittext = .;				      \
 			*(.init.text)	/* 2.5 convention */		      \
-			_einittext = .;					      \
+			__einittext = .;				      \
 			*(.init.data)					      \
 			*(.text.init)	/* 2.4 convention */		      \
 			*(.data.init)					      \

[PATCH][v850] Add leading underline to new linker-script symbols on the v850

[Miles Bader]

This is needed to match the output of the C compiler.

diff -ruN -X../cludes linux-2.5.68-uc0/arch/v850/vmlinux.lds.S linux-2.5.68-uc0-v850-20030421/arch/v850/vmlinux.lds.S
--- linux-2.5.68-uc0/arch/v850/vmlinux.lds.S	2003-04-21 10:52:40.000000000 +0900
+++ linux-2.5.68-uc0-v850-20030421/arch/v850/vmlinux.lds.S	2003-04-21 11:39:51.000000000 +0900
@@ -105,9 +110,9 @@
 #define RAMK_INIT_CONTENTS_NO_END					      \
 		. = ALIGN (4096) ;					      \
 		__init_start = . ;					      \
-			_sinittext = .;					      \
+			__sinittext = .;				      \
 			*(.init.text)	/* 2.5 convention */		      \
-			_einittext = .;					      \
+			__einittext = .;				      \
 			*(.init.data)					      \
 			*(.text.init)	/* 2.4 convention */		      \
 			*(.data.init)					      \