* [COMPILATION ERROR] 2.5.69 drivers/bluetooth/hci_usb.c USB_ZERO_PACKET @ 2003-05-05 21:32 Grzegorz Jaskiewicz 2003-05-05 21:38 ` Grzegorz Jaskiewicz 0 siblings, 1 reply; 4+ messages in thread From: Grzegorz Jaskiewicz @ 2003-05-05 21:32 UTC (permalink / raw) To: lkml drivers/bluetooth/hci_usb.c : USB_ZERO_PACKET definition is missing if CONFIG_BT_SUB_ZERO_PACKET is not defined. #define USB_ZERO_PACKET 0 in this file helps, but i guess it is not the best and fully correct solution :) Cheers! -- Grzegorz Jaskiewicz <gj@pointblue.com.pl> K4 labs ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [COMPILATION ERROR] 2.5.69 drivers/bluetooth/hci_usb.c USB_ZERO_PACKET 2003-05-05 21:32 [COMPILATION ERROR] 2.5.69 drivers/bluetooth/hci_usb.c USB_ZERO_PACKET Grzegorz Jaskiewicz @ 2003-05-05 21:38 ` Grzegorz Jaskiewicz 2003-05-05 22:02 ` Francois Romieu 0 siblings, 1 reply; 4+ messages in thread From: Grzegorz Jaskiewicz @ 2003-05-05 21:38 UTC (permalink / raw) To: lkml On Mon, 2003-05-05 at 22:32, Grzegorz Jaskiewicz wrote: > drivers/bluetooth/hci_usb.c : > USB_ZERO_PACKET definition is missing if CONFIG_BT_SUB_ZERO_PACKET is > not defined. > > #define USB_ZERO_PACKET 0 > > in this file helps, but i guess it is not the best and fully correct > solution :) Oh, one small question. I am wondering, shouldn't this define be done in some USB header file ? If so, please give me some hints i will correct it my self :) -- Grzegorz Jaskiewicz <gj@pointblue.com.pl> K4 labs ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [COMPILATION ERROR] 2.5.69 drivers/bluetooth/hci_usb.c USB_ZERO_PACKET 2003-05-05 21:38 ` Grzegorz Jaskiewicz @ 2003-05-05 22:02 ` Francois Romieu 2003-05-05 22:09 ` Grzegorz Jaskiewicz 0 siblings, 1 reply; 4+ messages in thread From: Francois Romieu @ 2003-05-05 22:02 UTC (permalink / raw) To: Grzegorz Jaskiewicz; +Cc: Greg KH, lkml Grzegorz Jaskiewicz <gj@pointblue.com.pl> : [...] > If so, please give me some hints i will correct it my self :) If I remember M. KH's message of last week, it should be something like the following patch. Now I can't remember who he told it should be sent to :o) Typo: s/USB_ZERO_PACKET/URB_ZERO_PACKET/ drivers/bluetooth/hci_usb.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/bluetooth/hci_usb.c~typo-usb_zero_packet drivers/bluetooth/hci_usb.c --- linux-2.5.69-1.1042.1.187-to-1.1063/drivers/bluetooth/hci_usb.c~typo-usb_zero_packet Mon May 5 21:37:01 2003 +++ linux-2.5.69-1.1042.1.187-to-1.1063-fr/drivers/bluetooth/hci_usb.c Mon May 5 21:37:01 2003 @@ -64,8 +64,8 @@ #endif #ifndef CONFIG_BT_USB_ZERO_PACKET -#undef USB_ZERO_PACKET -#define USB_ZERO_PACKET 0 +#undef URB_ZERO_PACKET +#define URB_ZERO_PACKET 0 #endif static struct usb_driver hci_usb_driver; @@ -458,7 +458,7 @@ static inline int hci_usb_send_bulk(stru pipe = usb_sndbulkpipe(husb->udev, husb->bulk_out_ep->desc.bEndpointAddress); usb_fill_bulk_urb(urb, husb->udev, pipe, skb->data, skb->len, hci_usb_tx_complete, husb); - urb->transfer_flags = USB_ZERO_PACKET; + urb->transfer_flags = URB_ZERO_PACKET; BT_DBG("%s skb %p len %d", husb->hdev.name, skb, skb->len); _ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [COMPILATION ERROR] 2.5.69 drivers/bluetooth/hci_usb.c USB_ZERO_PACKET 2003-05-05 22:02 ` Francois Romieu @ 2003-05-05 22:09 ` Grzegorz Jaskiewicz 0 siblings, 0 replies; 4+ messages in thread From: Grzegorz Jaskiewicz @ 2003-05-05 22:09 UTC (permalink / raw) To: Francois Romieu; +Cc: Greg KH, lkml On Mon, 2003-05-05 at 23:02, Francois Romieu wrote: > Grzegorz Jaskiewicz <gj@pointblue.com.pl> : > [...] > > If so, please give me some hints i will correct it my self :) > > If I remember M. KH's message of last week, it should be something like the > following patch. Now I can't remember who he told it should be sent to :o) > > Typo: s/USB_ZERO_PACKET/URB_ZERO_PACKET/ indeed. I can see it now somewhere on a list :-] -- Grzegorz Jaskiewicz <gj@pointblue.com.pl> K4 labs ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-05-05 22:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2003-05-05 21:32 [COMPILATION ERROR] 2.5.69 drivers/bluetooth/hci_usb.c USB_ZERO_PACKET Grzegorz Jaskiewicz 2003-05-05 21:38 ` Grzegorz Jaskiewicz 2003-05-05 22:02 ` Francois Romieu 2003-05-05 22:09 ` Grzegorz Jaskiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).