2.5.69: Missing logo?

2.5.69: Missing logo?

[Russell King]

Hi,

I seem to have a penguin missing in action, somewhere between 2.5.68 and
2.5.69.  Has anyone else lost a penguin under similar circumstances?

$ grep LOGO linux-sa1100/.config
CONFIG_LOGO=y
# CONFIG_LOGO_LINUX_MONO is not set
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y

Other than the missing logo, the fb display looks as it did under 2.5.68.

assabet$ fbset

mode "320x240-60"
        geometry 320 240 320 240 16
        timings 171521 61 9 3 0 5 1
        accel false
        rgba 5/11,6/5,5/0,0/0
endmode

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: 2.5.69: Missing logo?

[Andy Pfiffer]

On Tue, 2003-05-06 at 10:07, Russell King wrote:
> Hi,
> 
> I seem to have a penguin missing in action, somewhere between 2.5.68 and
> 2.5.69.  Has anyone else lost a penguin under similar circumstances?

Tux is AWOL for me, too.

bk/linux-2.5.69+kexec2> grep LOGO .config
CONFIG_LOGO=y
CONFIG_LOGO_LINUX_MONO=y
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y
bk/linux-2.5.69+kexec2> grep CONFIG_FB .config | grep =y
CONFIG_FB=y
CONFIG_FB_VESA=y
CONFIG_FB_I810=y
CONFIG_FB_I810_GTF=y
bk/linux-2.5.69+kexec2> lspci | grep -i VGA
01:00.0 VGA compatible controller: Matrox Graphics, Inc. MGA G400 AGP
(rev 85)
bk/linux-2.5.69+kexec2>


> $ grep LOGO linux-sa1100/.config
> CONFIG_LOGO=y
> # CONFIG_LOGO_LINUX_MONO is not set
> CONFIG_LOGO_LINUX_VGA16=y
> CONFIG_LOGO_LINUX_CLUT224=y
> 
> Other than the missing logo, the fb display looks as it did under 2.5.68.

Re: 2.5.69: Missing logo?

[James Simmons]

It is the reversal of the changes of cfbimgblit.c. It brought back this 
bug :-(

> On Tue, 2003-05-06 at 10:07, Russell King wrote:
> > Hi,
> > 
> > I seem to have a penguin missing in action, somewhere between 2.5.68 and
> > 2.5.69.  Has anyone else lost a penguin under similar circumstances?
> 
> Tux is AWOL for me, too.
> 
> bk/linux-2.5.69+kexec2> grep LOGO .config
> CONFIG_LOGO=y
> CONFIG_LOGO_LINUX_MONO=y
> CONFIG_LOGO_LINUX_VGA16=y
> CONFIG_LOGO_LINUX_CLUT224=y
> bk/linux-2.5.69+kexec2> grep CONFIG_FB .config | grep =y
> CONFIG_FB=y
> CONFIG_FB_VESA=y
> CONFIG_FB_I810=y
> CONFIG_FB_I810_GTF=y
> bk/linux-2.5.69+kexec2> lspci | grep -i VGA
> 01:00.0 VGA compatible controller: Matrox Graphics, Inc. MGA G400 AGP
> (rev 85)
> bk/linux-2.5.69+kexec2>
> 
> 
> > $ grep LOGO linux-sa1100/.config
> > CONFIG_LOGO=y
> > # CONFIG_LOGO_LINUX_MONO is not set
> > CONFIG_LOGO_LINUX_VGA16=y
> > CONFIG_LOGO_LINUX_CLUT224=y
> > 
> > Other than the missing logo, the fb display looks as it did under 2.5.68.
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: 2.5.69: Missing logo?

[Balram Adlakha]

On Tue, May 06, 2003 at 06:07:07PM +0100, Russell King wrote:
> Hi,
> 
> I seem to have a penguin missing in action, somewhere between 2.5.68 and
> 2.5.69.  Has anyone else lost a penguin under similar circumstances?
> 
> $ grep LOGO linux-sa1100/.config
> CONFIG_LOGO=y
> # CONFIG_LOGO_LINUX_MONO is not set
> CONFIG_LOGO_LINUX_VGA16=y
> CONFIG_LOGO_LINUX_CLUT224=y
> 
> Other than the missing logo, the fb display looks as it did under 2.5.68.
> 
> assabet$ fbset
> 
> mode "320x240-60"
>         geometry 320 240 320 240 16
>         timings 171521 61 9 3 0 5 1
>         accel false
>         rgba 5/11,6/5,5/0,0/0
> endmode
> 
> -- 
> Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
>              http://www.arm.linux.org.uk/personal/aboutme.html
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


Me too. I think it happens with all configs. The empty space is there
for the penguin but I guess it gets eaten somewhere on the way.
-- 

Re: 2.5.69: Missing logo?

[James Simmons]

> Me too. I think it happens with all configs. The empty space is there
> for the penguin but I guess it gets eaten somewhere on the way.

Hm. Someone submitted a patch without testing it fully. This time it 
wasn't me :-/ Hey we are all human.
  

Re: 2.5.69: Missing logo?

[James Simmons]

> I seem to have a penguin missing in action, somewhere between 2.5.68 and
> 2.5.69.  Has anyone else lost a penguin under similar circumstances?
> 
> $ grep LOGO linux-sa1100/.config
> CONFIG_LOGO=y
> # CONFIG_LOGO_LINUX_MONO is not set
> CONFIG_LOGO_LINUX_VGA16=y
> CONFIG_LOGO_LINUX_CLUT224=y
> 
> Other than the missing logo, the fb display looks as it did under 2.5.68.
> 
> assabet$ fbset
> 
> mode "320x240-60"
>         geometry 320 240 320 240 16
>         timings 171521 61 9 3 0 5 1
>         accel false
>         rgba 5/11,6/5,5/0,0/0
> endmode

At the very bottom of cfbimgblt.c change 

} else if (image->depth == bpp)

to 

} else if (image->depth <= bpp)

and tell me if this works.

P.S
  Is it possible we could move the irq code for the acorn driver from 
fbcon.c to the acorn driver itself. 

Re: 2.5.69: Missing logo?

[Russell King]

On Tue, May 13, 2003 at 11:41:34PM +0100, James Simmons wrote:
> At the very bottom of cfbimgblt.c change 
> 
> } else if (image->depth == bpp)
> 
> to 
> 
> } else if (image->depth <= bpp)
> 
> and tell me if this works.

Will report later.

> P.S
>   Is it possible we could move the irq code for the acorn driver from 
> fbcon.c to the acorn driver itself. 

I don't see why not.  Do you have a patch for this?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: 2.5.69: Missing logo?

[Russell King]

On Tue, May 13, 2003 at 11:55:28PM +0100, Russell King wrote:
> On Tue, May 13, 2003 at 11:41:34PM +0100, James Simmons wrote:
> > At the very bottom of cfbimgblt.c change 
> > 
> > } else if (image->depth == bpp)
> > 
> > to 
> > 
> > } else if (image->depth <= bpp)
> > 
> > and tell me if this works.
> 
> Will report later.

This change makes it work.  Thanks.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html