Re: [patch] 2.5.69-bk7: wireless.c must include module.h

Re: [patch] 2.5.69-bk7: wireless.c must include module.h

[David S. Miller]

Applied, thanks.

[patch] 2.5.69-bk7: wireless.c must include module.h

[Adrian Bunk]

<--  snip  -->

...
  gcc -Wp,-MD,net/core/.wireless.o.d -D__KERNEL__ -Iinclude -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-pipe -mpreferred-stack-boundary=2 -march=k6 
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include    
-DKBUILD_BASENAME=wireless -DKBUILD_MODNAME=wireless -c -o 
net/core/wireless.o net/core/wireless.c
net/core/wireless.c:488: `THIS_MODULE' undeclared here (not in a function)
net/core/wireless.c:488: initializer element is not constant
net/core/wireless.c:488: (near initialization for `wireless_seq_fops.owner')
make[2]: *** [net/core/wireless.o] Error 1

<--  snip  -->


The fix is simple:

--- linux-2.5.69-bk7/net/core/wireless.c.old	2003-05-13 00:02:06.000000000 +0200
+++ linux-2.5.69-bk7/net/core/wireless.c	2003-05-13 00:02:42.000000000 +0200
@@ -60,6 +60,7 @@
 #include <linux/seq_file.h>
 #include <linux/init.h>			/* for __init */
 #include <linux/if_arp.h>		/* ARPHRD_ETHER */
+#include <linux/module.h>
 
 #include <linux/wireless.h>		/* Pretty obvious */
 #include <net/iw_handler.h>		/* New driver API */



cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [patch] 2.5.69-bk7: wireless.c must include module.h

[Jean Tourrilhes]

On Tue, May 13, 2003 at 12:05:12AM +0200, Adrian Bunk wrote:
> <--  snip  -->
> 
> ...
>   gcc -Wp,-MD,net/core/.wireless.o.d -D__KERNEL__ -Iinclude -Wall 
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
> -pipe -mpreferred-stack-boundary=2 -march=k6 
> -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include    
> -DKBUILD_BASENAME=wireless -DKBUILD_MODNAME=wireless -c -o 
> net/core/wireless.o net/core/wireless.c
> net/core/wireless.c:488: `THIS_MODULE' undeclared here (not in a function)
> net/core/wireless.c:488: initializer element is not constant
> net/core/wireless.c:488: (near initialization for `wireless_seq_fops.owner')
> make[2]: *** [net/core/wireless.o] Error 1
> 
> <--  snip  -->
> 
> 
> The fix is simple:
> 
> --- linux-2.5.69-bk7/net/core/wireless.c.old	2003-05-13 00:02:06.000000000 +0200
> +++ linux-2.5.69-bk7/net/core/wireless.c	2003-05-13 00:02:42.000000000 +0200
> @@ -60,6 +60,7 @@
>  #include <linux/seq_file.h>
>  #include <linux/init.h>			/* for __init */
>  #include <linux/if_arp.h>		/* ARPHRD_ETHER */
> +#include <linux/module.h>
>  
>  #include <linux/wireless.h>		/* Pretty obvious */
>  #include <net/iw_handler.h>		/* New driver API */
> 
> 
> 
> cu
> Adrian

	I still managed to beat you by a few minute ;-)
http://marc.theaimsgroup.com/?l=linux-kernel&m=105276406917601&w=2

	Thanks !

	Jean