link error building kernel with gcc-3.3

link error building kernel with gcc-3.3

[Alex Davis]

I got the following linking 2.4.21rc1:

net/network.o(.text+0xdcb7): In function `rtnetlink_rcv':
: undefined reference to `rtnetlink_rcv_skb'
make: *** [vmlinux] Error 1

Removing '__inline__' from the definition of rtnetlink_rcv_skb
in net/core/rtnetlink.c fixed the problem. 

Note: this error also occurs in 2.4.21rc2-ac2

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com

Re: link error building kernel with gcc-3.3

[James Morris]

On Wed, 14 May 2003, Alex Davis wrote:

> I got the following linking 2.4.21rc1:
> 
> net/network.o(.text+0xdcb7): In function `rtnetlink_rcv':
> : undefined reference to `rtnetlink_rcv_skb'
> make: *** [vmlinux] Error 1
> 
> Removing '__inline__' from the definition of rtnetlink_rcv_skb
> in net/core/rtnetlink.c fixed the problem. 
> 
> Note: this error also occurs in 2.4.21rc2-ac2

I wonder, does this mean that the compiler failed to inline the function?

Removing __inline__ is not the correct solution.


- James
-- 
James Morris
<jmorris@intercode.com.au>

Re: link error building kernel with gcc-3.3

[David S. Miller]

   From: James Morris <jmorris@intercode.com.au>
   Date: Thu, 15 May 2003 15:38:15 +1000 (EST)
   
   I wonder, does this mean that the compiler failed to inline the function?
   
   Removing __inline__ is not the correct solution.
   
I already posted what the correct fix is :-)  And this is already
pushed to 2.5.x

Inlining is not guarenteed, and:

extern inline ... foo(...)

means "inline if you can, I have a compiled-in implementation
in some object somewhere" whereas:

static inline ... foo(...)

means "inline if you can, if there is a case where you cannot
emit this as a function into the current module"

Re: link error building kernel with gcc-3.3

[Alex Davis]

Can you push it to 2.4.x as well?

-Alex

--- "David S. Miller" <davem@redhat.com> wrote:
>    From: James Morris <jmorris@intercode.com.au>
>    Date: Thu, 15 May 2003 15:38:15 +1000 (EST)
>    
>    I wonder, does this mean that the compiler failed to inline the function?
>    
>    Removing __inline__ is not the correct solution.
>    
> I already posted what the correct fix is :-)  And this is already
> pushed to 2.5.x

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com

Re: link error building kernel with gcc-3.3

[David S. Miller]

   From: Alex Davis <alex14641@yahoo.com>
   Date: Thu, 15 May 2003 07:56:33 -0700 (PDT)

   Can you push it to 2.4.x as well?
   
I did, but it won't go in until 2.4.22-pre1, this isn't
critical at all.