From: Bharata B Rao <bharata@in.ibm.com>
To: Jens Axboe <axboe@suse.de>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
Adrian Bunk <bunk@fs.tum.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Suparna Bhattacharya <suparna@in.ibm.com>
Subject: Re: 2.5.69-mjb1: undefined reference to `blk_queue_empty'
Date: Thu, 15 May 2003 14:46:43 +0530 [thread overview]
Message-ID: <20030515144643.R31823@in.ibm.com> (raw)
In-Reply-To: <20030515072937.GT15261@suse.de>; from axboe@suse.de on Thu, May 15, 2003 at 09:29:37AM +0200
On Thu, May 15, 2003 at 09:29:37AM +0200, Jens Axboe wrote:
> >
> > --- 2569+mjb1/drivers/dump/dump_blockdev.c.orig Wed May 14 13:23:36 2003
> > +++ 2569+mjb1/drivers/dump/dump_blockdev.c Thu May 15 09:26:12 2003
> > @@ -258,10 +258,19 @@
> > dump_block_silence(struct dump_dev *dev)
> > {
> > struct dump_blockdev *dump_bdev = DUMP_BDEV(dev);
> > + struct request_queue *q = bdev_get_queue(dump_bdev->bdev);
> > + int ret;
> > +
> > + /* If we can't get request queue lock, refuse to take the dump */
> > + if (!spin_trylock(q->queue_lock))
> > + return -EBUSY;
> > +
> > + ret = elv_queue_empty(q);
> > + spin_unlock(q->queue_lock);
> >
> > /* For now we assume we have the device to ourselves */
> > /* Just a quick sanity check */
> > - if (!blk_queue_empty(bdev_get_queue(dump_bdev->bdev))) {
> > + if (!ret) {
> > /* i/o in flight - safer to quit */
> > return -EBUSY;
> > }
>
> Are interrupts already disabled at this point? If yes, then it looks
> fine.
>
Yes, interrupts are disabled at this point.
Martin, Could you please take this in, while I push this change to lkcd cvs.
Regards,
Bharata.
next prev parent reply other threads:[~2003-05-15 9:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-11 3:44 2.5.69-mjb1 Martin J. Bligh
2003-05-11 13:33 ` 2.5.69-mjb1 Zwane Mwaikambo
2003-05-11 13:12 ` 2.5.69-mjb1 Martin J. Bligh
2003-05-12 13:29 ` 2.5.69-mjb1 William Lee Irwin III
2003-05-12 12:40 ` 2.5.69-mjb1 Martin J. Bligh
2003-05-12 15:03 ` 2.5.69-mjb1 William Lee Irwin III
2003-05-12 13:07 ` 2.5.69-mjb1 Martin J. Bligh
2003-05-12 15:34 ` 2.5.69-mjb1 Dave Hansen
2003-05-12 13:43 ` 2.5.69-mjb1 Martin J. Bligh
2003-05-12 15:11 ` 2.5.69-mjb1 Dave Hansen
2003-05-12 15:05 ` 2.5.69-mjb1 Dave Hansen
2003-05-13 1:23 ` [Lse-tech] 2.5.69-mjb1 William Lee Irwin III
2003-05-13 3:41 ` Martin J. Bligh
2003-05-13 6:27 ` William Lee Irwin III
2003-05-13 6:42 ` Andi Kleen
2003-05-12 20:51 ` 2.5.69-mjb1: undefined reference to `blk_queue_empty' Adrian Bunk
2003-05-13 3:51 ` Martin J. Bligh
2003-05-13 7:18 ` Bharata B Rao
2003-05-13 13:58 ` Martin J. Bligh
2003-05-13 18:11 ` Jens Axboe
2003-05-14 8:08 ` Bharata B Rao
2003-05-14 8:32 ` Jens Axboe
2003-05-15 4:07 ` Bharata B Rao
2003-05-15 7:29 ` Jens Axboe
2003-05-15 9:16 ` Bharata B Rao [this message]
2003-05-15 12:52 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030515144643.R31823@in.ibm.com \
--to=bharata@in.ibm.com \
--cc=axboe@suse.de \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).