From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: William Lee Irwin III <wli@holomorphy.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
lse-tech <lse-tech@lists.sourceforge.net>
Subject: Re: 2.5.69-mjb1
Date: Mon, 12 May 2003 06:43:11 -0700 [thread overview]
Message-ID: <24330000.1052746990@[10.10.2.4]> (raw)
In-Reply-To: <3EBFBEF5.6050600@us.ibm.com>
--On Monday, May 12, 2003 08:34:13 -0700 Dave Hansen <haveblue@us.ibm.com> wrote:
> Martin J. Bligh wrote:
>> OK, so maybe I'm still asleep, but I don't see why the hardcoded
>> magic constant (grrr) is 4096 in mainline, when the stacksize is 8K.
>> Presumably the 1019*4 makes up the rest of it? Maybe the real question
>> is what the hell was whoever wrote that in the first place smoking ? ;-)
>> Why on earth would you skip halfway through the stack with one stupid
>> magic constant, and then the rest of the way with another?
>
> You can go ask the author:
>
> http://linus.bkbits.net:8080/linux-2.5/diffs/include/asm-i386/processor.h@1.12?nav=index.html|src/|src/include|src/include/asm-i386|hist/include/asm-i386/processor.h
-#define KSTK_EIP(tsk) (((unsigned long *)(4096+(unsigned long)(tsk)))[1019])
-#define KSTK_ESP(tsk) (((unsigned long *)(4096+(unsigned long)(tsk)))[1022])
...
+#define KSTK_EIP(tsk) (((unsigned long *)(4096+(unsigned long)(tsk)->thread_info))[1019])
+#define KSTK_ESP(tsk) (((unsigned long *)(4096+(unsigned long)(tsk)->thread_info))[1022])
Nope, not his fault, really.
M.
next prev parent reply other threads:[~2003-05-12 15:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-11 3:44 2.5.69-mjb1 Martin J. Bligh
2003-05-11 13:33 ` 2.5.69-mjb1 Zwane Mwaikambo
2003-05-11 13:12 ` 2.5.69-mjb1 Martin J. Bligh
2003-05-12 13:29 ` 2.5.69-mjb1 William Lee Irwin III
2003-05-12 12:40 ` 2.5.69-mjb1 Martin J. Bligh
2003-05-12 15:03 ` 2.5.69-mjb1 William Lee Irwin III
2003-05-12 13:07 ` 2.5.69-mjb1 Martin J. Bligh
2003-05-12 15:34 ` 2.5.69-mjb1 Dave Hansen
2003-05-12 13:43 ` Martin J. Bligh [this message]
2003-05-12 15:11 ` 2.5.69-mjb1 Dave Hansen
2003-05-12 15:05 ` 2.5.69-mjb1 Dave Hansen
2003-05-13 1:23 ` [Lse-tech] 2.5.69-mjb1 William Lee Irwin III
2003-05-13 3:41 ` Martin J. Bligh
2003-05-13 6:27 ` William Lee Irwin III
2003-05-13 6:42 ` Andi Kleen
2003-05-12 20:51 ` 2.5.69-mjb1: undefined reference to `blk_queue_empty' Adrian Bunk
2003-05-13 3:51 ` Martin J. Bligh
2003-05-13 7:18 ` Bharata B Rao
2003-05-13 13:58 ` Martin J. Bligh
2003-05-13 18:11 ` Jens Axboe
2003-05-14 8:08 ` Bharata B Rao
2003-05-14 8:32 ` Jens Axboe
2003-05-15 4:07 ` Bharata B Rao
2003-05-15 7:29 ` Jens Axboe
2003-05-15 9:16 ` Bharata B Rao
2003-05-15 12:52 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='24330000.1052746990@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).