linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* 2.5.69-mm5: reverting i8259-shutdown.patch
@ 2003-05-15  2:23 Felipe Alfaro Solana
  2003-05-15  2:33 ` Andrew Morton
  0 siblings, 1 reply; 17+ messages in thread
From: Felipe Alfaro Solana @ 2003-05-15  2:23 UTC (permalink / raw)
  To: akpm; +Cc: LKML

Hi again, Andrew,

Besides the "make_KOBJ_NAME-match_BUS_ID_SIZE.patch" causing "pccard"
oopses, I've also found that, with 2.5.69-mm5 compiled with ACPI
support, my laptop is unable to power off. The kernel invokes
"acpi_power_off" and stays there forever.

I've found that reverting the "i8259-shutdown.patch" fixes the problem
and my laptop is able to shutdown properly (init 0) when using ACPI.

A hardware bug? A kernel bug?

Thanks!



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  2:23 2.5.69-mm5: reverting i8259-shutdown.patch Felipe Alfaro Solana
@ 2003-05-15  2:33 ` Andrew Morton
  2003-05-15  2:39   ` Patrick Mochel
  0 siblings, 1 reply; 17+ messages in thread
From: Andrew Morton @ 2003-05-15  2:33 UTC (permalink / raw)
  To: Felipe Alfaro Solana; +Cc: linux-kernel

Felipe Alfaro Solana <felipe_alfaro@linuxmail.org> wrote:
>
> Hi again, Andrew,
> 
> Besides the "make_KOBJ_NAME-match_BUS_ID_SIZE.patch" causing "pccard"
> oopses, I've also found that, with 2.5.69-mm5 compiled with ACPI
> support, my laptop is unable to power off. The kernel invokes
> "acpi_power_off" and stays there forever.
> 
> I've found that reverting the "i8259-shutdown.patch" fixes the problem
> and my laptop is able to shutdown properly (init 0) when using ACPI.
> 
> A hardware bug? A kernel bug?

And thanks again, again.

That's the below patch.  It looks pretty innocuous.  I'd be assuming that
there's something in the shutdown sequence which needs 8259 functionality
after the thing has been turned off.

This could well depend upon .config contents and linkage order.

Eric, maybe we need to turn it off by hand at the right time rather than
relying on driver model shutdown ordering?


 arch/i386/kernel/i8259.c |   11 +++++++++++
 1 files changed, 11 insertions(+)

diff -puN arch/i386/kernel/i8259.c~i8259-shutdown arch/i386/kernel/i8259.c
--- 25/arch/i386/kernel/i8259.c~i8259-shutdown	2003-05-11 18:48:58.000000000 -0700
+++ 25-akpm/arch/i386/kernel/i8259.c	2003-05-11 18:48:58.000000000 -0700
@@ -245,10 +245,21 @@ static int i8259A_resume(struct device *
 	return 0;
 }
 
+static void i8259A_shutdown(struct device *dev)
+{   
+	/* Put the i8259A into a quiescent state that
+	 * the kernel initialization code can get it
+	 * out of.
+	 */
+	outb(0xff, 0x21);	/* mask all of 8259A-1 */
+	outb(0xff, 0xA1);	/* mask all of 8259A-1 */
+}
+
 static struct device_driver i8259A_driver = {
 	.name		= "pic",
 	.bus		= &system_bus_type,
 	.resume		= i8259A_resume,
+	.shutdown	= i8259A_shutdown,
 };
 
 static struct sys_device device_i8259A = {

_


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  2:33 ` Andrew Morton
@ 2003-05-15  2:39   ` Patrick Mochel
  2003-05-15  2:45     ` Zwane Mwaikambo
                       ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Patrick Mochel @ 2003-05-15  2:39 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel


On Wed, 14 May 2003, Andrew Morton wrote:

> Felipe Alfaro Solana <felipe_alfaro@linuxmail.org> wrote:
> >
> > Hi again, Andrew,
> > 
> > Besides the "make_KOBJ_NAME-match_BUS_ID_SIZE.patch" causing "pccard"
> > oopses, I've also found that, with 2.5.69-mm5 compiled with ACPI
> > support, my laptop is unable to power off. The kernel invokes
> > "acpi_power_off" and stays there forever.
> > 
> > I've found that reverting the "i8259-shutdown.patch" fixes the problem
> > and my laptop is able to shutdown properly (init 0) when using ACPI.
> > 
> > A hardware bug? A kernel bug?
> 
> And thanks again, again.
> 
> That's the below patch.  It looks pretty innocuous.  I'd be assuming that
> there's something in the shutdown sequence which needs 8259 functionality
> after the thing has been turned off.
> 
> This could well depend upon .config contents and linkage order.
> 
> Eric, maybe we need to turn it off by hand at the right time rather than
> relying on driver model shutdown ordering?

Interesting. This is yet more proof that system-level devices cannot be
treated as common, everyday devices. Sure, it's nice to see them show up
in sysfs with little overhead, and very nice not to have to work about
them during shutdown or power transitions. But there are just too many
special cases (like getting the ordering right ;) that you have to worry
about.

So, what do we do with them? 


	-pat


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  2:39   ` Patrick Mochel
@ 2003-05-15  2:45     ` Zwane Mwaikambo
  2003-05-15  3:00       ` Patrick Mochel
  2003-05-15  6:14     ` Andrew Morton
  2003-05-16 19:41     ` Pavel Machek
  2 siblings, 1 reply; 17+ messages in thread
From: Zwane Mwaikambo @ 2003-05-15  2:45 UTC (permalink / raw)
  To: Patrick Mochel; +Cc: Andrew Morton, linux-kernel

On Wed, 14 May 2003, Patrick Mochel wrote:

> Interesting. This is yet more proof that system-level devices cannot be
> treated as common, everyday devices. Sure, it's nice to see them show up
> in sysfs with little overhead, and very nice not to have to work about
> them during shutdown or power transitions. But there are just too many
> special cases (like getting the ordering right ;) that you have to worry
> about.
> 
> So, what do we do with them? 

Does the PIC shutdown callback get called _just_ before acpi_power_off?

	Zwane
-- 
function.linuxpower.ca

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  2:45     ` Zwane Mwaikambo
@ 2003-05-15  3:00       ` Patrick Mochel
  2003-05-15 12:02         ` Felipe Alfaro Solana
  0 siblings, 1 reply; 17+ messages in thread
From: Patrick Mochel @ 2003-05-15  3:00 UTC (permalink / raw)
  To: Zwane Mwaikambo; +Cc: Andrew Morton, linux-kernel


On Wed, 14 May 2003, Zwane Mwaikambo wrote:

> On Wed, 14 May 2003, Patrick Mochel wrote:
> 
> > Interesting. This is yet more proof that system-level devices cannot be
> > treated as common, everyday devices. Sure, it's nice to see them show up
> > in sysfs with little overhead, and very nice not to have to work about
> > them during shutdown or power transitions. But there are just too many
> > special cases (like getting the ordering right ;) that you have to worry
> > about.
> > 
> > So, what do we do with them? 
> 
> Does the PIC shutdown callback get called _just_ before acpi_power_off?

It may or may not be. It depends on which order it gets registered in, 
which is arbitrary (*). One can enable DEBUG in drivers/base/power.c and 
crank up the console log level to see the order that devices get shutdown 
in on their system. 


	-pat

(*) - Ok, we can control the registration via link order, but that's 
something we'll be tweaking until our dying days in absence of a good 
solution. 


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  6:14     ` Andrew Morton
@ 2003-05-15  6:13       ` Zwane Mwaikambo
  2003-05-15  7:56         ` Zwane Mwaikambo
  2003-05-15 12:07       ` Felipe Alfaro Solana
  1 sibling, 1 reply; 17+ messages in thread
From: Zwane Mwaikambo @ 2003-05-15  6:13 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Patrick Mochel, linux-kernel, Felipe Alfaro Solana

On Wed, 14 May 2003, Andrew Morton wrote:

> I'd say that as long as the shutdown routines are executed in reverse
> order of startup, then the core driver stuff has fulfilled its
> obligations.
> 
> In this case we need to understand why the lockup is happening - what
> code is requiring 8259 services after the thing has been turned off?
> Could be that the bug lies there.

The registration is somewhat unfair here, it depends on device_initcall 
and we initialise the 8259 in init_IRQ.

	Zwane
-- 
function.linuxpower.ca

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  2:39   ` Patrick Mochel
  2003-05-15  2:45     ` Zwane Mwaikambo
@ 2003-05-15  6:14     ` Andrew Morton
  2003-05-15  6:13       ` Zwane Mwaikambo
  2003-05-15 12:07       ` Felipe Alfaro Solana
  2003-05-16 19:41     ` Pavel Machek
  2 siblings, 2 replies; 17+ messages in thread
From: Andrew Morton @ 2003-05-15  6:14 UTC (permalink / raw)
  To: Patrick Mochel; +Cc: linux-kernel, Felipe Alfaro Solana

Patrick Mochel <mochel@osdl.org> wrote:
>
> > Eric, maybe we need to turn it off by hand at the right time rather than
>  > relying on driver model shutdown ordering?
> 
>  Interesting. This is yet more proof that system-level devices cannot be
>  treated as common, everyday devices. Sure, it's nice to see them show up
>  in sysfs with little overhead, and very nice not to have to work about
>  them during shutdown or power transitions. But there are just too many
>  special cases (like getting the ordering right ;) that you have to worry
>  about.
> 
>  So, what do we do with them? 

I'd say that as long as the shutdown routines are executed in reverse
order of startup, then the core driver stuff has fulfilled its
obligations.

In this case we need to understand why the lockup is happening - what
code is requiring 8259 services after the thing has been turned off?
Could be that the bug lies there.

Felipe, please send your .config.   (again - in fact you may as well do
cp .config ~/.signature)




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  6:13       ` Zwane Mwaikambo
@ 2003-05-15  7:56         ` Zwane Mwaikambo
  2003-05-15 17:34           ` Patrick Mochel
  0 siblings, 1 reply; 17+ messages in thread
From: Zwane Mwaikambo @ 2003-05-15  7:56 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Patrick Mochel, linux-kernel, Felipe Alfaro Solana

On Thu, 15 May 2003, Zwane Mwaikambo wrote:

> On Wed, 14 May 2003, Andrew Morton wrote:
> 
> > I'd say that as long as the shutdown routines are executed in reverse
> > order of startup, then the core driver stuff has fulfilled its
> > obligations.
> > 
> > In this case we need to understand why the lockup is happening - what
> > code is requiring 8259 services after the thing has been turned off?
> > Could be that the bug lies there.
> 
> The registration is somewhat unfair here, it depends on device_initcall 
> and we initialise the 8259 in init_IRQ.

Pat what do you say to some late shutdown callbacks? I'll drop you a 
patch sometime tommorrow.

	Zwane
-- 
function.linuxpower.ca

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  3:00       ` Patrick Mochel
@ 2003-05-15 12:02         ` Felipe Alfaro Solana
  2003-05-15 17:35           ` Patrick Mochel
  0 siblings, 1 reply; 17+ messages in thread
From: Felipe Alfaro Solana @ 2003-05-15 12:02 UTC (permalink / raw)
  To: Patrick Mochel; +Cc: Zwane Mwaikambo, Andrew Morton, LKML

On Thu, 2003-05-15 at 05:00, Patrick Mochel wrote:
> On Wed, 14 May 2003, Zwane Mwaikambo wrote:
> 
> > On Wed, 14 May 2003, Patrick Mochel wrote:
> > 
> > > Interesting. This is yet more proof that system-level devices cannot be
> > > treated as common, everyday devices. Sure, it's nice to see them show up
> > > in sysfs with little overhead, and very nice not to have to work about
> > > them during shutdown or power transitions. But there are just too many
> > > special cases (like getting the ordering right ;) that you have to worry
> > > about.
> > > 
> > > So, what do we do with them? 
> > 
> > Does the PIC shutdown callback get called _just_ before acpi_power_off?
> 
> It may or may not be. It depends on which order it gets registered in, 
> which is arbitrary (*). One can enable DEBUG in drivers/base/power.c and 
> crank up the console log level to see the order that devices get shutdown 
> in on their system. 

OK, I've changed "#undef DEBUG" to "#define DEBUG" in
drivers/base/power.c, but during shutdown, I can see no extra debug
messages. What am I doing wrong?


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  6:14     ` Andrew Morton
  2003-05-15  6:13       ` Zwane Mwaikambo
@ 2003-05-15 12:07       ` Felipe Alfaro Solana
  2003-05-17 19:25         ` Zwane Mwaikambo
  1 sibling, 1 reply; 17+ messages in thread
From: Felipe Alfaro Solana @ 2003-05-15 12:07 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Patrick Mochel, LKML

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

On Thu, 2003-05-15 at 08:14, Andrew Morton wrote:
> Patrick Mochel <mochel@osdl.org> wrote:
> >
> > > Eric, maybe we need to turn it off by hand at the right time rather than
> >  > relying on driver model shutdown ordering?
> > 
> >  Interesting. This is yet more proof that system-level devices cannot be
> >  treated as common, everyday devices. Sure, it's nice to see them show up
> >  in sysfs with little overhead, and very nice not to have to work about
> >  them during shutdown or power transitions. But there are just too many
> >  special cases (like getting the ordering right ;) that you have to worry
> >  about.
> > 
> >  So, what do we do with them? 
> 
> I'd say that as long as the shutdown routines are executed in reverse
> order of startup, then the core driver stuff has fulfilled its
> obligations.
> 
> In this case we need to understand why the lockup is happening - what
> code is requiring 8259 services after the thing has been turned off?
> Could be that the bug lies there.
> 
> Felipe, please send your .config.   (again - in fact you may as well do
> cp .config ~/.signature)

Config attached...
Don't understand what do you mean with "cp .config ~/.signature" :-?

[-- Attachment #2: config-2.5.69-mm5 --]
[-- Type: text/plain, Size: 19193 bytes --]

#
# Automatically generated make config: don't edit
#
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_UID16=y
CONFIG_GENERIC_ISA_DMA=y

#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y

#
# General setup
#
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
# CONFIG_BSD_PROCESS_ACCT is not set
CONFIG_SYSCTL=y
CONFIG_LOG_BUF_SHIFT=14
CONFIG_FUTEX=y

#
# Loadable module support
#
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
CONFIG_MODULE_FORCE_UNLOAD=y
CONFIG_OBSOLETE_MODPARM=y
# CONFIG_MODVERSIONS is not set
CONFIG_KMOD=y

#
# Processor type and features
#
CONFIG_X86_PC=y
# CONFIG_X86_VOYAGER is not set
# CONFIG_X86_NUMAQ is not set
# CONFIG_X86_SUMMIT is not set
# CONFIG_X86_BIGSMP is not set
# CONFIG_X86_VISWS is not set
# CONFIG_X86_GENERICARCH is not set
# CONFIG_M386 is not set
# CONFIG_M486 is not set
# CONFIG_M586 is not set
# CONFIG_M586TSC is not set
# CONFIG_M586MMX is not set
# CONFIG_M686 is not set
# CONFIG_MPENTIUMII is not set
CONFIG_MPENTIUMIII=y
# CONFIG_MPENTIUM4 is not set
# CONFIG_MK6 is not set
# CONFIG_MK7 is not set
# CONFIG_MK8 is not set
# CONFIG_MELAN is not set
# CONFIG_MCRUSOE is not set
# CONFIG_MWINCHIPC6 is not set
# CONFIG_MWINCHIP2 is not set
# CONFIG_MWINCHIP3D is not set
# CONFIG_MCYRIXIII is not set
# CONFIG_MVIAC3_2 is not set
# CONFIG_X86_GENERIC is not set
CONFIG_X86_CMPXCHG=y
CONFIG_X86_XADD=y
CONFIG_X86_L1_CACHE_SHIFT=5
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_X86_WP_WORKS_OK=y
CONFIG_X86_INVLPG=y
CONFIG_X86_BSWAP=y
CONFIG_X86_POPAD_OK=y
CONFIG_X86_GOOD_APIC=y
CONFIG_X86_INTEL_USERCOPY=y
CONFIG_X86_USE_PPRO_CHECKSUM=y
# CONFIG_HUGETLB_PAGE is not set
# CONFIG_SMP is not set
CONFIG_PREEMPT=y
# CONFIG_X86_UP_APIC is not set
CONFIG_X86_TSC=y
# CONFIG_X86_MCE is not set
# CONFIG_TOSHIBA is not set
# CONFIG_I8K is not set
# CONFIG_MICROCODE is not set
# CONFIG_X86_MSR is not set
# CONFIG_X86_CPUID is not set
# CONFIG_EDD is not set
CONFIG_NOHIGHMEM=y
# CONFIG_HIGHMEM4G is not set
# CONFIG_HIGHMEM64G is not set
# CONFIG_025GB is not set
# CONFIG_05GB is not set
CONFIG_1GB=y
# CONFIG_2GB is not set
# CONFIG_3GB is not set
# CONFIG_MATH_EMULATION is not set
CONFIG_MTRR=y
CONFIG_HAVE_DEC_LOCK=y
# CONFIG_KEXEC is not set

#
# Power management options (ACPI, APM)
#
CONFIG_PM=y
# CONFIG_SOFTWARE_SUSPEND is not set

#
# ACPI Support
#
CONFIG_ACPI=y
CONFIG_ACPI_BOOT=y
CONFIG_ACPI_AC=y
CONFIG_ACPI_BATTERY=y
CONFIG_ACPI_BUTTON=y
CONFIG_ACPI_FAN=y
CONFIG_ACPI_PROCESSOR=y
CONFIG_ACPI_THERMAL=y
# CONFIG_ACPI_TOSHIBA is not set
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_BUS=y
CONFIG_ACPI_INTERPRETER=y
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y
# CONFIG_APM is not set

#
# CPU Frequency scaling
#
# CONFIG_CPU_FREQ is not set

#
# Bus options (PCI, PCMCIA, EISA, MCA, ISA)
#
CONFIG_PCI=y
# CONFIG_PCI_GOBIOS is not set
# CONFIG_PCI_GODIRECT is not set
CONFIG_PCI_GOANY=y
CONFIG_PCI_BIOS=y
CONFIG_PCI_DIRECT=y
# CONFIG_PCI_LEGACY_PROC is not set
CONFIG_PCI_NAMES=y
# CONFIG_ISA is not set
# CONFIG_MCA is not set
# CONFIG_SCx200 is not set
CONFIG_HOTPLUG=y

#
# PCMCIA/CardBus support
#
CONFIG_PCMCIA=y
CONFIG_CARDBUS=y
# CONFIG_I82092 is not set
# CONFIG_I82365 is not set
# CONFIG_TCIC is not set

#
# PCI Hotplug Support
#
# CONFIG_HOTPLUG_PCI is not set

#
# Executable file formats
#
CONFIG_KCORE_ELF=y
# CONFIG_KCORE_AOUT is not set
# CONFIG_BINFMT_AOUT is not set
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_MISC=m

#
# Memory Technology Devices (MTD)
#
# CONFIG_MTD is not set

#
# Parallel port support
#
# CONFIG_PARPORT is not set

#
# Plug and Play support
#
# CONFIG_PNP is not set

#
# Block devices
#
CONFIG_BLK_DEV_FD=m
# CONFIG_BLK_CPQ_DA is not set
# CONFIG_BLK_CPQ_CISS_DA is not set
# CONFIG_BLK_DEV_DAC960 is not set
# CONFIG_BLK_DEV_UMEM is not set
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_NBD=m
# CONFIG_BLK_DEV_RAM is not set
# CONFIG_BLK_DEV_INITRD is not set
# CONFIG_LBD is not set

#
# ATA/ATAPI/MFM/RLL device support
#
CONFIG_IDE=y

#
# IDE, ATA and ATAPI Block devices
#
CONFIG_BLK_DEV_IDE=y

#
# Please see Documentation/ide.txt for help/info on IDE drives
#
# CONFIG_BLK_DEV_HD_IDE is not set
# CONFIG_BLK_DEV_HD is not set
CONFIG_BLK_DEV_IDEDISK=y
CONFIG_IDEDISK_MULTI_MODE=y
# CONFIG_IDEDISK_STROKE is not set
# CONFIG_BLK_DEV_IDECS is not set
CONFIG_BLK_DEV_IDECD=y
# CONFIG_BLK_DEV_IDEFLOPPY is not set
# CONFIG_IDE_TASK_IOCTL is not set

#
# IDE chipset support/bugfixes
#
# CONFIG_BLK_DEV_CMD640 is not set
CONFIG_BLK_DEV_IDEPCI=y
# CONFIG_BLK_DEV_GENERIC is not set
# CONFIG_IDEPCI_SHARE_IRQ is not set
CONFIG_BLK_DEV_IDEDMA_PCI=y
# CONFIG_BLK_DEV_IDE_TCQ is not set
# CONFIG_BLK_DEV_OFFBOARD is not set
# CONFIG_BLK_DEV_IDEDMA_FORCED is not set
CONFIG_IDEDMA_PCI_AUTO=y
# CONFIG_IDEDMA_ONLYDISK is not set
CONFIG_BLK_DEV_IDEDMA=y
# CONFIG_IDEDMA_PCI_WIP is not set
CONFIG_BLK_DEV_ADMA=y
# CONFIG_BLK_DEV_AEC62XX is not set
# CONFIG_BLK_DEV_ALI15X3 is not set
# CONFIG_BLK_DEV_AMD74XX is not set
# CONFIG_BLK_DEV_CMD64X is not set
# CONFIG_BLK_DEV_TRIFLEX is not set
# CONFIG_BLK_DEV_CY82C693 is not set
# CONFIG_BLK_DEV_CS5520 is not set
# CONFIG_BLK_DEV_HPT34X is not set
# CONFIG_BLK_DEV_HPT366 is not set
# CONFIG_BLK_DEV_SC1200 is not set
CONFIG_BLK_DEV_PIIX=y
# CONFIG_BLK_DEV_NS87415 is not set
# CONFIG_BLK_DEV_OPTI621 is not set
# CONFIG_BLK_DEV_PDC202XX_OLD is not set
# CONFIG_BLK_DEV_PDC202XX_NEW is not set
# CONFIG_BLK_DEV_RZ1000 is not set
# CONFIG_BLK_DEV_SVWKS is not set
# CONFIG_BLK_DEV_SIIMAGE is not set
# CONFIG_BLK_DEV_SIS5513 is not set
# CONFIG_BLK_DEV_SLC90E66 is not set
# CONFIG_BLK_DEV_TRM290 is not set
# CONFIG_BLK_DEV_VIA82CXXX is not set
CONFIG_IDEDMA_AUTO=y
# CONFIG_IDEDMA_IVB is not set
CONFIG_BLK_DEV_IDE_MODES=y

#
# SCSI device support
#
# CONFIG_SCSI is not set

#
# Multi-device support (RAID and LVM)
#
# CONFIG_MD is not set

#
# Fusion MPT device support
#

#
# IEEE 1394 (FireWire) support (EXPERIMENTAL)
#
# CONFIG_IEEE1394 is not set

#
# I2O device support
#
# CONFIG_I2O is not set

#
# Networking support
#
CONFIG_NET=y

#
# Networking options
#
CONFIG_PACKET=y
CONFIG_PACKET_MMAP=y
# CONFIG_NETLINK_DEV is not set
CONFIG_NETFILTER=y
# CONFIG_NETFILTER_DEBUG is not set
CONFIG_UNIX=y
# CONFIG_NET_KEY is not set
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
# CONFIG_IP_ADVANCED_ROUTER is not set
# CONFIG_IP_PNP is not set
# CONFIG_NET_IPIP is not set
# CONFIG_NET_IPGRE is not set
# CONFIG_IP_MROUTE is not set
# CONFIG_ARPD is not set
# CONFIG_INET_ECN is not set
# CONFIG_SYN_COOKIES is not set
# CONFIG_INET_AH is not set
# CONFIG_INET_ESP is not set
# CONFIG_INET_IPCOMP is not set

#
# IP: Netfilter Configuration
#
CONFIG_IP_NF_CONNTRACK=m
CONFIG_IP_NF_FTP=m
CONFIG_IP_NF_IRC=m
CONFIG_IP_NF_TFTP=m
CONFIG_IP_NF_AMANDA=m
# CONFIG_IP_NF_QUEUE is not set
CONFIG_IP_NF_IPTABLES=m
CONFIG_IP_NF_MATCH_LIMIT=m
CONFIG_IP_NF_MATCH_MAC=m
CONFIG_IP_NF_MATCH_PKTTYPE=m
CONFIG_IP_NF_MATCH_MARK=m
CONFIG_IP_NF_MATCH_MULTIPORT=m
CONFIG_IP_NF_MATCH_TOS=m
CONFIG_IP_NF_MATCH_ECN=m
CONFIG_IP_NF_MATCH_DSCP=m
# CONFIG_IP_NF_MATCH_AH_ESP is not set
CONFIG_IP_NF_MATCH_LENGTH=m
CONFIG_IP_NF_MATCH_TTL=m
CONFIG_IP_NF_MATCH_TCPMSS=m
CONFIG_IP_NF_MATCH_HELPER=m
CONFIG_IP_NF_MATCH_STATE=m
CONFIG_IP_NF_MATCH_CONNTRACK=m
CONFIG_IP_NF_MATCH_UNCLEAN=m
CONFIG_IP_NF_MATCH_OWNER=m
CONFIG_IP_NF_FILTER=m
# CONFIG_IP_NF_TARGET_REJECT is not set
# CONFIG_IP_NF_TARGET_MIRROR is not set
# CONFIG_IP_NF_NAT is not set
# CONFIG_IP_NF_MANGLE is not set
# CONFIG_IP_NF_TARGET_LOG is not set
# CONFIG_IP_NF_TARGET_ULOG is not set
# CONFIG_IP_NF_TARGET_TCPMSS is not set
# CONFIG_IP_NF_ARPTABLES is not set
# CONFIG_IP_NF_COMPAT_IPCHAINS is not set
# CONFIG_IP_NF_COMPAT_IPFWADM is not set
# CONFIG_IPV6 is not set
# CONFIG_XFRM_USER is not set

#
# SCTP Configuration (EXPERIMENTAL)
#
CONFIG_IPV6_SCTP__=y
# CONFIG_IP_SCTP is not set
# CONFIG_ATM is not set
# CONFIG_VLAN_8021Q is not set
# CONFIG_LLC is not set
# CONFIG_DECNET is not set
# CONFIG_BRIDGE is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_NET_DIVERT is not set
# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set
# CONFIG_NET_FASTROUTE is not set
# CONFIG_NET_HW_FLOWCONTROL is not set

#
# QoS and/or fair queueing
#
# CONFIG_NET_SCHED is not set

#
# Network testing
#
# CONFIG_NET_PKTGEN is not set
CONFIG_NETDEVICES=y

#
# ARCnet devices
#
# CONFIG_ARCNET is not set
# CONFIG_DUMMY is not set
# CONFIG_BONDING is not set
# CONFIG_EQUALIZER is not set
CONFIG_TUN=m
# CONFIG_ETHERTAP is not set

#
# Ethernet (10 or 100Mbit)
#
CONFIG_NET_ETHERNET=y
# CONFIG_MII is not set
# CONFIG_HAPPYMEAL is not set
# CONFIG_SUNGEM is not set
CONFIG_NET_VENDOR_3COM=y
CONFIG_VORTEX=m
# CONFIG_TYPHOON is not set

#
# Tulip family network device support
#
# CONFIG_NET_TULIP is not set
# CONFIG_HP100 is not set
# CONFIG_NET_PCI is not set

#
# Ethernet (1000 Mbit)
#
# CONFIG_ACENIC is not set
# CONFIG_DL2K is not set
# CONFIG_E1000 is not set
# CONFIG_NS83820 is not set
# CONFIG_HAMACHI is not set
# CONFIG_YELLOWFIN is not set
# CONFIG_R8169 is not set
# CONFIG_SK98LIN is not set
# CONFIG_TIGON3 is not set

#
# Ethernet (10000 Mbit)
#
# CONFIG_IXGB is not set
# CONFIG_FDDI is not set
# CONFIG_HIPPI is not set
# CONFIG_PPP is not set
# CONFIG_SLIP is not set

#
# Wireless LAN (non-hamradio)
#
# CONFIG_NET_RADIO is not set

#
# Token Ring devices (depends on LLC=y)
#
# CONFIG_RCPCI is not set
# CONFIG_SHAPER is not set

#
# Wan interfaces
#
# CONFIG_WAN is not set

#
# PCMCIA network device support
#
# CONFIG_NET_PCMCIA is not set

#
# Amateur Radio support
#
# CONFIG_HAMRADIO is not set

#
# IrDA (infrared) support
#
# CONFIG_IRDA is not set

#
# ISDN subsystem
#
# CONFIG_ISDN_BOOL is not set

#
# Telephony Support
#
# CONFIG_PHONE is not set

#
# Input device support
#
CONFIG_INPUT=y

#
# Userland interfaces
#
CONFIG_INPUT_MOUSEDEV=y
CONFIG_INPUT_MOUSEDEV_PSAUX=y
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
# CONFIG_INPUT_JOYDEV is not set
# CONFIG_INPUT_TSDEV is not set
# CONFIG_INPUT_EVDEV is not set
# CONFIG_INPUT_EVBUG is not set

#
# Input I/O drivers
#
# CONFIG_GAMEPORT is not set
CONFIG_SOUND_GAMEPORT=y
CONFIG_SERIO=y
CONFIG_SERIO_I8042=y
# CONFIG_SERIO_SERPORT is not set
# CONFIG_SERIO_CT82C710 is not set

#
# Input Device Drivers
#
CONFIG_INPUT_KEYBOARD=y
CONFIG_KEYBOARD_ATKBD=y
# CONFIG_KEYBOARD_SUNKBD is not set
# CONFIG_KEYBOARD_XTKBD is not set
# CONFIG_KEYBOARD_NEWTON is not set
CONFIG_INPUT_MOUSE=y
CONFIG_MOUSE_PS2=y
# CONFIG_MOUSE_SERIAL is not set
# CONFIG_INPUT_JOYSTICK is not set
# CONFIG_INPUT_TOUCHSCREEN is not set
# CONFIG_INPUT_MISC is not set

#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_HW_CONSOLE=y
# CONFIG_SERIAL_NONSTANDARD is not set

#
# Serial drivers
#
# CONFIG_SERIAL_8250 is not set

#
# Non-8250 serial port support
#
CONFIG_UNIX98_PTYS=y
CONFIG_UNIX98_PTY_COUNT=256

#
# I2C support
#
# CONFIG_I2C is not set

#
# I2C Hardware Sensors Mainboard support
#

#
# I2C Hardware Sensors Chip support
#
# CONFIG_I2C_SENSOR is not set

#
# Mice
#
# CONFIG_BUSMOUSE is not set
# CONFIG_QIC02_TAPE is not set

#
# IPMI
#
# CONFIG_IPMI_HANDLER is not set

#
# Watchdog Cards
#
# CONFIG_WATCHDOG is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_NVRAM is not set
CONFIG_RTC=y
# CONFIG_DTLK is not set
# CONFIG_R3964 is not set
# CONFIG_APPLICOM is not set
# CONFIG_SONYPI is not set

#
# Ftape, the floppy tape device driver
#
# CONFIG_FTAPE is not set
CONFIG_AGP=y
# CONFIG_AGP_ALI is not set
# CONFIG_AGP_AMD is not set
# CONFIG_AGP_AMD_8151 is not set
CONFIG_AGP_INTEL=y
# CONFIG_AGP_NVIDIA is not set
# CONFIG_AGP_SIS is not set
# CONFIG_AGP_SWORKS is not set
# CONFIG_AGP_VIA is not set
# CONFIG_DRM is not set

#
# PCMCIA character devices
#
# CONFIG_SYNCLINK_CS is not set
# CONFIG_MWAVE is not set
# CONFIG_RAW_DRIVER is not set
# CONFIG_HANGCHECK_TIMER is not set

#
# Multimedia devices
#
# CONFIG_VIDEO_DEV is not set

#
# Digital Video Broadcasting Devices
#
# CONFIG_DVB is not set

#
# File systems
#
CONFIG_EXT2_FS=y
# CONFIG_EXT2_FS_XATTR is not set
# CONFIG_EXT3_FS is not set
# CONFIG_JBD is not set
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
# CONFIG_XFS_FS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_ROMFS_FS is not set
# CONFIG_QUOTA is not set
# CONFIG_AUTOFS_FS is not set
CONFIG_AUTOFS4_FS=m

#
# CD-ROM/DVD Filesystems
#
CONFIG_ISO9660_FS=m
CONFIG_JOLIET=y
CONFIG_ZISOFS=y
CONFIG_ZISOFS_FS=m
CONFIG_UDF_FS=m

#
# DOS/FAT/NT Filesystems
#
CONFIG_FAT_FS=m
# CONFIG_MSDOS_FS is not set
CONFIG_VFAT_FS=m
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
# CONFIG_DEVFS_FS is not set
CONFIG_DEVPTS_FS=y
CONFIG_TMPFS=y
CONFIG_RAMFS=y

#
# Miscellaneous filesystems
#
# CONFIG_ADFS_FS is not set
# CONFIG_AFFS_FS is not set
# CONFIG_HFS_FS is not set
# CONFIG_BEFS_FS is not set
# CONFIG_BFS_FS is not set
# CONFIG_EFS_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set

#
# Network File Systems
#
CONFIG_NFS_FS=m
CONFIG_NFS_V3=y
# CONFIG_NFS_V4 is not set
CONFIG_NFSD=m
CONFIG_NFSD_V3=y
# CONFIG_NFSD_V4 is not set
CONFIG_NFSD_TCP=y
CONFIG_LOCKD=m
CONFIG_LOCKD_V4=y
CONFIG_EXPORTFS=m
CONFIG_SUNRPC=m
# CONFIG_SUNRPC_GSS is not set
CONFIG_SMB_FS=m
CONFIG_SMB_NLS_DEFAULT=y
CONFIG_SMB_NLS_REMOTE="cp437"
CONFIG_CIFS=m
# CONFIG_NCP_FS is not set
# CONFIG_CODA_FS is not set
# CONFIG_INTERMEZZO_FS is not set
# CONFIG_AFS_FS is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y
CONFIG_SMB_NLS=y
CONFIG_NLS=y

#
# Native Language Support
#
CONFIG_NLS_DEFAULT="utf8"
CONFIG_NLS_CODEPAGE_437=m
# CONFIG_NLS_CODEPAGE_737 is not set
# CONFIG_NLS_CODEPAGE_775 is not set
CONFIG_NLS_CODEPAGE_850=m
# CONFIG_NLS_CODEPAGE_852 is not set
# CONFIG_NLS_CODEPAGE_855 is not set
# CONFIG_NLS_CODEPAGE_857 is not set
# CONFIG_NLS_CODEPAGE_860 is not set
# CONFIG_NLS_CODEPAGE_861 is not set
# CONFIG_NLS_CODEPAGE_862 is not set
# CONFIG_NLS_CODEPAGE_863 is not set
# CONFIG_NLS_CODEPAGE_864 is not set
# CONFIG_NLS_CODEPAGE_865 is not set
# CONFIG_NLS_CODEPAGE_866 is not set
# CONFIG_NLS_CODEPAGE_869 is not set
# CONFIG_NLS_CODEPAGE_936 is not set
# CONFIG_NLS_CODEPAGE_950 is not set
# CONFIG_NLS_CODEPAGE_932 is not set
# CONFIG_NLS_CODEPAGE_949 is not set
# CONFIG_NLS_CODEPAGE_874 is not set
# CONFIG_NLS_ISO8859_8 is not set
# CONFIG_NLS_CODEPAGE_1250 is not set
# CONFIG_NLS_CODEPAGE_1251 is not set
CONFIG_NLS_ISO8859_1=m
# CONFIG_NLS_ISO8859_2 is not set
# CONFIG_NLS_ISO8859_3 is not set
# CONFIG_NLS_ISO8859_4 is not set
# CONFIG_NLS_ISO8859_5 is not set
# CONFIG_NLS_ISO8859_6 is not set
# CONFIG_NLS_ISO8859_7 is not set
# CONFIG_NLS_ISO8859_9 is not set
# CONFIG_NLS_ISO8859_13 is not set
# CONFIG_NLS_ISO8859_14 is not set
CONFIG_NLS_ISO8859_15=m
# CONFIG_NLS_KOI8_R is not set
# CONFIG_NLS_KOI8_U is not set
CONFIG_NLS_UTF8=m

#
# Graphics support
#
# CONFIG_FB is not set
CONFIG_VIDEO_SELECT=y

#
# Console display driver support
#
CONFIG_VGA_CONSOLE=y
# CONFIG_MDA_CONSOLE is not set
CONFIG_DUMMY_CONSOLE=y

#
# Sound
#
CONFIG_SOUND=y

#
# Advanced Linux Sound Architecture
#
CONFIG_SND=y
# CONFIG_SND_SEQUENCER is not set
CONFIG_SND_OSSEMUL=y
CONFIG_SND_MIXER_OSS=y
CONFIG_SND_PCM_OSS=y
CONFIG_SND_RTCTIMER=y
# CONFIG_SND_VERBOSE_PRINTK is not set
# CONFIG_SND_DEBUG is not set

#
# Generic devices
#
# CONFIG_SND_DUMMY is not set
# CONFIG_SND_MTPAV is not set
# CONFIG_SND_SERIAL_U16550 is not set
# CONFIG_SND_MPU401 is not set

#
# PCI devices
#
# CONFIG_SND_ALI5451 is not set
# CONFIG_SND_CS46XX is not set
# CONFIG_SND_CS4281 is not set
# CONFIG_SND_EMU10K1 is not set
# CONFIG_SND_KORG1212 is not set
# CONFIG_SND_NM256 is not set
# CONFIG_SND_RME32 is not set
# CONFIG_SND_RME96 is not set
# CONFIG_SND_RME9652 is not set
# CONFIG_SND_HDSP is not set
# CONFIG_SND_TRIDENT is not set
CONFIG_SND_YMFPCI=y
# CONFIG_SND_ALS4000 is not set
# CONFIG_SND_CMIPCI is not set
# CONFIG_SND_ENS1370 is not set
# CONFIG_SND_ENS1371 is not set
# CONFIG_SND_ES1938 is not set
# CONFIG_SND_ES1968 is not set
# CONFIG_SND_MAESTRO3 is not set
# CONFIG_SND_FM801 is not set
# CONFIG_SND_ICE1712 is not set
# CONFIG_SND_ICE1724 is not set
# CONFIG_SND_INTEL8X0 is not set
# CONFIG_SND_SONICVIBES is not set
# CONFIG_SND_VIA82XX is not set

#
# ALSA USB devices
#
# CONFIG_SND_USB_AUDIO is not set

#
# Open Sound System
#
# CONFIG_SOUND_PRIME is not set

#
# USB support
#
CONFIG_USB=y
# CONFIG_USB_DEBUG is not set

#
# Miscellaneous USB options
#
CONFIG_USB_DEVICEFS=y
# CONFIG_USB_BANDWIDTH is not set
# CONFIG_USB_DYNAMIC_MINORS is not set

#
# USB Host Controller Drivers
#
# CONFIG_USB_EHCI_HCD is not set
# CONFIG_USB_OHCI_HCD is not set
CONFIG_USB_UHCI_HCD=y

#
# USB Device Class drivers
#
# CONFIG_USB_AUDIO is not set
# CONFIG_USB_BLUETOOTH_TTY is not set
# CONFIG_USB_MIDI is not set
# CONFIG_USB_ACM is not set
CONFIG_USB_PRINTER=m

#
# SCSI support is needed for USB Storage
#

#
# USB Human Interface Devices (HID)
#
CONFIG_USB_HID=y
CONFIG_USB_HIDINPUT=y
# CONFIG_HID_FF is not set
CONFIG_USB_HIDDEV=y
# CONFIG_USB_AIPTEK is not set
# CONFIG_USB_WACOM is not set
# CONFIG_USB_KBTAB is not set
# CONFIG_USB_POWERMATE is not set
# CONFIG_USB_XPAD is not set

#
# USB Imaging devices
#
# CONFIG_USB_MDC800 is not set
CONFIG_USB_SCANNER=m

#
# USB Multimedia devices
#
# CONFIG_USB_DABUSB is not set

#
# Video4Linux support is needed for USB Multimedia device support
#

#
# USB Network adaptors
#
# CONFIG_USB_CATC is not set
# CONFIG_USB_KAWETH is not set
# CONFIG_USB_PEGASUS is not set
# CONFIG_USB_RTL8150 is not set
# CONFIG_USB_USBNET is not set

#
# USB port drivers
#

#
# USB Serial Converter support
#
CONFIG_USB_SERIAL=m
CONFIG_USB_SERIAL_GENERIC=y
# CONFIG_USB_SERIAL_BELKIN is not set
# CONFIG_USB_SERIAL_WHITEHEAT is not set
# CONFIG_USB_SERIAL_DIGI_ACCELEPORT is not set
# CONFIG_USB_SERIAL_EMPEG is not set
# CONFIG_USB_SERIAL_FTDI_SIO is not set
# CONFIG_USB_SERIAL_VISOR is not set
CONFIG_USB_SERIAL_IPAQ=m
# CONFIG_USB_SERIAL_IR is not set
# CONFIG_USB_SERIAL_EDGEPORT is not set
# CONFIG_USB_SERIAL_EDGEPORT_TI is not set
# CONFIG_USB_SERIAL_KEYSPAN_PDA is not set
# CONFIG_USB_SERIAL_KEYSPAN is not set
# CONFIG_USB_SERIAL_KLSI is not set
# CONFIG_USB_SERIAL_KOBIL_SCT is not set
# CONFIG_USB_SERIAL_MCT_U232 is not set
# CONFIG_USB_SERIAL_PL2303 is not set
# CONFIG_USB_SERIAL_SAFE is not set
# CONFIG_USB_SERIAL_CYBERJACK is not set
# CONFIG_USB_SERIAL_XIRCOM is not set
# CONFIG_USB_SERIAL_OMNINET is not set

#
# USB Miscellaneous drivers
#
# CONFIG_USB_TIGL is not set
# CONFIG_USB_AUERSWALD is not set
# CONFIG_USB_RIO500 is not set
# CONFIG_USB_BRLVGER is not set
# CONFIG_USB_LCD is not set
# CONFIG_USB_TEST is not set
# CONFIG_USB_GADGET is not set

#
# Bluetooth support
#
# CONFIG_BT is not set

#
# Profiling support
#
# CONFIG_PROFILING is not set

#
# Kernel hacking
#
# CONFIG_DEBUG_KERNEL is not set
# CONFIG_KALLSYMS is not set
# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
CONFIG_DEBUG_INFO=y
# CONFIG_FRAME_POINTER is not set

#
# Security options
#
# CONFIG_SECURITY is not set

#
# Cryptographic options
#
# CONFIG_CRYPTO is not set

#
# Library routines
#
# CONFIG_CRC32 is not set
CONFIG_ZLIB_INFLATE=m
CONFIG_X86_BIOS_REBOOT=y

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  7:56         ` Zwane Mwaikambo
@ 2003-05-15 17:34           ` Patrick Mochel
  0 siblings, 0 replies; 17+ messages in thread
From: Patrick Mochel @ 2003-05-15 17:34 UTC (permalink / raw)
  To: Zwane Mwaikambo; +Cc: Andrew Morton, linux-kernel, Felipe Alfaro Solana


> Pat what do you say to some late shutdown callbacks? I'll drop you a 
> patch sometime tommorrow.

Bah. It would work, but it's a hack. We'll get caught in a game similar to 
the leap-frogging initcalls. In fact, we could just get really twisted and 
define various levels of exitcalls. [ Or, do them implicitly with some 
linkser-section-fu by calling the modules' exit functions in the reverse 
order in which they were initialized, but that's another story. ]

I just think that system level devices need to be treated specially in 
every case. They just don't work as normal devices because of the ordering 
issue. We can keep a separate list of them and deal with them explicitly 
after regular devices. It's not that bad of a change, but will take a few 
days, unless someone wants to take a stab at it..


	-pat



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15 12:02         ` Felipe Alfaro Solana
@ 2003-05-15 17:35           ` Patrick Mochel
  0 siblings, 0 replies; 17+ messages in thread
From: Patrick Mochel @ 2003-05-15 17:35 UTC (permalink / raw)
  To: Felipe Alfaro Solana; +Cc: Zwane Mwaikambo, Andrew Morton, LKML


> OK, I've changed "#undef DEBUG" to "#define DEBUG" in
> drivers/base/power.c, but during shutdown, I can see no extra debug
> messages. What am I doing wrong?

Nothing. No one has shutdown methods in their drivers. This patch should 
give you a little more info. For me, it says the i8259 is getting shutdown 
very early in the process, which surely can't be good..


	-pat

===== drivers/base/power.c 1.18 vs edited =====
--- 1.18/drivers/base/power.c	Mon Jan  6 09:56:05 2003
+++ edited/drivers/base/power.c	Thu May 15 10:30:25 2003
@@ -8,7 +8,7 @@
  *
  */
 
-#undef DEBUG
+#define DEBUG
 
 #include <linux/device.h>
 #include <linux/module.h>
@@ -88,10 +88,12 @@
 	down_write(&devices_subsys.rwsem);
 	list_for_each(entry,&devices_subsys.kset.list) {
 		struct device * dev = to_dev(entry);
+		pr_debug("shutting down %s: ",dev->name);
 		if (dev->driver && dev->driver->shutdown) {
-			pr_debug("shutting down %s\n",dev->name);
+			pr_debug("Ok\n");
 			dev->driver->shutdown(dev);
-		}
+		} else
+			pr_debug("Ignored.\n");
 	}
 	up_write(&devices_subsys.rwsem);
 }


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15  2:39   ` Patrick Mochel
  2003-05-15  2:45     ` Zwane Mwaikambo
  2003-05-15  6:14     ` Andrew Morton
@ 2003-05-16 19:41     ` Pavel Machek
  2 siblings, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2003-05-16 19:41 UTC (permalink / raw)
  To: Patrick Mochel; +Cc: Andrew Morton, linux-kernel

Hi!

> > > Hi again, Andrew,
> > > 
> > > Besides the "make_KOBJ_NAME-match_BUS_ID_SIZE.patch" causing "pccard"
> > > oopses, I've also found that, with 2.5.69-mm5 compiled with ACPI
> > > support, my laptop is unable to power off. The kernel invokes
> > > "acpi_power_off" and stays there forever.
> > > 
> > > I've found that reverting the "i8259-shutdown.patch" fixes the problem
> > > and my laptop is able to shutdown properly (init 0) when using ACPI.
> > > 
> > > A hardware bug? A kernel bug?
> > 
> > And thanks again, again.
> > 
> > That's the below patch.  It looks pretty innocuous.  I'd be assuming that
> > there's something in the shutdown sequence which needs 8259 functionality
> > after the thing has been turned off.
> > 
> > This could well depend upon .config contents and linkage order.
> > 
> > Eric, maybe we need to turn it off by hand at the right time rather than
> > relying on driver model shutdown ordering?
> 
> Interesting. This is yet more proof that system-level devices cannot be
> treated as common, everyday devices. Sure, it's nice to see them show up
> in sysfs with little overhead, and very nice not to have to work about
> them during shutdown or power transitions. But there are just too many
> special cases (like getting the ordering right ;) that you have to worry
> about.
> 
> So, what do we do with them? 

I guess shutdown needs to be treated like suspend, and needs to have
"level". There should be no shutdown, you should do suspend(5, ) and
go through all levels properly.
								Pavel

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-15 12:07       ` Felipe Alfaro Solana
@ 2003-05-17 19:25         ` Zwane Mwaikambo
  2003-05-17 19:47           ` Felipe Alfaro Solana
  0 siblings, 1 reply; 17+ messages in thread
From: Zwane Mwaikambo @ 2003-05-17 19:25 UTC (permalink / raw)
  To: Felipe Alfaro Solana; +Cc: Andrew Morton, Patrick Mochel, LKML

On Thu, 15 May 2003, Felipe Alfaro Solana wrote:

> > In this case we need to understand why the lockup is happening - what
> > code is requiring 8259 services after the thing has been turned off?
> > Could be that the bug lies there.
> > 
> > Felipe, please send your .config.   (again - in fact you may as well do
> > cp .config ~/.signature)
> 
> Config attached...
> Don't understand what do you mean with "cp .config ~/.signature" :-?
> 

Unable to reproduce, appears to be machine specific, 1 laptop and 2 test 
systems both managed to power off with APM or ACPI. Also tried with 
Felipe's config

	Zwane
-- 
function.linuxpower.ca

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-17 19:25         ` Zwane Mwaikambo
@ 2003-05-17 19:47           ` Felipe Alfaro Solana
  2003-05-17 20:35             ` Zwane Mwaikambo
  0 siblings, 1 reply; 17+ messages in thread
From: Felipe Alfaro Solana @ 2003-05-17 19:47 UTC (permalink / raw)
  To: Zwane Mwaikambo; +Cc: Andrew Morton, Patrick Mochel, LKML

On Sat, 2003-05-17 at 21:25, Zwane Mwaikambo wrote:
> On Thu, 15 May 2003, Felipe Alfaro Solana wrote:
> 
> > > In this case we need to understand why the lockup is happening - what
> > > code is requiring 8259 services after the thing has been turned off?
> > > Could be that the bug lies there.
> > > 
> > > Felipe, please send your .config.   (again - in fact you may as well do
> > > cp .config ~/.signature)
> > 
> > Config attached...
> > Don't understand what do you mean with "cp .config ~/.signature" :-?
> > 
> Unable to reproduce, appears to be machine specific, 1 laptop and 2 test 
> systems both managed to power off with APM or ACPI. Also tried with 
> Felipe's config

The machine is a NEC (Packard Bell) Chrom@. Could an lspci be of
interest?


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-17 19:47           ` Felipe Alfaro Solana
@ 2003-05-17 20:35             ` Zwane Mwaikambo
  2003-05-18 19:42               ` Felipe Alfaro Solana
  0 siblings, 1 reply; 17+ messages in thread
From: Zwane Mwaikambo @ 2003-05-17 20:35 UTC (permalink / raw)
  To: Felipe Alfaro Solana; +Cc: Andrew Morton, Patrick Mochel, LKML

On Sat, 17 May 2003, Felipe Alfaro Solana wrote:

> The machine is a NEC (Packard Bell) Chrom@. Could an lspci be of
> interest?

Hmm perhaps /var/log/dmesg, also can you try this ugly patch?

Index: linux-2.5.69-mm6/drivers/acpi/hardware/hwsleep.c
===================================================================
RCS file: /build/cvsroot/linux-2.5.69/drivers/acpi/hardware/hwsleep.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 hwsleep.c
--- linux-2.5.69-mm6/drivers/acpi/hardware/hwsleep.c	6 May 2003 12:20:11 -0000	1.1.1.1
+++ linux-2.5.69-mm6/drivers/acpi/hardware/hwsleep.c	17 May 2003 20:33:20 -0000
@@ -306,7 +306,7 @@ acpi_enter_sleep_state (
 		 * still read the right value. Ideally, this entire block would go
 		 * away entirely.
 		 */
-		acpi_os_stall (10000000);
+		/* acpi_os_stall (10000000); */
 
 		status = acpi_hw_register_write (ACPI_MTX_DO_NOT_LOCK, ACPI_REGISTER_PM1_CONTROL,
 				 sleep_enable_reg_info->access_bit_mask);
Index: linux-2.5.69-mm6/drivers/acpi/sleep/poweroff.c
===================================================================
RCS file: /build/cvsroot/linux-2.5.69/drivers/acpi/sleep/poweroff.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 poweroff.c
--- linux-2.5.69-mm6/drivers/acpi/sleep/poweroff.c	6 May 2003 12:20:12 -0000	1.1.1.1
+++ linux-2.5.69-mm6/drivers/acpi/sleep/poweroff.c	17 May 2003 20:35:11 -0000
@@ -15,6 +15,7 @@ acpi_power_off (void)
 	printk("%s called\n",__FUNCTION__);
 	acpi_enter_sleep_state_prep(ACPI_STATE_S5);
 	ACPI_DISABLE_IRQS();
+	printk("%s:%d\n", __FUNCTION__, __LINE__);
 	acpi_enter_sleep_state(ACPI_STATE_S5);
 }
 
-- 
function.linuxpower.ca

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: 2.5.69-mm5: reverting i8259-shutdown.patch
  2003-05-17 20:35             ` Zwane Mwaikambo
@ 2003-05-18 19:42               ` Felipe Alfaro Solana
  0 siblings, 0 replies; 17+ messages in thread
From: Felipe Alfaro Solana @ 2003-05-18 19:42 UTC (permalink / raw)
  To: Zwane Mwaikambo; +Cc: Andrew Morton, Patrick Mochel, LKML

[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]

On Sat, 2003-05-17 at 22:35, Zwane Mwaikambo wrote:
> On Sat, 17 May 2003, Felipe Alfaro Solana wrote:
> 
> > The machine is a NEC (Packard Bell) Chrom@. Could an lspci be of
> > interest?
> 
> Hmm perhaps /var/log/dmesg, also can you try this ugly patch?
> 
> Index: linux-2.5.69-mm6/drivers/acpi/hardware/hwsleep.c
> ===================================================================
> RCS file: /build/cvsroot/linux-2.5.69/drivers/acpi/hardware/hwsleep.c,v
> retrieving revision 1.1.1.1
> diff -u -p -B -r1.1.1.1 hwsleep.c
> --- linux-2.5.69-mm6/drivers/acpi/hardware/hwsleep.c	6 May 2003 12:20:11 -0000	1.1.1.1
> +++ linux-2.5.69-mm6/drivers/acpi/hardware/hwsleep.c	17 May 2003 20:33:20 -0000
> @@ -306,7 +306,7 @@ acpi_enter_sleep_state (
>  		 * still read the right value. Ideally, this entire block would go
>  		 * away entirely.
>  		 */
> -		acpi_os_stall (10000000);
> +		/* acpi_os_stall (10000000); */
>  
>  		status = acpi_hw_register_write (ACPI_MTX_DO_NOT_LOCK, ACPI_REGISTER_PM1_CONTROL,
>  				 sleep_enable_reg_info->access_bit_mask);
> Index: linux-2.5.69-mm6/drivers/acpi/sleep/poweroff.c
> ===================================================================
> RCS file: /build/cvsroot/linux-2.5.69/drivers/acpi/sleep/poweroff.c,v
> retrieving revision 1.1.1.1
> diff -u -p -B -r1.1.1.1 poweroff.c
> --- linux-2.5.69-mm6/drivers/acpi/sleep/poweroff.c	6 May 2003 12:20:12 -0000	1.1.1.1
> +++ linux-2.5.69-mm6/drivers/acpi/sleep/poweroff.c	17 May 2003 20:35:11 -0000
> @@ -15,6 +15,7 @@ acpi_power_off (void)
>  	printk("%s called\n",__FUNCTION__);
>  	acpi_enter_sleep_state_prep(ACPI_STATE_S5);
>  	ACPI_DISABLE_IRQS();
> +	printk("%s:%d\n", __FUNCTION__, __LINE__);
>  	acpi_enter_sleep_state(ACPI_STATE_S5);
>  }
>  
With the previous patch applied, I can't make the kernel to printk
anything interesting after "Halting the computer". Now, I can't even see
the "acpi_power_off" message I was seen before.

Attached is "/var/log/dmesg" of a 2.5.69-mm6 kernel.
Thanks!


[-- Attachment #2: dmesg --]
[-- Type: application/octet-stream, Size: 7315 bytes --]

Linux version 2.5.69-mm6-test (root@glass.felipe-alfaro.com) (gcc version 2.96 20000731 (Red Hat Linux 7.3 2.96-118)) #2 Sun May 18 21:29:28 CEST 2003
Video mode to be used for restore is f00
BIOS-provided physical RAM map:
 BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
 BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
 BIOS-e820: 00000000000e0000 - 0000000000100000 (reserved)
 BIOS-e820: 0000000000100000 - 000000000fff0000 (usable)
 BIOS-e820: 000000000fff0000 - 000000000fff8000 (ACPI data)
 BIOS-e820: 000000000fff8000 - 0000000010000000 (ACPI NVS)
 BIOS-e820: 00000000fec00000 - 00000000fec01000 (reserved)
 BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
 BIOS-e820: 00000000fff80000 - 0000000100000000 (reserved)
255MB LOWMEM available.
On node 0 totalpages: 65520
  DMA zone: 4096 pages, LIFO batch:1
  Normal zone: 61424 pages, LIFO batch:14
  HighMem zone: 0 pages, LIFO batch:1
ACPI: RSDP (v000 NEC                        ) @ 0x000fb550
ACPI: RSDT (v001    NEC ND000020 00000.00001) @ 0x0fff0000
ACPI: FADT (v001    NEC ND000020 00000.00001) @ 0x0fff0030
ACPI: BOOT (v001    NEC ND000020 00000.00001) @ 0x0fff00b0
ACPI: DSDT (v001    NEC ND000020 00000.00001) @ 0x00000000
ACPI: BIOS passes blacklist
Building zonelist for node : 0
Kernel command line: ro root=/dev/hda3 3
Initializing CPU#0
PID hash table entries: 1024 (order 10: 8192 bytes)
Detected 697.050 MHz processor.
Console: colour VGA+ 80x25
Calibrating delay loop... 1376.25 BogoMIPS
Memory: 256356k/262080k available (1570k kernel code, 4996k reserved, 543k data, 96k init, 0k highmem)
Dentry cache hash table entries: 32768 (order: 5, 131072 bytes)
Inode-cache hash table entries: 16384 (order: 4, 65536 bytes)
Mount-cache hash table entries: 512 (order: 0, 4096 bytes)
-> /dev
-> /dev/console
-> /root
CPU: L1 I cache: 16K, L1 D cache: 16K
CPU: L2 cache: 256K
CPU:     After generic, caps: 0383f9ff 00000000 00000000 00000040
CPU: Intel Pentium III (Coppermine) stepping 06
Enabling fast FPU save and restore... done.
Enabling unmasked SIMD FPU exception support... done.
Checking 'hlt' instruction... OK.
POSIX conformance testing by UNIFIX
mtrr: v2.0 (20020519)
Initializing RT netlink socket
PCI: PCI BIOS revision 2.10 entry at 0xfdb81, last bus=1
PCI: Using configuration type 1
BIO: pool of 256 setup, 14Kb (56 bytes/bio)
biovec pool[0]:   1 bvecs: 256 entries (12 bytes)
biovec pool[1]:   4 bvecs: 256 entries (48 bytes)
biovec pool[2]:  16 bvecs: 256 entries (192 bytes)
biovec pool[3]:  64 bvecs: 256 entries (768 bytes)
biovec pool[4]: 128 bvecs: 256 entries (1536 bytes)
biovec pool[5]: 256 bvecs: 256 entries (3072 bytes)
ACPI: Subsystem revision 20030418
ACPI: Interpreter enabled
ACPI: Using PIC for interrupt routing
ACPI: PCI Root Bridge [NRTH] (00:00)
PCI: Probing PCI hardware (bus 00)
ACPI: PCI Interrupt Routing Table [\_SB_.NRTH._PRT]
ACPI: Embedded Controller [EC0] (gpe 9)
ACPI: Power Resource [PUSB] (off)
ACPI: PCI Interrupt Link [LNKA] (IRQs 10, disabled)
ACPI: PCI Interrupt Link [LNKB] (IRQs 5, disabled)
ACPI: PCI Interrupt Link [LNKC] (IRQs 5 7 10, disabled)
ACPI: PCI Interrupt Link [LNKD] (IRQs 9, disabled)
block request queues:
 4/128 requests per read queue
 4/128 requests per write queue
 enter congestion at 15
 exit congestion at 17
Linux Kernel Card Services 3.1.22
  options:  [pci] [cardbus] [pm]
drivers/usb/core/usb.c: registered new driver usbfs
drivers/usb/core/usb.c: registered new driver hub
ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 10
ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 5
ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 5
ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 9
PCI: Using ACPI for IRQ routing
PCI: if you experience problems, try using option 'pci=noacpi' or even 'acpi=off'
SBF: Simple Boot Flag extension found and enabled.
SBF: Setting boot flags 0x1
Enabling SEP on CPU 0
Limiting direct PCI/PCI transfers.
ACPI: AC Adapter [AC] (on-line)
ACPI: Battery Slot [BAT0] (battery absent)
ACPI: Power Button (CM) [PRB1]
ACPI: Lid Switch [LID0]
ACPI: Fan [FANC] (on)
ACPI: Processor [CPU0] (supports C1)
ACPI: Thermal Zone [THRM] (64 C)
pty: 256 Unix98 ptys configured
Real Time Clock Driver v1.11
Linux agpgart interface v0.100 (c) Dave Jones
agpgart: Detected an Intel 440BX Chipset.
agpgart: Maximum main memory to use for agp memory: 203M
agpgart: AGP aperture is 256M @ 0xe0000000
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
PIIX4: IDE controller at PCI slot 00:07.1
PIIX4: chipset revision 1
PIIX4: not 100% native mode: will probe irqs later
    ide0: BM-DMA at 0xffa0-0xffa7, BIOS settings: hda:DMA, hdb:pio
    ide1: BM-DMA at 0xffa8-0xffaf, BIOS settings: hdc:DMA, hdd:pio
hda: HITACHI_DK23BA-20, ATA DISK drive
anticipatory scheduling elevator
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
hdc: MATSHITADVD-ROM SR-8185, ATAPI CD/DVD-ROM drive
anticipatory scheduling elevator
ide1 at 0x170-0x177,0x376 on irq 15
hda: max request size: 128KiB
hda: host protected area => 1
hda: 39070080 sectors (20004 MB) w/2048KiB Cache, CHS=38760/16/63, UDMA(33)
 hda: hda1 hda2 hda3 hda4
hdc: ATAPI 24X DVD-ROM drive, 512kB Cache, UDMA(33)
Uniform CD-ROM driver Revision: 3.12
yenta 00:0c.0: Preassigned resource 3 busy, reconfiguring...
Yenta IRQ list 08d8, PCI irq10
Socket status: 30000068
yenta 00:0c.1: Preassigned resource 2 busy, reconfiguring...
yenta 00:0c.1: Preassigned resource 3 busy, reconfiguring...
Yenta IRQ list 08d8, PCI irq5
Socket status: 30000006
drivers/usb/host/uhci-hcd.c: USB Universal Host Controller Interface driver v2.0
uhci-hcd 00:07.2: Intel Corp. 82371AB/EB/MB PIIX4 
uhci-hcd 00:07.2: irq 9, io base 0000ef80
Please use the 'usbfs' filetype instead, the 'usbdevfs' name is deprecated.
uhci-hcd 00:07.2: new USB bus registered, assigned bus number 1
hub 1-0:0: USB hub found
hub 1-0:0: 2 ports detected
drivers/usb/core/usb.c: registered new driver hiddev
drivers/usb/core/usb.c: registered new driver hid
drivers/usb/input/hid-core.c: v2.0:USB HID core driver
mice: PS/2 mouse device common for all mice
input: ImPS/2 Generic Wheel Mouse on isa0060/serio1
serio: i8042 AUX port at 0x60,0x64 irq 12
input: AT Set 2 keyboard on isa0060/serio0
serio: i8042 KBD port at 0x60,0x64 irq 1
Advanced Linux Sound Architecture Driver Version 0.9.2 (Thu Mar 20 13:31:57 2003 UTC).
ALSA device list:
  #0: Yamaha DS-XG PCI (YMF754) at 0xd0851000, irq 5
NET4: Linux TCP/IP 1.0 for NET4.0
IP: routing cache hash table of 2048 buckets, 16Kbytes
TCP: Hash tables configured (established 16384 bind 16384)
NET4: Unix domain sockets 1.0/SMP for Linux NET4.0.
hub 1-0:0: debounce: port 1: delay 100ms stable 4 status 0x301
VFS: Mounted root (ext2 filesystem) readonly.
Freeing unused kernel memory: 96k freed
hub 1-0:0: new USB device on port 1, assigned address 2
input: USB HID v1.00 Mouse [Microsoft Microsoft IntelliMouse® Explorer] on usb-00:07.2-1
hub 1-0:0: debounce: port 2: delay 100ms stable 4 status 0x101
hub 1-0:0: new USB device on port 2, assigned address 3
hub 1-2:0: USB hub found
hub 1-2:0: 2 ports detected
Adding 257032k swap on /dev/hda2.  Priority:-1 extents:1
blk: queue c033ff7c, I/O limit 4095Mb (mask 0xffffffff)
hdc: drive_cmd: status=0x51 { DriveReady SeekComplete Error }
hdc: drive_cmd: error=0x04Aborted Command 

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2003-05-18 19:29 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-15  2:23 2.5.69-mm5: reverting i8259-shutdown.patch Felipe Alfaro Solana
2003-05-15  2:33 ` Andrew Morton
2003-05-15  2:39   ` Patrick Mochel
2003-05-15  2:45     ` Zwane Mwaikambo
2003-05-15  3:00       ` Patrick Mochel
2003-05-15 12:02         ` Felipe Alfaro Solana
2003-05-15 17:35           ` Patrick Mochel
2003-05-15  6:14     ` Andrew Morton
2003-05-15  6:13       ` Zwane Mwaikambo
2003-05-15  7:56         ` Zwane Mwaikambo
2003-05-15 17:34           ` Patrick Mochel
2003-05-15 12:07       ` Felipe Alfaro Solana
2003-05-17 19:25         ` Zwane Mwaikambo
2003-05-17 19:47           ` Felipe Alfaro Solana
2003-05-17 20:35             ` Zwane Mwaikambo
2003-05-18 19:42               ` Felipe Alfaro Solana
2003-05-16 19:41     ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).