* Re: ioctl32 cleanups: kill code duplication
@ 2003-05-19 1:35 Milton Miller
2003-05-19 19:16 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Milton Miller @ 2003-05-19 1:35 UTC (permalink / raw)
To: pavel; +Cc: linux-kernel
> +#include "../../../fs/compat_ioctl.c"
I think the kbuild people would rather you do this in the Makefile with
something like
CFLAGS_ioctl32.o += -Ifs/
and then
#include "compat_ioctl.c"
instead. I know the seperate source/obj dir people will.
milton
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ioctl32 cleanups: kill code duplication
2003-05-19 1:35 ioctl32 cleanups: kill code duplication Milton Miller
@ 2003-05-19 19:16 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2003-05-19 19:16 UTC (permalink / raw)
To: Milton Miller; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
Hi!
> > +#include "../../../fs/compat_ioctl.c"
>
> I think the kbuild people would rather you do this in the Makefile with
> something like
>
> CFLAGS_ioctl32.o += -Ifs/
>
> and then
>
> #include "compat_ioctl.c"
>
> instead. I know the seperate source/obj dir people will.
Applied, thanx. [Milton, you have some severe misconfiguration in your
mail system... watch your from address.]
Patch now looks like [attached]. If there are no protests I'll send it
to Linus.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
[-- Attachment #2: delme.gz --]
[-- Type: application/octet-stream, Size: 50473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* ioctl32 cleanups: kill code duplication
@ 2003-05-18 22:17 Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2003-05-18 22:17 UTC (permalink / raw)
To: kernel list
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
Hi!
I guess volunteers porting this to other architectures would be
welcome at this point. It should work properly at both x86-64 and
sparc64 and adding new architectures should be painless.
Please test/port ;-).
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
[-- Attachment #2: delme.gz --]
[-- Type: application/octet-stream, Size: 50269 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-05-19 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-19 1:35 ioctl32 cleanups: kill code duplication Milton Miller
2003-05-19 19:16 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2003-05-18 22:17 Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).