* [PATCH] fix oops in namespace.c
@ 2003-05-18 22:57 Andries.Brouwer
2003-05-19 18:20 ` viro
0 siblings, 1 reply; 2+ messages in thread
From: Andries.Brouwer @ 2003-05-18 22:57 UTC (permalink / raw)
To: torvalds, viro; +Cc: linux-kernel
Number four in the series of namespace.c fixes:
A familar type of Oops: d_path() can return an error ENAMETOOLONG,
and if we fail to test a segfault occurs.
So we must test. What we do is a different matter.
Rather arbitrarily I return the string " (too long)"
for use in /proc/mounts.
Andries
--- namespace.c~ Mon May 19 01:50:48 2003
+++ namespace.c Mon May 19 01:51:24 2003
@@ -217,6 +217,8 @@
if (!path_buf)
return -ENOMEM;
path = d_path(mnt->mnt_root, mnt, path_buf, PAGE_SIZE);
+ if (IS_ERR(path))
+ path = " (too long)";
mangle(m, mnt->mnt_devname ? mnt->mnt_devname : "none");
seq_putc(m, ' ');
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix oops in namespace.c
2003-05-18 22:57 [PATCH] fix oops in namespace.c Andries.Brouwer
@ 2003-05-19 18:20 ` viro
0 siblings, 0 replies; 2+ messages in thread
From: viro @ 2003-05-19 18:20 UTC (permalink / raw)
To: Andries.Brouwer; +Cc: torvalds, viro, linux-kernel
On Mon, May 19, 2003 at 12:57:37AM +0200, Andries.Brouwer@cwi.nl wrote:
> Number four in the series of namespace.c fixes:
>
> A familar type of Oops: d_path() can return an error ENAMETOOLONG,
> and if we fail to test a segfault occurs.
>
> So we must test. What we do is a different matter.
> Rather arbitrarily I return the string " (too long)"
> for use in /proc/mounts.
There's a better fix. Since we are going to use seq_...() anyway,
we both have a buffer and length. Moreover, if there's not enough
space to store the result, generic seq_file code will take care
about expanding buffer and calling us again.
IOW, we need to add seq_path(seq_file *, vfsmount *, dentry *) that would
DTRT. That would have a benefit of avoiding extra allocation/freeing.
I'll send such patch in ~20 minutes. BTW, it's also needed for /proc/swaps
and can be used for /proc/<pid>/maps if we switch it to seq_file (worth
doing anyway).
PS: math.psu.edu account is alive, but I'm not checking it often these
days, so Cc there is not too useful.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-05-19 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-18 22:57 [PATCH] fix oops in namespace.c Andries.Brouwer
2003-05-19 18:20 ` viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).