* RE: [PATCH] Make ACPI compile again on 64bit/gcc 3.3
@ 2003-05-24 20:55 Grover, Andrew
2003-05-24 22:19 ` Andi Kleen
2003-05-24 22:39 ` [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II Andi Kleen
0 siblings, 2 replies; 4+ messages in thread
From: Grover, Andrew @ 2003-05-24 20:55 UTC (permalink / raw)
To: Andi Kleen, torvalds, linux-kernel
Actually, I think osl.c should be changed to match the header as it
stands. Could you try that and see if that also fixes things?
Thanks -- Regards -- Andy
> From: Andi Kleen [mailto:ak@suse.de]
> Without this patch ACPI in BK-CVS current does not compile on
> AMD64/gcc 3.3.
>
> -Andi
>
>
> Index: linux/include/acpi/acpiosxf.h
> ===================================================================
> RCS file: /home/cvs/linux-2.5/include/acpi/acpiosxf.h,v
> retrieving revision 1.7
> diff -u -u -r1.7 acpiosxf.h
> --- linux/include/acpi/acpiosxf.h 24 May 2003 01:49:28
> -0000 1.7
> +++ linux/include/acpi/acpiosxf.h 24 May 2003 07:32:37 -0000
> @@ -287,15 +287,15 @@
> * Miscellaneous
> */
>
> -u8
> +BOOLEAN
> acpi_os_readable (
> void *pointer,
> - acpi_size length);
> + u32 length);
>
> -u8
> +BOOLEAN
> acpi_os_writable (
> void *pointer,
> - acpi_size length);
> + u32 length);
>
> u32
> acpi_os_get_timer (
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Make ACPI compile again on 64bit/gcc 3.3
2003-05-24 20:55 [PATCH] Make ACPI compile again on 64bit/gcc 3.3 Grover, Andrew
@ 2003-05-24 22:19 ` Andi Kleen
2003-05-24 22:39 ` [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II Andi Kleen
1 sibling, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2003-05-24 22:19 UTC (permalink / raw)
To: Grover, Andrew; +Cc: Andi Kleen, torvalds, linux-kernel
On Sat, May 24, 2003 at 01:55:26PM -0700, Grover, Andrew wrote:
> Actually, I think osl.c should be changed to match the header as it
> stands. Could you try that and see if that also fixes things?
Yes it does of course.
BTW FYI these are the warnings I see in ACPI when compiling with gcc 3.3 for
64bit:
drivers/acpi/processor.c: In function `acpi_processor_add_fs':
drivers/acpi/processor.c:1518: warning: assignment from incompatible pointer typ e
drivers/acpi/processor.c:1531: warning: assignment from incompatible pointer typ e
drivers/acpi/thermal.c:187: warning: initialization from incompatible pointer ty pe
drivers/acpi/thermal.c:195: warning: initialization from incompatible pointer ty poe
drivers/acpi/thermal.c:203: warning: initialization from incompatible pointer type
drivers/acpi/utils.c: In function `acpi_evaluate_reference':
drivers/acpi/utils.c:351: warning: unsigned int format, different type arg (arg
5)
-Andi
Index: linux/drivers/acpi/osl.c
===================================================================
RCS file: /home/cvs/linux-2.5/drivers/acpi/osl.c,v
retrieving revision 1.27
diff -u -u -r1.27 osl.c
--- linux/drivers/acpi/osl.c 24 May 2003 01:49:28 -0000 1.27
+++ linux/drivers/acpi/osl.c 24 May 2003 21:12:05 -0000
@@ -952,14 +952,14 @@
* We just have to assume we're dealing with valid memory
*/
-BOOLEAN
-acpi_os_readable(void *ptr, u32 len)
+u8
+acpi_os_readable(void *ptr, acpi_size len)
{
return 1;
}
-BOOLEAN
-acpi_os_writable(void *ptr, u32 len)
+u8
+acpi_os_writable(void *ptr, acpi_size len)
{
return 1;
}
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II
2003-05-24 20:55 [PATCH] Make ACPI compile again on 64bit/gcc 3.3 Grover, Andrew
2003-05-24 22:19 ` Andi Kleen
@ 2003-05-24 22:39 ` Andi Kleen
1 sibling, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2003-05-24 22:39 UTC (permalink / raw)
To: Grover, Andrew; +Cc: Andi Kleen, torvalds, linux-kernel
On Sat, May 24, 2003 at 01:55:26PM -0700, Grover, Andrew wrote:
> Actually, I think osl.c should be changed to match the header as it
> stands. Could you try that and see if that also fixes things?
On looking again these functions are not used at all.
How about just removing them?
If you really wanted them you could implement them really by walking
page tables on i386.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Make ACPI compile again on 64bit/gcc 3.3
@ 2003-05-24 8:39 Andi Kleen
0 siblings, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2003-05-24 8:39 UTC (permalink / raw)
To: andrew.grover, torvalds, linux-kernel
Without this patch ACPI in BK-CVS current does not compile on AMD64/gcc 3.3.
-Andi
Index: linux/include/acpi/acpiosxf.h
===================================================================
RCS file: /home/cvs/linux-2.5/include/acpi/acpiosxf.h,v
retrieving revision 1.7
diff -u -u -r1.7 acpiosxf.h
--- linux/include/acpi/acpiosxf.h 24 May 2003 01:49:28 -0000 1.7
+++ linux/include/acpi/acpiosxf.h 24 May 2003 07:32:37 -0000
@@ -287,15 +287,15 @@
* Miscellaneous
*/
-u8
+BOOLEAN
acpi_os_readable (
void *pointer,
- acpi_size length);
+ u32 length);
-u8
+BOOLEAN
acpi_os_writable (
void *pointer,
- acpi_size length);
+ u32 length);
u32
acpi_os_get_timer (
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-05-24 22:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-24 20:55 [PATCH] Make ACPI compile again on 64bit/gcc 3.3 Grover, Andrew
2003-05-24 22:19 ` Andi Kleen
2003-05-24 22:39 ` [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2003-05-24 8:39 [PATCH] Make ACPI compile again on 64bit/gcc 3.3 Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).