Regarding SET_NETDEV_DEV

Regarding SET_NETDEV_DEV

[Jeff Garzik]

For janitors and other developers placing this in net drivers...
please don't :)  This can be done in upper layers, accomplishing the
same goal without changing the low-level net driver code at all.

	Jeff

Re: Regarding SET_NETDEV_DEV

[David S. Miller]

   From: Jeff Garzik <jgarzik@pobox.com>
   Date: Tue, 3 Jun 2003 13:59:21 -0400

   For janitors and other developers placing this in net drivers...
   please don't :)  This can be done in upper layers, accomplishing the
   same goal without changing the low-level net driver code at all.
   
Don't say something can be done without showing exactly
how :-)

How does register_netdevice() know that the device is "whatever" and
where to get the generic device struct from?

Re: Regarding SET_NETDEV_DEV

[Jeff Garzik]

David S. Miller wrote:
>    From: Jeff Garzik <jgarzik@pobox.com>
>    Date: Tue, 3 Jun 2003 13:59:21 -0400
> 
>    For janitors and other developers placing this in net drivers...
>    please don't :)  This can be done in upper layers, accomplishing the
>    same goal without changing the low-level net driver code at all.
>    
> Don't say something can be done without showing exactly
> how :-)
> 
> How does register_netdevice() know that the device is "whatever" and
> where to get the generic device struct from?


Doh!  You are totally right -- it can't get the association any other 
way.  Folks, ignore me :)

	Jeff

Re: Regarding SET_NETDEV_DEV

[Stephen Hemminger]

David S. Miller wrote:

>   From: Jeff Garzik <jgarzik@pobox.com>
>   Date: Tue, 3 Jun 2003 13:59:21 -0400
>
>   For janitors and other developers placing this in net drivers...
>   please don't :)  This can be done in upper layers, accomplishing the
>   same goal without changing the low-level net driver code at all.
>   
>Don't say something can be done without showing exactly
>how :-)
>
>How does register_netdevice() know that the device is "whatever" and
>where to get the generic device struct from?
>
There are enough PCI network devices, that something like 
alloc_pci_etherdev might
be a good future idea.

Re: Regarding SET_NETDEV_DEV

[David S. Miller]

   From: Stephen Hemminger <shemminger@osdl.org>
   Date: Tue, 03 Jun 2003 20:45:21 -0700

   There are enough PCI network devices, that something like 
   alloc_pci_etherdev might
   be a good future idea.
   
What is sos special about PCI? :-)

In this light, alloc_device_etherdev() seems much more appropriate.

But we can play this game AD_INFINITUM, for each and every paramter
that is common across a class of ethernet devices.  At what point
do you stop? :-)