linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix ide-mod unload crash
@ 2003-06-03 11:01 Herbert Xu
  0 siblings, 0 replies; only message in thread
From: Herbert Xu @ 2003-06-03 11:01 UTC (permalink / raw)
  To: Linus Torvalds, Alan Cox, Marcelo Tosatti; +Cc: Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

This patch fixes an unload crash when no PCI drivers are loaded.

It's scary that people writing code like this is hacking on the
driver where all my data is stored on! Time to make more backups :)
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 917 bytes --]

Index: drivers/ide/ide-proc.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/drivers/ide/ide-proc.c,v
retrieving revision 1.1.1.6
diff -u -r1.1.1.6 ide-proc.c
--- drivers/ide/ide-proc.c	1 Jun 2003 03:06:25 -0000	1.1.1.6
+++ drivers/ide/ide-proc.c	3 Jun 2003 10:54:58 -0000
@@ -982,16 +982,11 @@
 void proc_ide_destroy(void)
 {
 #ifdef CONFIG_BLK_DEV_IDEPCI
-	ide_pci_host_proc_t *p = ide_pci_host_proc_list;
-	char name[32];
+	ide_pci_host_proc_t *p;
 
-	while ((p->name != NULL) && (p->set) && (p->get_info != NULL)) {
-		name[0] = '\0';
-		sprintf(name, "ide/%s", p->name);
+	for (p = ide_pci_host_proc_list; p; p = p->next) {
 		if (p->set == 2)
 			remove_proc_entry(p->name, p->parent);
-		if (p->next == NULL) break;
-		p = p->next;
 	}
 #endif /* CONFIG_BLK_DEV_IDEPCI */
 	remove_proc_entry("ide/drivers", proc_ide_root);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-06-04  8:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-03 11:01 [PATCH] Fix ide-mod unload crash Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).