From: Samuel Thibault <Samuel.Thibault@ens-lyon.fr>
To: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: [patch][2.5] speedstep_detect_speed might not reenable interrupts
Date: Sat, 14 Jun 2003 02:35:39 -0400 [thread overview]
Message-ID: <20030614063539.GA508@bouh.unh.edu> (raw)
hi,
local_irq_save() is called at the beginning of speedstep_detect_speeds,
but local_irq_restore() is not called on I/O errors.
--- linux-2.5.70-bk12/arch/i386/kernel/cpu/cpufreq/speedstep.c 2003-05-26 21:00:20.000000000 -0400
+++ linux-2.5.70-bk12-perso/arch/i386/kernel/cpu/cpufreq/speedstep.c 2003-06-14 02:23:34.000000000 -0400
@@ -538,8 +538,10 @@
for (i=0; i<2; i++) {
/* read the current state */
result = speedstep_get_state(&state);
- if (result)
+ if (result) {
+ local_irq_restore(flags);
return result;
+ }
/* save the correct value, and switch to other */
if (state == SPEEDSTEP_LOW) {
next reply other threads:[~2003-06-14 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-14 6:35 Samuel Thibault [this message]
2003-06-14 7:37 ` [BUG] 2.4.21 - kernel BUG at dev.c:991 Christopher S. Aker
2003-06-14 8:04 ` Christopher S. Aker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030614063539.GA508@bouh.unh.edu \
--to=samuel.thibault@ens-lyon.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@fnac.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).