linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch][2.5] speedstep_detect_speed might not reenable interrupts
@ 2003-06-14  6:35 Samuel Thibault
  2003-06-14  7:37 ` [BUG] 2.4.21 - kernel BUG at dev.c:991 Christopher S. Aker
  0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ 2003-06-14  6:35 UTC (permalink / raw)
  To: linux-kernel, torvalds

hi,

local_irq_save() is called at the beginning of speedstep_detect_speeds,
but local_irq_restore() is not called on I/O errors.

--- linux-2.5.70-bk12/arch/i386/kernel/cpu/cpufreq/speedstep.c	2003-05-26 21:00:20.000000000 -0400
+++ linux-2.5.70-bk12-perso/arch/i386/kernel/cpu/cpufreq/speedstep.c	2003-06-14 02:23:34.000000000 -0400
@@ -538,8 +538,10 @@
 	for (i=0; i<2; i++) {
 		/* read the current state */
 		result = speedstep_get_state(&state);
-		if (result)
+		if (result) {
+			local_irq_restore(flags);
 			return result;
+		}
 
 		/* save the correct value, and switch to other */
 		if (state == SPEEDSTEP_LOW) {

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-06-14  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-14  6:35 [patch][2.5] speedstep_detect_speed might not reenable interrupts Samuel Thibault
2003-06-14  7:37 ` [BUG] 2.4.21 - kernel BUG at dev.c:991 Christopher S. Aker
2003-06-14  8:04   ` Christopher S. Aker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).