From: Jens Axboe <axboe@suse.de>
To: Andy Polyakov <appro@fy.chalmers.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Regarding drivers/ide/ide-cd.c in 2.5.72
Date: Thu, 19 Jun 2003 14:20:10 +0200 [thread overview]
Message-ID: <20030619122010.GL6445@suse.de> (raw)
In-Reply-To: <3EEF8E2E.5E14946E@fy.chalmers.se>
On Tue, Jun 17 2003, Andy Polyakov wrote:
> Hi,
>
> I have brought this issue once already in 2.5.70 context (see uppermost
> post in http://marc.theaimsgroup.com/?t=105410790500005&r=1&w=2), but it
> apparently slipped through. So I've decided to bring it up again, this
> time describing [hopefully] better how does this *generic* problem with
> ide-cd.c manifests itself. In the nutshell the problem is that [as it is
> now] every failed SG_IO request is replayed second time without data
> transfer. E.g. if WRITE(10) SCSI command fails with sense code X, ide-cd
> immediately resends the command block descriptor one more time, this time
> without programming for any associated I/O payload, which [normally]
> results in *different* sense code. And the catch is that user-land gets
> this second sense code instead of the real/original one. Suggested patch
> overcomes this problem by immediately purging the failed SG_IO request
> from the request queue.
Patch looks fine, care to resend actually trying to follow the style in
the file in question?
--
Jens Axboe
next prev parent reply other threads:[~2003-06-19 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-17 21:54 Regarding drivers/ide/ide-cd.c in 2.5.72 Andy Polyakov
2003-06-19 12:20 ` Jens Axboe [this message]
2003-06-19 14:12 ` Andy Polyakov
2003-06-19 14:07 ` Jens Axboe
2003-07-11 13:26 ` Andy Polyakov
2003-07-12 11:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030619122010.GL6445@suse.de \
--to=axboe@suse.de \
--cc=appro@fy.chalmers.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).