From: Jens Axboe <axboe@suse.de>
To: Andy Polyakov <appro@fy.chalmers.se>
Cc: linux-kernel@vger.kernel.org, proski@gnu.org
Subject: Re: Regarding drivers/ide/ide-cd.c in 2.5.72
Date: Sat, 12 Jul 2003 13:51:51 +0200 [thread overview]
Message-ID: <20030712115151.GP843@suse.de> (raw)
In-Reply-To: <3F0EBB05.E90B3DF2@fy.chalmers.se>
On Fri, Jul 11 2003, Andy Polyakov wrote:
> > > > > ... In the nutshell the problem is that [as it is
> > > > > now] every failed SG_IO request is replayed second time without data
> > > > > transfer. ... Suggested patch
> > > > > overcomes this problem by immediately purging the failed SG_IO request
> > > > > from the request queue.
> > > >
> > > > Patch looks fine, care to resend actually trying to follow the style in
> > > > the file in question?
> > >
> > > Revised to my best ability for follow the coding style of file in
> > > question. A:-)
> >
> > Much better, thanks :)
>
> And it slipped through again:-( Sharpen up! BTW, the proposed patch
Calm down, I pass the fixes on and sometimes the just fall through the
cracks (and not always just my cracks).
> fixes even http://marc.theaimsgroup.com/?t=105634805100001&r=1&w=2,
> where induced kernel crash occurs upon packet replay. Applicable to
> up to 2.5.75. A.
It looks reasonable, I'm wondering whether the ->ide_dma_off() isn't too
harsh in the first place. But we can look at that later.
--
Jens Axboe
prev parent reply other threads:[~2003-07-12 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-17 21:54 Regarding drivers/ide/ide-cd.c in 2.5.72 Andy Polyakov
2003-06-19 12:20 ` Jens Axboe
2003-06-19 14:12 ` Andy Polyakov
2003-06-19 14:07 ` Jens Axboe
2003-07-11 13:26 ` Andy Polyakov
2003-07-12 11:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030712115151.GP843@suse.de \
--to=axboe@suse.de \
--cc=appro@fy.chalmers.se \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).