linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Marcus Metzler <mocm@metzlerbros.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	mocm@mocm.de, Michael Hunold <hunold@convergence.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org
Subject: Re: DVB Include files
Date: Wed, 25 Jun 2003 22:23:12 +0200	[thread overview]
Message-ID: <20030625202312.GG1770@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <16122.379.321217.737557@sheridan.metzler>

On Wed, 25 June 2003 22:09:31 +0200, Marcus Metzler wrote:
> =?iso-8859-1?Q?J=F6rn?= Engel writes:
>  > On Wed, 25 June 2003 20:43:23 +0200, Marcus Metzler wrote:
>  > > Christoph Hellwig writes:
>  > >  > On Wed, Jun 25, 2003 at 08:09:51PM +0200, Marcus Metzler wrote:
>  > >  > >  > If the structures change incompatibly you're fucked anyway.  Better
>  > >  > > 
>  > >  > > Not necessarily, e.g. changing
>  > >  > > 
>  > >  > > #define AUDIO_SET_ATTRIBUTES       _IOW('o', 17, audio_attributes_t)
>  > >  > > #define AUDIO_SET_KARAOKE          _IOW('o', 18, audio_karaoke_t)
>  > >  > > 
>  > >  > > to 
>  > >  > > 
>  > >  > > #define AUDIO_SET_ATTRIBUTES       _IOW('o', 47, audio_attributes_t)
>  > >  > > #define AUDIO_SET_KARAOKE          _IOW('o', 48, audio_karaoke_t)
>  > >  > > 
>  > >  > > or
>  > >  > 
>  > >  > In that case yes, you are screwed.  Your ABI just changed incompatibly.
>  > > 
>  > > Not if you recompile.
>  > 
>  > Isn't the point of an application _binary_ interface, that you don't
>  > have to recompile?
> 
> You don't need headers for binaries either, so what's your point.

So you don't recompile, but you still changed the magic ioctl numbers
from 17 to 47 and from 18 to 48.  Old binaries don't work any more,
even though the same semantics are still present.  That is an
incompatible change in my book.

Worse if there is a new semantic for 17 or 18, in that case the old
binaries may break randomly, depending on kernel version.

Jörn

-- 
Beware of bugs in the above code; I have only proved it correct, but
not tried it.
-- Donald Knuth

  reply	other threads:[~2003-06-25 20:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-25 15:06 DVB Include files Sam Ravnborg
2003-06-25 15:08 ` Christoph Hellwig
2003-06-25 15:42   ` Sam Ravnborg
2003-06-25 16:17     ` Michael Hunold
2003-06-25 16:49       ` Marcus Metzler
2003-06-25 16:55         ` Christoph Hellwig
2003-06-25 17:13           ` Marcus Metzler
2003-06-25 17:16             ` Christoph Hellwig
2003-06-25 17:22               ` Marcus Metzler
2003-06-25 17:24                 ` Christoph Hellwig
2003-06-25 17:30                   ` Marcus Metzler
2003-06-25 17:50                     ` Christoph Hellwig
2003-06-25 18:09                       ` Marcus Metzler
2003-06-25 18:15                         ` Christoph Hellwig
2003-06-25 18:43                           ` Marcus Metzler
2003-06-25 19:42                             ` Jörn Engel
2003-06-25 20:09                               ` Marcus Metzler
2003-06-25 20:23                                 ` Jörn Engel [this message]
2003-06-25 20:48                                   ` Marcus Metzler
2003-06-25 21:03                                     ` Christoph Hellwig
2003-06-25 21:38                                       ` Marcus Metzler
2003-06-26 13:54                                         ` Henning P. Schmiedehausen
2003-06-25 23:08                                   ` Alan Cox
2003-06-26  8:18                                     ` Michael Hunold
2003-06-26  8:24                                       ` Christoph Hellwig
2003-06-26 13:20                                         ` Johannes Stezenbach
2003-06-25 21:03                             ` Christoph Hellwig
2003-06-25 17:27           ` Jörn Engel
2003-06-25 17:49             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030625202312.GG1770@wohnheim.fh-wedel.de \
    --to=joern@wohnheim.fh-wedel.de \
    --cc=hch@infradead.org \
    --cc=hunold@convergence.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mocm@metzlerbros.de \
    --cc=mocm@mocm.de \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).