* [patch] Hardly triggered tests in bootmem.c ...
@ 2003-07-02 22:07 Davide Libenzi
2003-07-03 14:46 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Davide Libenzi @ 2003-07-02 22:07 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Andrew Morton
I was looking at the bootmem.c source and I found those hardly triggered
tests (unsigned long's).
(Andrew, sending the patch insted of the note)
- Davide
--- linux-2.5.73/mm/bootmem.c.orig 2003-07-02 14:55:47.000000000 -0700
+++ linux-2.5.73/mm/bootmem.c 2003-07-02 14:56:51.000000000 -0700
@@ -84,10 +84,6 @@
if (!size) BUG();
- if (sidx < 0)
- BUG();
- if (eidx < 0)
- BUG();
if (sidx >= eidx)
BUG();
if ((addr >> PAGE_SHIFT) >= bdata->node_low_pfn)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] Hardly triggered tests in bootmem.c ...
2003-07-02 22:07 [patch] Hardly triggered tests in bootmem.c Davide Libenzi
@ 2003-07-03 14:46 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2003-07-03 14:46 UTC (permalink / raw)
To: Davide Libenzi; +Cc: Andrew Morton, Linux Kernel Mailing List
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thursday 03 July 2003 00:07, Davide Libenzi wrote:
> I was looking at the bootmem.c source and I found those hardly triggered
> tests (unsigned long's).
> (Andrew, sending the patch insted of the note)
>
>
> - Davide
>
>
>
>
> --- linux-2.5.73/mm/bootmem.c.orig 2003-07-02 14:55:47.000000000 -0700
> +++ linux-2.5.73/mm/bootmem.c 2003-07-02 14:56:51.000000000 -0700
> @@ -84,10 +84,6 @@
>
> if (!size) BUG();
>
> - if (sidx < 0)
> - BUG();
> - if (eidx < 0)
> - BUG();
> if (sidx >= eidx)
> BUG();
> if ((addr >> PAGE_SHIFT) >= bdata->node_low_pfn)
shouldn't we convert the remaining
if (x)
BUG();
to
BUG_ON(x)
?
- --
Regards Michael Buesch
http://www.8ung.at/tuxsoft
16:44:38 up 1:00, 1 user, load average: 1.00, 1.00, 0.95
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE/BEG6oxoigfggmSgRAuFAAJ4iJfEdI5J+SBrDQ9CZM3eEwDC6iwCcDyL7
ssuTGbtylaaqagOLLtYi3ds=
=4xv5
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-07-03 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-02 22:07 [patch] Hardly triggered tests in bootmem.c Davide Libenzi
2003-07-03 14:46 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).