* PATCH: fix security leaks and a crash in es1370
@ 2003-07-11 18:12 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2003-07-11 18:12 UTC (permalink / raw)
To: linux-kernel, torvalds
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.5.75/sound/oss/es1370.c linux-2.5.75-ac1/sound/oss/es1370.c
--- linux-2.5.75/sound/oss/es1370.c 2003-07-10 21:15:34.000000000 +0100
+++ linux-2.5.75-ac1/sound/oss/es1370.c 2003-07-11 17:10:35.000000000 +0100
@@ -889,8 +889,8 @@
}
if (cmd == SOUND_MIXER_INFO) {
mixer_info info;
- strlcpy(info.id, "ES1370", sizeof(info.id));
- strlcpy(info.name, "Ensoniq ES1370", sizeof(info.name));
+ strncpy(info.id, "ES1370", sizeof(info.id));
+ strncpy(info.name, "Ensoniq ES1370", sizeof(info.name));
info.modify_counter = s->mix.modcnt;
if (copy_to_user((void *)arg, &info, sizeof(info)))
return -EFAULT;
@@ -898,8 +898,8 @@
}
if (cmd == SOUND_OLD_MIXER_INFO) {
_old_mixer_info info;
- strlcpy(info.id, "ES1370", sizeof(info.id));
- strlcpy(info.name, "Ensoniq ES1370", sizeof(info.name));
+ strncpy(info.id, "ES1370", sizeof(info.id));
+ strncpy(info.name, "Ensoniq ES1370", sizeof(info.name));
if (copy_to_user((void *)arg, &info, sizeof(info)))
return -EFAULT;
return 0;
@@ -2484,12 +2484,8 @@
break;
if (signal_pending(current))
break;
- if (file->f_flags & O_NONBLOCK) {
- remove_wait_queue(&s->midi.owait, &wait);
- set_current_state(TASK_RUNNING);
- unlock_kernel();
- return -EBUSY;
- }
+ if (file->f_flags & O_NONBLOCK)
+ break;
tmo = (count * HZ) / 3100;
if (!schedule_timeout(tmo ? : 1) && tmo)
DBG(printk(KERN_DEBUG "es1370: midi timed out??\n");)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-07-11 18:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-11 18:12 PATCH: fix security leaks and a crash in es1370 Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).