* PATCH: fix security leak in maestro.c
@ 2003-07-11 18:15 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2003-07-11 18:15 UTC (permalink / raw)
To: linux-kernel, torvalds
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.5.75/sound/oss/maestro.c linux-2.5.75-ac1/sound/oss/maestro.c
--- linux-2.5.75/sound/oss/maestro.c 2003-07-10 21:14:10.000000000 +0100
+++ linux-2.5.75-ac1/sound/oss/maestro.c 2003-07-11 16:28:21.000000000 +0100
@@ -2024,8 +2024,8 @@
VALIDATE_CARD(card);
if (cmd == SOUND_MIXER_INFO) {
mixer_info info;
- strlcpy(info.id, card_names[card->card_type], sizeof(info.id));
- strlcpy(info.name, card_names[card->card_type], sizeof(info.name));
+ strncpy(info.id, card_names[card->card_type], sizeof(info.id));
+ strncpy(info.name, card_names[card->card_type], sizeof(info.name));
info.modify_counter = card->mix.modcnt;
if (copy_to_user((void *)arg, &info, sizeof(info)))
return -EFAULT;
@@ -2033,8 +2033,8 @@
}
if (cmd == SOUND_OLD_MIXER_INFO) {
_old_mixer_info info;
- strlcpy(info.id, card_names[card->card_type], sizeof(info.id));
- strlcpy(info.name, card_names[card->card_type], sizeof(info.name));
+ strncpy(info.id, card_names[card->card_type], sizeof(info.id));
+ strncpy(info.name, card_names[card->card_type], sizeof(info.name));
if (copy_to_user((void *)arg, &info, sizeof(info)))
return -EFAULT;
return 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-07-11 18:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-11 18:15 PATCH: fix security leak in maestro.c Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).