linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruen@suse.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.22-pre8
Date: Fri, 25 Jul 2003 09:10:38 +0200	[thread overview]
Message-ID: <200307250910.38758.agruen@suse.de> (raw)
In-Reply-To: <Pine.GSO.4.21.0307250301030.28325-100000@vervain.sonytel.be>

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

Hello Geert and Marcelo,

it turns oout that the warning is bogus, and trivially fixed. Marcelo, you may 
want to apply the attached patch.

Cheers,
Andreas.

On Friday 25 July 2003 03:05, Geert Uytterhoeven wrote:
> On Thu, 24 Jul 2003, Marcelo Tosatti wrote:
> > Andreas Gruenbacher:
> >   o unshare-files fix breaks file locks
>
> Which adds one more warning (the third one below) to my build log:
> | ide.c:175: warning: `ide_scan_direction' defined but not used
> | ide-lib.c:174: warning: comparison of distinct pointer types lacks a cast
> | binfmt_elf.c:446: warning: `files' might be used uninitialized in this
> | function
>
> Seems to be harmless, though.

[-- Attachment #2: binfmt_elf-warning.diff --]
[-- Type: text/x-diff, Size: 399 bytes --]

--- linux-2.4.22-pre8.orig/fs/binfmt_elf.c	2003-07-25 08:58:59.000000000 +0200
+++ linux-2.4.22-pre8/fs/binfmt_elf.c	2003-07-25 08:59:07.000000000 +0200
@@ -797,10 +797,8 @@
 	if (current->ptrace & PT_PTRACED)
 		send_sig(SIGTRAP, current, 0);
 	retval = 0;
+	steal_locks(files, current->files);
 out:
-	if (!retval)
-		steal_locks(files, current->files);
-
 	return retval;
 
 	/* error cleanup */

  reply	other threads:[~2003-07-25  6:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-24 20:23 Marcelo Tosatti
2003-07-25  1:05 ` Geert Uytterhoeven
2003-07-25  7:10   ` Andreas Gruenbacher [this message]
2003-07-25  3:15 ` Nuno Silva
2003-07-25 12:41   ` Marcelo Tosatti
2003-07-27 16:31     ` Roy Sigurd Karlsbakk
2003-07-25 11:36 ` radeon still broken (was: Linux 2.4.22-pre8) Alessandro Suardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307250910.38758.agruen@suse.de \
    --to=agruen@suse.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --subject='Re: Linux 2.4.22-pre8' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).