linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: linux-kernel@vger.kernel.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, torvalds@osdl.org
Subject: [PATCH] uninitialized spinlock in drivers/net/sk_mca.c
Date: Sat, 26 Jul 2003 00:37:05 +0200	[thread overview]
Message-ID: <20030726003705.A1261@electric-eye.fr.zoreil.com> (raw)

A spinlock was recently added to struct skmca_priv so as to remove
save_flags()/cli() but nothing in the current code initializes it.

If the adequate diplodocus lurks in somebody's kitchen to test the patch...

 drivers/net/sk_mca.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/net/sk_mca.c~drivers-sk_mca-spinlock_init drivers/net/sk_mca.c
--- linux-2.6.0-test1-bk2/drivers/net/sk_mca.c~drivers-sk_mca-spinlock_init	Sat Jul 26 00:12:52 2003
+++ linux-2.6.0-test1-bk2-fr/drivers/net/sk_mca.c	Sat Jul 26 00:15:35 2003
@@ -1155,6 +1155,7 @@ int __init skmca_probe(struct SKMCA_NETD
 	priv->cmdaddr = base + 0x3ff3;
 	priv->medium = medium;
 	memset(&(priv->stat), 0, sizeof(struct net_device_stats));
+	spin_lock_init(&priv->lock);
 
 	/* set base + irq for this device (irq not allocated so far) */
 	dev->irq = 0;

_

                 reply	other threads:[~2003-07-25 22:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030726003705.A1261@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --subject='Re: [PATCH] uninitialized spinlock in drivers/net/sk_mca.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).