* [PATCH] uninitialized spinlock in drivers/net/sk_mca.c
@ 2003-07-25 22:37 Francois Romieu
0 siblings, 0 replies; only message in thread
From: Francois Romieu @ 2003-07-25 22:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Alan Cox, torvalds
A spinlock was recently added to struct skmca_priv so as to remove
save_flags()/cli() but nothing in the current code initializes it.
If the adequate diplodocus lurks in somebody's kitchen to test the patch...
drivers/net/sk_mca.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/net/sk_mca.c~drivers-sk_mca-spinlock_init drivers/net/sk_mca.c
--- linux-2.6.0-test1-bk2/drivers/net/sk_mca.c~drivers-sk_mca-spinlock_init Sat Jul 26 00:12:52 2003
+++ linux-2.6.0-test1-bk2-fr/drivers/net/sk_mca.c Sat Jul 26 00:15:35 2003
@@ -1155,6 +1155,7 @@ int __init skmca_probe(struct SKMCA_NETD
priv->cmdaddr = base + 0x3ff3;
priv->medium = medium;
memset(&(priv->stat), 0, sizeof(struct net_device_stats));
+ spin_lock_init(&priv->lock);
/* set base + irq for this device (irq not allocated so far) */
dev->irq = 0;
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-07-25 22:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-25 22:37 [PATCH] uninitialized spinlock in drivers/net/sk_mca.c Francois Romieu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).