From: "M. Warner Losh" <imp@bsdimp.com>
To: willy@debian.org
Cc: aebr@win.tue.nl, vandrove@vc.cvut.cz, jvb@prairienet.org,
bcollins@debian.org, torvalds@osdl.org,
linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net,
gan@planetlaz.com
Subject: Re: [ACPI] Re: [PATCH] bad strlcpy conversion breaks toshiba_acpi
Date: Sun, 27 Jul 2003 15:26:20 -0600 (MDT) [thread overview]
Message-ID: <20030727.152620.127108646.imp@bsdimp.com> (raw)
In-Reply-To: <20030727210203.GU1485@parcelfarce.linux.theplanet.co.uk>
In message: <20030727210203.GU1485@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox <willy@debian.org> writes:
: On Fri, Jul 25, 2003 at 06:57:09PM +0200, Andries Brouwer wrote:
: > strlcpy is for strings, not for character arrays.
: > The *BSD version accesses the source past the size-1 characters
: > that are copied:
: > while (*s++)
: > ;
: > Thus, replacing strncpy (used to copy character arrays, possibly
: > not 0-terminated) by strlcpy is wrong.
Ah, that's to get the silly return value correct :-(.
Warner
prev parent reply other threads:[~2003-07-28 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-25 14:46 [PATCH] bad strlcpy conversion breaks toshiba_acpi John Belmonte
2003-07-25 16:15 ` Petr Vandrovec
2003-07-25 16:57 ` Andries Brouwer
2003-07-27 21:02 ` [ACPI] " Matthew Wilcox
2003-07-27 21:26 ` M. Warner Losh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030727.152620.127108646.imp@bsdimp.com \
--to=imp@bsdimp.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=aebr@win.tue.nl \
--cc=bcollins@debian.org \
--cc=gan@planetlaz.com \
--cc=jvb@prairienet.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vandrove@vc.cvut.cz \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).