From: Matthew Wilcox <willy@debian.org>
To: Manuel Estrada Sainz <ranty@debian.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
greg@kroah.com, willy@debian.org,
Patrick Mochel <mochel@osdl.org>
Subject: Re: [PATCH] Re: Firmware loading problem
Date: Sun, 27 Jul 2003 20:21:11 +0100 [thread overview]
Message-ID: <20030727192111.GT1485@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030726090458.GA16634@ranty.pantax.net>
On Sat, Jul 26, 2003 at 11:04:58AM +0200, Manuel Estrada Sainz wrote:
> - hopefully adapt drivers/pci/pci-sysfs.c to this changes
> - Please double check, I didn't look very carefully on
> this.
Definitely wrong. I was going to undo this change since I realised how
it doesn't work for you; but the change you made to the PCI code is wrong.
It ends up copying everything to offset 0 from the buf address. I wish
Pat had cc'd me when making the change to the interface originally ;-(
I'll whip up a patch in a few minutes.
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-07-28 2:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-22 14:45 Firmware loading problem Marcel Holtmann
2003-07-22 14:55 ` Manuel Estrada Sainz
2003-07-22 15:38 ` Marcel Holtmann
2003-07-26 9:04 ` [PATCH] " Manuel Estrada Sainz
2003-07-26 11:14 ` Marcel Holtmann
2003-07-26 11:26 ` Manuel Estrada Sainz
2003-07-27 19:21 ` Matthew Wilcox [this message]
2003-07-27 21:21 ` Manuel Estrada Sainz
2003-08-01 15:05 ` Manuel Estrada Sainz
2003-08-01 18:50 ` Manuel Estrada Sainz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030727192111.GT1485@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mochel@osdl.org \
--cc=ranty@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).