From: "David S. Miller" <davem@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: PATCH: allow 2.6 to build on old old setups
Date: Mon, 28 Jul 2003 07:17:28 -0700 [thread overview]
Message-ID: <20030728071728.664051cf.davem@redhat.com> (raw)
In-Reply-To: <1059391858.15438.14.camel@dhcp22.swansea.linux.org.uk>
On 28 Jul 2003 12:30:59 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Llu, 2003-07-28 at 02:52, David S. Miller wrote:
> > > info->hdr->e_machine == EM_SPARCV9) {
> > > /* Ignore register directives. */
> > > if (ELF_ST_TYPE(sym->st_info) == STT_REGISTER)
> > > break;
> > > }
> > > +#endif
> >
> > This change is wrong.
> >
> > If you're going to do this, it's much better to define it to the
> > correct value in this case (which is decimal '13').
>
> Its sparc specific stuff so presumably all sparc stuff had the register?
> I can change and resubmit though - no problem
The situation is that, on every platform, one gets the define in
/usr/include/elf.h, it's just that older glibc's lack the define.
prev parent reply other threads:[~2003-07-28 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-27 20:26 PATCH: allow 2.6 to build on old old setups Alan Cox
2003-07-28 1:52 ` David S. Miller
2003-07-28 11:30 ` Alan Cox
2003-07-28 13:28 ` Mikael Pettersson
2003-07-28 14:17 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030728071728.664051cf.davem@redhat.com \
--to=davem@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).