* [bug 1080] [PATCH] 2.6.0-t3: alsa driver snd-powermac doesn't work with tumbler chip on ibook2
@ 2003-08-17 21:54 Francesco Sportolari
0 siblings, 0 replies; only message in thread
From: Francesco Sportolari @ 2003-08-17 21:54 UTC (permalink / raw)
To: linux-kernel; +Cc: DiegoCG, alsa-devel
During the insmod of the snd-powermac module this msg is printed to the
console:
tumbler: cannot initialize the MCS
After that, even if the module is loaded correctly, the sound doesn't work at
all.
I've noticed that removing and inserting again the 'i2c-keywest' module solves
the problem. The following patch fixes this issue related to early
initialization of the i2c client in the driver.
Bye,
-- Francesco
--- orig/sound/ppc/tumbler.c 2003-08-16 17:18:35.000000000 +0200
+++ linux-2.6.0-test3/sound/ppc/tumbler.c 2003-08-16 17:18:55.000000000
+0200
@@ -996,9 +996,6 @@
chipname = "Snapper";
}
- if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0)
- return err;
-
/*
* build mixers
*/
@@ -1025,6 +1022,9 @@
if ((err = tumbler_init(chip)) < 0)
return err;
+ if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0)
+ return err;
+
#ifdef CONFIG_PMAC_PBOOK
chip->resume = tumbler_resume;
#endif
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-08-17 19:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-17 21:54 [bug 1080] [PATCH] 2.6.0-t3: alsa driver snd-powermac doesn't work with tumbler chip on ibook2 Francesco Sportolari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).