From: Willy Tarreau <willy@w.ods.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [AMD76X]
Date: Sun, 24 Aug 2003 19:53:21 +0200 [thread overview]
Message-ID: <20030824175321.GF734@alpha.home.local> (raw)
In-Reply-To: <20030823233323.GA7989@gondor.apana.org.au>
On Sun, Aug 24, 2003 at 09:33:23AM +1000, Herbert Xu wrote:
> Hi:
>
> amd76x_pm.c will crash if no chipsets are found and CONFIG_HOTPLUG is
> turned on. This patch makes it return with a failure instead.
Hi !
I'm wondering whether this patch should be needed too.
Cheers,
Willy
--- linux-2.4.22-rc3/drivers/char/amd76x_pm.c.orig Sun Aug 24 19:52:42 2003
+++ linux-2.4.22-rc3/drivers/char/amd76x_pm.c Sun Aug 24 19:53:49 2003
@@ -620,6 +620,8 @@
#ifndef AMD76X_NTH
if (!amd76x_pm_cfg.curr_idle) {
printk(KERN_ERR "amd76x_pm: Idle function not changed\n");
+ pci_unregister_driver(&amd_nb_driver);
+ pci_unregister_driver(&amd_sb_driver);
return 1;
}
next prev parent reply other threads:[~2003-08-24 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-23 23:33 [AMD76X] Herbert Xu
2003-08-24 17:53 ` Willy Tarreau [this message]
2003-08-25 8:12 ` [AMD76X] Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030824175321.GF734@alpha.home.local \
--to=willy@w.ods.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).