linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: paul.devriendt@amd.com
Cc: davej@redhat.com, linux-kernel@vger.kernel.org, aj@suse.de,
	mark.langsdorf@amd.com, richard.brunner@amd.com
Subject: Re: Cpufreq for opteron
Date: Mon, 25 Aug 2003 11:35:56 +0200	[thread overview]
Message-ID: <20030825093556.GA3020@elf.ucw.cz> (raw)
In-Reply-To: <99F2150714F93F448942F9A9F112634C080EF00E@txexmtae.amd.com>

Hi!

> It appears to me that the BUG_ON() macro will take the machine
> down ? The BUG_ON() checks in this code (a sample below, but 
> this applies to all of the driver) are not fatal conditions - 
> execution can continue if an error is returned. Taking the 
> machine down to report on a non-fatal condition seems somewhat 
> rude.

It is somewhat rude, but it makes sure that the error gets fixed. [And
it also appears safer to me: if we know error already happened we opt
to stop the system so nothing bad happens.]

Questions:

1) is it possible to do hardware damage from powernow-k8 driver?

2) should some of those checks be fatal?

3) for nonfatal checks, is it possible to use WARN_ON() -- warn and
continue?

4) given good hardware and debugged driver, will any of those
BUG_ON()s ever trigger?

							Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

  reply	other threads:[~2003-08-25  9:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-24 15:31 Cpufreq for opteron paul.devriendt
2003-08-25  9:35 ` Pavel Machek [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-08-27  0:43 paul.devriendt
2003-08-27  5:13 ` Dominik Brodowski
2003-08-25 14:09 paul.devriendt
2003-08-25 12:53 paul.devriendt
2003-08-25 13:51 ` Pavel Machek
     [not found] <99F2150714F93F448942F9A9F112634C080EF006@txexmtae.amd.com.suse.lists.linux.kernel>
     [not found] ` <20030825084616.GC403@elf.ucw.cz.suse.lists.linux.kernel>
2003-08-25 10:56   ` Andi Kleen
2003-08-22 20:09 paul.devriendt
2003-08-25  8:46 ` Pavel Machek
2003-08-25 13:30   ` Valdis.Kletnieks
2003-08-22 16:25 Andi Kleen
2003-08-22 13:59 Pavel Machek
2003-08-22 14:43 ` Dave Jones
2003-08-22 19:55   ` Pavel Machek
2003-08-22 20:05   ` Pavel Machek
2003-08-26 23:02     ` Dominik Brodowski
2003-08-22 14:52 ` Christoph Hellwig
2003-08-22 14:55   ` Dave Jones
2003-08-22 19:54   ` Pavel Machek
2003-08-23  7:55     ` Rogier Wolff
2003-08-23 17:50       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030825093556.GA3020@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=aj@suse.de \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=paul.devriendt@amd.com \
    --cc=richard.brunner@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).