* [PATCH] VIA VT8231 router detection
@ 2003-08-30 13:11 Sebastian Reichelt
2003-08-30 17:37 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Reichelt @ 2003-08-30 13:11 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
Hello!
I have attached a trivial patch to the Linux 2.4.21 kernel (Debian
unstable kernel-source-2.4.21 package version 2.4.21-5), to add support
for "VIA Technologies, Inc. VT8231" as an interrupt router. I have also
attached the output of lspci -vvv (not inline because of line breaks, is
that OK?). Device 00:08.0, which did not have any IRQs assigned to it
before, has gotten IRQ 9. I have used this patch for months without any
problems, so it should be fine. Sorry if I have left out something
important; please consider me a newbie.
Here is the output of the ver_linux script:
------------------------------------------------------------------------
Linux SebastianL2 2.4.21 #1 Sat Aug 30 00:22:04 CEST 2003 i686 GNU/Linux
Gnu C 3.3.2
Gnu make 3.80
binutils 2.14.90.0.5
util-linux 2.11z
mount 2.11z
modutils 0.9.13
e2fsprogs 1.35-WIP
pcmcia-cs 3.2.2
Linux C Library 2.3.2
Dynamic linker (ldd) 2.3.2
Procps 3.1.11
Net-tools 1.60
Console-tools 0.2.3
Sh-utils 5.0.90
------------------------------------------------------------------------
If I am supposed to do something else with the patch (mail it to
Linus?), please tell me. Thanks for your attention.
--
Sebastian Reichelt
[-- Attachment #2: pci-irq.diff --]
[-- Type: text/plain, Size: 564 bytes --]
--- pci-irq.c.orig 2003-06-01 05:06:21.000000000 +0200
+++ pci-irq.c 2003-08-30 00:17:42.000000000 +0200
@@ -480,6 +480,7 @@
{ "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, pirq_via_get, pirq_via_set },
{ "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C596, pirq_via_get, pirq_via_set },
{ "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, pirq_via_get, pirq_via_set },
+ { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8231, pirq_via_get, pirq_via_set },
{ "OPTI", PCI_VENDOR_ID_OPTI, PCI_DEVICE_ID_OPTI_82C700, pirq_opti_get, pirq_opti_set },
[-- Attachment #3: lspci --]
[-- Type: text/plain, Size: 8725 bytes --]
00:00.0 Host bridge: VIA Technologies, Inc. VT8363/8365 [KT133/KM133] (rev 80)
Subsystem: Uniwill Computer Corp: Unknown device 8100
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ >SERR- <PERR-
Latency: 8
Region 0: Memory at e0000000 (32-bit, prefetchable) [size=64M]
Capabilities: [a0] AGP version 2.0
Status: RQ=32 Iso- ArqSz=0 Cal=0 SBA+ ITACoh- GART64- HTrans- 64bit- FW- AGP3- Rate=x1,x2,x4
Command: RQ=1 ArqSz=0 Cal=0 SBA- AGP- GART64- 64bit- FW- Rate=<none>
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:01.0 PCI bridge: VIA Technologies, Inc. VT8363/8365 [KT133/KM133 AGP] (prog-if 00 [Normal decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ >SERR- <PERR+
Latency: 0
Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
I/O behind bridge: 0000f000-00000fff
Memory behind bridge: dfd00000-dfefffff
Prefetchable memory behind bridge: cfb00000-dfbfffff
BridgeCtl: Parity- SERR- NoISA+ VGA+ MAbort- >Reset- FastB2B-
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1+ D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:08.0 CardBus bridge: O2 Micro, Inc. OZ6912 Cardbus Controller
Subsystem: Uniwill Computer Corp: Unknown device 3000
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping+ SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=slow >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 168
Interrupt: pin A routed to IRQ 9
Region 0: Memory at 10000000 (32-bit, non-prefetchable) [size=4K]
Bus: primary=00, secondary=02, subordinate=05, sec-latency=176
Memory window 0: 10400000-107ff000 (prefetchable)
Memory window 1: 10800000-10bff000
I/O window 0: 00004000-000040ff
I/O window 1: 00004400-000044ff
BridgeCtl: Parity- SERR- ISA- VGA- MAbort- >Reset- 16bInt+ PostWrite+
16-bit legacy interface ports at 0001
00:10.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 46) (prog-if 10 [OHCI])
Subsystem: Unknown device 8415:8200
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (8000ns max), cache line size 08
Interrupt: pin A routed to IRQ 10
Region 0: Memory at dffff800 (32-bit, non-prefetchable) [size=2K]
Region 1: I/O ports at ec00 [size=128]
Capabilities: [50] Power Management version 2
Flags: PMEClk- DSI- D1- D2+ AuxCurrent=0mA PME(D0-,D1-,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.0 ISA bridge: VIA Technologies, Inc. VT8231 [PCI-to-ISA Bridge] (rev 10)
Subsystem: Uniwill Computer Corp: Unknown device 8100
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping+ SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.1 IDE interface: VIA Technologies, Inc. VT82C586/B/686A/B PIPC Bus Master IDE (rev 06) (prog-if 8a [Master SecP PriP])
Subsystem: Uniwill Computer Corp: Unknown device 8235
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 32
Region 4: I/O ports at fc00 [size=16]
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.2 USB Controller: VIA Technologies, Inc. USB (rev 1e) (prog-if 00 [UHCI])
Subsystem: VIA Technologies, Inc. (Wrong ID) USB Controller
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 32, cache line size 08
Interrupt: pin D routed to IRQ 10
Region 4: I/O ports at d400 [size=32]
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.3 USB Controller: VIA Technologies, Inc. USB (rev 1e) (prog-if 00 [UHCI])
Subsystem: VIA Technologies, Inc. (Wrong ID) USB Controller
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 32, cache line size 08
Interrupt: pin D routed to IRQ 10
Region 4: I/O ports at d800 [size=32]
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.4 Bridge: VIA Technologies, Inc. VT8235 ACPI (rev 10)
Subsystem: Uniwill Computer Corp: Unknown device 8235
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Capabilities: [68] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.5 Multimedia audio controller: VIA Technologies, Inc. VT82C686 AC97 Audio Controller (rev 40)
Subsystem: Uniwill Computer Corp: Unknown device 8100
Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Interrupt: pin C routed to IRQ 10
Region 0: I/O ports at e400 [size=256]
Region 1: I/O ports at e000 [size=4]
Region 2: I/O ports at dc00 [size=4]
Capabilities: [c0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:11.6 Communication controller: VIA Technologies, Inc. Intel 537 [AC97 Modem] (rev 20)
Subsystem: Uniwill Computer Corp: Unknown device 4005
Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Interrupt: pin C routed to IRQ 10
Region 0: I/O ports at e800 [size=256]
Capabilities: [d0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
00:12.0 Ethernet controller: VIA Technologies, Inc. VT6102 [Rhine-II] (rev 51)
Subsystem: Uniwill Computer Corp: Unknown device 8100
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (750ns min, 2000ns max), cache line size 08
Interrupt: pin A routed to IRQ 9
Region 0: I/O ports at d000 [size=256]
Region 1: Memory at dffff700 (32-bit, non-prefetchable) [size=256]
Capabilities: [40] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
01:00.0 VGA compatible controller: S3 Inc. VT8636A [ProSavage KN133] AGP4X VGA Controller (TwisterK) (rev 01) (prog-if 00 [VGA])
Subsystem: Uniwill Computer Corp: Unknown device 8003
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66Mhz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 32 (1000ns min, 63750ns max), cache line size 08
Interrupt: pin A routed to IRQ 9
Region 0: Memory at dfe80000 (32-bit, non-prefetchable) [size=512K]
Region 1: Memory at d0000000 (32-bit, prefetchable) [size=128M]
Expansion ROM at dfe70000 [disabled] [size=64K]
Capabilities: [dc] Power Management version 2
Flags: PMEClk- DSI+ D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [80] AGP version 2.0
Status: RQ=32 Iso- ArqSz=0 Cal=0 SBA- ITACoh- GART64- HTrans- 64bit- FW- AGP3- Rate=x4
Command: RQ=1 ArqSz=0 Cal=0 SBA- AGP- GART64- 64bit- FW- Rate=x4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VIA VT8231 router detection
2003-08-30 13:11 [PATCH] VIA VT8231 router detection Sebastian Reichelt
@ 2003-08-30 17:37 ` Jeff Garzik
2003-08-30 18:16 ` Sebastian Reichelt
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2003-08-30 17:37 UTC (permalink / raw)
To: Sebastian Reichelt; +Cc: linux-kernel
Sebastian Reichelt wrote:
> Hello!
>
> I have attached a trivial patch to the Linux 2.4.21 kernel (Debian
> unstable kernel-source-2.4.21 package version 2.4.21-5), to add support
> for "VIA Technologies, Inc. VT8231" as an interrupt router. I have also
> attached the output of lspci -vvv (not inline because of line breaks, is
> that OK?). Device 00:08.0, which did not have any IRQs assigned to it
> before, has gotten IRQ 9. I have used this patch for months without any
> problems, so it should be fine. Sorry if I have left out something
> important; please consider me a newbie.
[...]
> --- pci-irq.c.orig 2003-06-01 05:06:21.000000000 +0200
> +++ pci-irq.c 2003-08-30 00:17:42.000000000 +0200
> @@ -480,6 +480,7 @@
> { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, pirq_via_get, pirq_via_set },
> { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C596, pirq_via_get, pirq_via_set },
> { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, pirq_via_get, pirq_via_set },
> + { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8231, pirq_via_get, pirq_via_set },
>
> { "OPTI", PCI_VENDOR_ID_OPTI, PCI_DEVICE_ID_OPTI_82C700, pirq_opti_get, pirq_opti_set },
Well, Mr. Newbie, your patch looks fine to me :)
I'll test it out locally, and make sure it gets into 2.4 and 2.6, if
nobody beats me to it.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VIA VT8231 router detection
2003-08-30 17:37 ` Jeff Garzik
@ 2003-08-30 18:16 ` Sebastian Reichelt
2003-08-30 23:36 ` Mike Fedyk
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Reichelt @ 2003-08-30 18:16 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
> Well, Mr. Newbie, your patch looks fine to me :)
Good :-)
I did forget one thing, though: It's the file pci-irq.c in
arch/i386/kernel. Well, there are only three files with this name in
2.4, but I just thought I'd mention it. ;-)
> I'll test it out locally, and make sure it gets into 2.4 and 2.6, if
> nobody beats me to it.
That's cool! Thank you so much for spending your time on things like
these!
--
Sebastian Reichelt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VIA VT8231 router detection
2003-08-30 18:16 ` Sebastian Reichelt
@ 2003-08-30 23:36 ` Mike Fedyk
0 siblings, 0 replies; 4+ messages in thread
From: Mike Fedyk @ 2003-08-30 23:36 UTC (permalink / raw)
To: Sebastian Reichelt; +Cc: Jeff Garzik, linux-kernel
On Sat, Aug 30, 2003 at 08:16:54PM +0200, Sebastian Reichelt wrote:
> > Well, Mr. Newbie, your patch looks fine to me :)
>
> Good :-)
> I did forget one thing, though: It's the file pci-irq.c in
> arch/i386/kernel. Well, there are only three files with this name in
> 2.4, but I just thought I'd mention it. ;-)
Then run patch from the root of the kernel tree next time, there will be no
confusion at all.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-08-30 23:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-30 13:11 [PATCH] VIA VT8231 router detection Sebastian Reichelt
2003-08-30 17:37 ` Jeff Garzik
2003-08-30 18:16 ` Sebastian Reichelt
2003-08-30 23:36 ` Mike Fedyk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).