From: Andrew Morton <akpm@osdl.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, viro@math.psu.edu
Subject: Re: [BUG] mtime&ctime updated when it should not
Date: Mon, 1 Sep 2003 12:18:07 -0700 [thread overview]
Message-ID: <20030901121807.29119055.akpm@osdl.org> (raw)
In-Reply-To: <20030901181113.GA15672@atrey.karlin.mff.cuni.cz>
Jan Kara <jack@suse.cz> wrote:
>
> Hello,
>
> one user pointed my attention to the fact that when the write fails
> (for example when the user quota is exceeded) the modification time is
> still updated (the problem appears both in 2.4 and 2.6). According to
> SUSv3 that should not happen because the specification says that mtime
> and ctime should be marked for update upon a successful completition
> of a write (not that it would forbid updating the times in other cases
> but I find it at least a bit nonintuitive).
hrm. Doesn't sound super-important. But..
> The easiest fix would be probably to "backup" the times at the
> beginning of the write and restore the original values when the write
> fails (simply not updating the times would require more surgery because
> for example vmtruncate() is called when the write fails and it also
> updates the times).
> So should I write the patch or is the current behaviour considered
> correct?
Isn't this sufficient?
diff -puN mm/filemap.c~a mm/filemap.c
--- 25/mm/filemap.c~a 2003-09-01 12:16:13.000000000 -0700
+++ 25-akpm/mm/filemap.c 2003-09-01 12:17:04.000000000 -0700
@@ -1696,7 +1696,6 @@ generic_file_aio_write_nolock(struct kio
goto out;
remove_suid(file->f_dentry);
- inode_update_time(inode, 1);
/* coalesce the iovecs and go direct-to-BIO for O_DIRECT */
if (unlikely(file->f_flags & O_DIRECT)) {
@@ -1811,7 +1810,12 @@ generic_file_aio_write_nolock(struct kio
}
out_status:
- err = written ? written : status;
+ if (written) {
+ err = written;
+ inode_update_time(inode, 1);
+ } else {
+ err = status;
+ }
out:
pagevec_lru_add(&lru_pvec);
current->backing_dev_info = 0;
_
next prev parent reply other threads:[~2003-09-01 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-01 18:11 [BUG] mtime&ctime updated when it should not Jan Kara
2003-09-01 18:35 ` Herbert Poetzl
2003-09-01 19:05 ` Jan Kara
2003-09-01 22:48 ` Mike Fedyk
2003-09-01 19:18 ` Andrew Morton [this message]
2003-09-01 19:31 ` Jan Kara
2003-09-01 19:58 ` Andrew Morton
2003-09-02 13:06 ` Jan Kara
2003-09-06 8:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030901121807.29119055.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).