linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>, Alan Cox <alan@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [patch] 2.4.23-pre2: fix rocket.c compilation
Date: Tue, 2 Sep 2003 17:18:00 +0200	[thread overview]
Message-ID: <20030902151800.GJ23729@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.55L.0308301220020.31588@freak.distro.conectiva>

On Sat, Aug 30, 2003 at 12:48:22PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
>...
> Alan Cox:
>...
>   o fix a missing rocket card
>...

This patch accidentially also includes one line of the "Make tty->count
atomic" patch resulting in the following compile error:

<--  snip  -->

...
gcc -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/include -W
all -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
include -DKBUILD_BASENAME=rocket  -c -o rocket.o rocket.c
rocket.c: In function `rp_close':
rocket.c:1055: error: request for member `counter' in something not a 
structure or union
make[3]: *** [rocket.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/drivers/char'

<--  snip  -->


The following patch reverts this part of the patch:

--- linux-2.4.23-pre2-full/drivers/char/rocket.c.old	2003-09-02 17:14:43.000000000 +0200
+++ linux-2.4.23-pre2-full/drivers/char/rocket.c	2003-09-02 17:15:07.000000000 +0200
@@ -1052,7 +1052,7 @@
 		restore_flags(flags);
 		return;
 	}
-	if ((atomic_read(&tty->count) == 1) && (info->count != 1)) {
+	if ((tty->count == 1) && (info->count != 1)) {
 		/*
 		 * Uh, oh.  tty->count is 1, which means that the tty
 		 * structure will be freed.  Info->count should always



Please apply
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
On Sat, Aug 30, 2003 at 12:48:22PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.23-pre1 to v2.4.23-pre2
> ============================================
>...
> Alan Cox:
>...
>   o fix a missing rocket card
>...

This patch accidentially also includes one line of the "Make tty->count
atomic" patch resulting in the following compile error:

<--  snip  -->

...
gcc -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/include -W
all -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc -iwithprefix 
include -DKBUILD_BASENAME=rocket  -c -o rocket.o rocket.c
rocket.c: In function `rp_close':
rocket.c:1055: error: request for member `counter' in something not a 
structure or union
make[3]: *** [rocket.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.23-pre2-full/drivers/char'

<--  snip  -->


The following patch reverts this part of the patch:

--- linux-2.4.23-pre2-full/drivers/char/rocket.c.old	2003-09-02 17:14:43.000000000 +0200
+++ linux-2.4.23-pre2-full/drivers/char/rocket.c	2003-09-02 17:15:07.000000000 +0200
@@ -1052,7 +1052,7 @@
 		restore_flags(flags);
 		return;
 	}
-	if ((atomic_read(&tty->count) == 1) && (info->count != 1)) {
+	if ((tty->count == 1) && (info->count != 1)) {
 		/*
 		 * Uh, oh.  tty->count is 1, which means that the tty
 		 * structure will be freed.  Info->count should always



Please apply
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2003-09-02 15:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
2003-08-30 16:22 ` Dave Bentham
2003-08-30 19:35 ` system_lists
2003-08-30 22:05 ` [PATCH] check_gcc for i386 J.A. Magallon
2003-08-30 22:58   ` Marcelo Tosatti
2003-08-30 23:20     ` Norberto BENSA
2003-08-31  2:39       ` Marcelo Tosatti
2003-08-30 23:31     ` J.A. Magallon
2003-08-30 23:37     ` Alan Cox
2003-08-31  0:47       ` Jeff Garzik
2003-08-31  0:59         ` Kurt Wall
2003-08-31  3:03         ` Marcelo Tosatti
2003-09-01 19:14           ` Marcelo Tosatti
2003-08-30 23:01   ` Andre Tomt
2003-08-30 23:11 ` Linux 2.4.23-pre2 - airo.c compile failure Eyal Lebedinsky
2003-09-03 15:56   ` [patch] fix airo.c compile failure with gcc 2.95 Adrian Bunk
2003-09-03 16:33     ` Jeff Garzik
2003-08-31  9:21 ` [PATCH] correct AT_PLATFORM for HT cpus J.A. Magallon
2003-09-02 15:18 ` Adrian Bunk [this message]
2003-09-02 16:49 ` 2.4.23-pre2: 3c515.c doesn't compile non-modular Adrian Bunk
2003-09-02 17:47   ` [PATCH] " Jeff Garzik
2003-10-15 17:32 ` airo regression with Linux 2.4.23-pre2 Udo A. Steinberg
2003-10-15 19:47   ` Celso González
2003-10-15 21:27     ` Javier Achirica
2003-10-16 13:51       ` Udo A. Steinberg
2003-10-16 14:52         ` Marc Giger
2003-10-19 15:19       ` Joseph Pingenot
2003-10-20 10:33         ` Javier Achirica

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030902151800.GJ23729@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).