* [PATCH] Missing module_arch_cleanup call
@ 2003-09-11 5:29 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2003-09-11 5:29 UTC (permalink / raw)
To: torvalds, paulus; +Cc: linux-kernel
Linus, please apply.
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
Name: Always call module_arch_cleanup
Author: Rusty Russell
Status: Booted on 2.6.0-test5-bk1
D: Bug reported by Paul Mackerras: if a module parameter fails, we didn't
D: call module_arch_cleanup().
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.0-test5-bk1/kernel/module.c working-2.6.0-test5-bk1-module-greg-orig/kernel/module.c
--- linux-2.6.0-test5-bk1/kernel/module.c 2003-09-09 10:35:05.000000000 +1000
+++ working-2.6.0-test5-bk1-module-greg-orig/kernel/module.c 2003-09-11 15:14:32.000000000 +1000
@@ -1653,7 +1660,7 @@ static struct module *load_module(void _
NULL);
}
if (err < 0)
- goto cleanup;
+ goto arch_cleanup;
/* Get rid of temporary copy */
vfree(hdr);
@@ -1661,6 +1668,8 @@ static struct module *load_module(void _
/* Done! */
return mod;
+ arch_cleanup:
+ module_arch_cleanup(mod);
cleanup:
module_unload_free(mod);
module_free(mod, mod->module_init);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-09-11 6:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-11 5:29 [PATCH] Missing module_arch_cleanup call Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).