From: Shantanu Goel <sgoel01@yahoo.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: linux-kernel@vger.kernel.org,
Marcelo Tosatti <marcelo.tosatti@cyclades.com.br>
Subject: Re: A couple of 2.4.23-pre4 VM nits
Date: Sun, 21 Sep 2003 07:51:27 -0700 (PDT) [thread overview]
Message-ID: <20030921145127.39547.qmail@web12811.mail.yahoo.com> (raw)
In-Reply-To: <20030921140404.GA16399@velociraptor.random>
[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]
I just realized the original code had one desirable
behaviour that my patch is missing, namely, it
reclaimed memory from dcache/inode every time swap_out
is called. Please use the attached patch that
restores the original behaviour. Otherwise, if the
interval is very long, no reclamation will happen
until swap_out() fails which in the common case is
unlikely.
Thanks,
Shantanu
--- Andrea Arcangeli <andrea@suse.de> wrote:
> On Sat, Sep 20, 2003 at 10:32:09PM -0700, Shantanu
> Goel wrote:
> > Agreed on all counts. I just blindly copied the
> > max_scan decrement from 2.4.22. Even there your
> > suggestion would make sense. Attached is a new
> patch
> > which adds support for vm_vfs_scan_interval sysctl
> and
> > also fixes the location of max_scan decrement.
>
> this patch looks fine to me thanks. Marcelo, feel
> free to merge this one
> instead of my one liner fix.
>
> Andrea - If you prefer relying on open source
> software, check these links:
>
>
rsync.kernel.org::pub/scm/linux/kernel/bkcvs/linux-2.[45]/
> http://www.cobite.com/cvsps/
> svn://svn.kernel.org/linux-2.[46]/trunk
__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com
[-- Attachment #2: vfs-interval2.patch --]
[-- Type: application/octet-stream, Size: 4032 bytes --]
--- ./kernel/sysctl.c.~1~ 2003-09-16 20:44:14.000000000 -0400
+++ ./kernel/sysctl.c 2003-09-21 00:49:32.000000000 -0400
@@ -281,6 +281,8 @@
&vm_gfp_debug, sizeof(int), 0644, NULL, &proc_dointvec},
{VM_VFS_SCAN_RATIO, "vm_vfs_scan_ratio",
&vm_vfs_scan_ratio, sizeof(int), 0644, NULL, &proc_dointvec},
+ {VM_VFS_SCAN_INTERVAL, "vm_vfs_scan_interval",
+ &vm_vfs_scan_interval, sizeof(int), 0644, NULL, &proc_dointvec},
{VM_CACHE_SCAN_RATIO, "vm_cache_scan_ratio",
&vm_cache_scan_ratio, sizeof(int), 0644, NULL, &proc_dointvec},
{VM_MAPPED_RATIO, "vm_mapped_ratio",
--- ./mm/vmscan.c.~1~ 2003-09-16 20:44:14.000000000 -0400
+++ ./mm/vmscan.c 2003-09-21 02:47:49.000000000 -0400
@@ -65,6 +65,12 @@
int vm_vfs_scan_ratio = 6;
/*
+ * "vm_vfs_scan_interval" is how often (in seconds)
+ * memory gets reclaimed from inode/dentry cache.
+ */
+int vm_vfs_scan_interval = MAX_SCHEDULE_TIMEOUT / HZ;
+
+/*
* The swap-out function returns 1 if it successfully
* scanned all the pages it was asked to (`count').
* It returns zero if it couldn't do anything,
@@ -364,6 +370,20 @@
return 0;
}
+static void shrink_vfs_caches(int force, unsigned int gfp_mask)
+{
+ static unsigned long last_scan = 0;
+
+ if (force || time_after(jiffies, last_scan + vm_vfs_scan_interval * HZ)) {
+ shrink_dcache_memory(vm_vfs_scan_ratio, gfp_mask);
+ shrink_icache_memory(vm_vfs_scan_ratio, gfp_mask);
+#ifdef CONFIG_QUOTA
+ shrink_dqcache_memory(vm_vfs_scan_ratio, gfp_mask);
+#endif
+ last_scan = jiffies;
+ }
+}
+
static void FASTCALL(refill_inactive(int nr_pages, zone_t * classzone));
static int FASTCALL(shrink_cache(int nr_pages, zone_t * classzone, unsigned int gfp_mask, int * failed_swapout));
static int shrink_cache(int nr_pages, zone_t * classzone, unsigned int gfp_mask, int * failed_swapout)
@@ -401,6 +421,8 @@
if (!memclass(page_zone(page), classzone))
continue;
+ max_scan--;
+
/* Racy check to avoid trylocking when not worthwhile */
if (!page->buffers && (page_count(page) != 1 || !page->mapping))
goto page_mapped;
@@ -516,11 +538,7 @@
if (nr_pages <= 0)
goto out;
- shrink_dcache_memory(vm_vfs_scan_ratio, gfp_mask);
- shrink_icache_memory(vm_vfs_scan_ratio, gfp_mask);
-#ifdef CONFIG_QUOTA
- shrink_dqcache_memory(vm_vfs_scan_ratio, gfp_mask);
-#endif
+ shrink_vfs_caches(1, gfp_mask);
if (!*failed_swapout)
*failed_swapout = !swap_out(classzone);
@@ -614,6 +632,8 @@
if (nr_pages <= 0)
goto out;
+ shrink_vfs_caches(0, gfp_mask);
+
spin_lock(&pagemap_lru_lock);
refill_inactive(nr_pages, classzone);
@@ -638,11 +658,9 @@
nr_pages = shrink_caches(classzone, gfp_mask, nr_pages, &failed_swapout);
if (nr_pages <= 0)
return 1;
- shrink_dcache_memory(vm_vfs_scan_ratio, gfp_mask);
- shrink_icache_memory(vm_vfs_scan_ratio, gfp_mask);
-#ifdef CONFIG_QUOTA
- shrink_dqcache_memory(vm_vfs_scan_ratio, gfp_mask);
-#endif
+
+ shrink_vfs_caches(1, gfp_mask);
+
if (!failed_swapout)
failed_swapout = !swap_out(classzone);
} while (--tries);
--- ./include/linux/swap.h.~1~ 2003-09-16 20:46:35.000000000 -0400
+++ ./include/linux/swap.h 2003-09-21 00:56:23.000000000 -0400
@@ -116,6 +116,7 @@
extern int FASTCALL(try_to_free_pages_zone(zone_t *, unsigned int));
extern int FASTCALL(try_to_free_pages(unsigned int));
extern int vm_vfs_scan_ratio, vm_cache_scan_ratio, vm_lru_balance_ratio, vm_passes, vm_gfp_debug, vm_mapped_ratio;
+extern int vm_vfs_scan_interval;
/* linux/mm/page_io.c */
extern void rw_swap_page(int, struct page *);
--- ./include/linux/sysctl.h.~1~ 2003-09-16 20:46:35.000000000 -0400
+++ ./include/linux/sysctl.h 2003-09-21 00:59:37.000000000 -0400
@@ -154,6 +154,7 @@
VM_GFP_DEBUG=18, /* debug GFP failures */
VM_CACHE_SCAN_RATIO=19, /* part of the inactive cache list to scan */
VM_MAPPED_RATIO=20, /* amount of unfreeable pages that triggers swapout */
+ VM_VFS_SCAN_INTERVAL=21,/* interval (in secs) between reclaiming memory from inode/dentry cache */
};
next prev parent reply other threads:[~2003-09-21 14:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-29 15:01 [VM PATCH] Faster reclamation of dirty pages and unused inode/dcache entries in 2.4.22 Shantanu Goel
2003-08-29 14:57 ` Antonio Vargas
2003-08-29 17:55 ` Shantanu Goel
2003-08-29 18:06 ` Mike Fedyk
2003-08-29 18:46 ` Shantanu Goel
2003-08-29 18:57 ` Mike Fedyk
2003-08-29 19:28 ` Andrea Arcangeli
2003-08-29 19:46 ` Shantanu Goel
2003-08-29 19:55 ` Andrea Arcangeli
2003-08-29 20:20 ` Shantanu Goel
2003-08-30 5:01 ` Antonio Vargas
2003-09-20 13:39 ` A couple of 2.4.23-pre4 VM nits Shantanu Goel
2003-09-21 2:46 ` Andrea Arcangeli
2003-09-21 5:32 ` Shantanu Goel
2003-09-21 14:04 ` Andrea Arcangeli
2003-09-21 14:51 ` Shantanu Goel [this message]
2003-09-21 15:14 ` Andrea Arcangeli
2003-09-21 15:28 ` Shantanu Goel
2003-09-21 15:57 ` Andrea Arcangeli
2003-09-21 18:37 ` Marcelo Tosatti
2003-08-29 19:11 ` [VM PATCH] Faster reclamation of dirty pages and unused inode/dcache entries in 2.4.22 Rahul Karnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030921145127.39547.qmail@web12811.mail.yahoo.com \
--to=sgoel01@yahoo.com \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).