* [PATCH] [2.4] devio.c memleak on unexpected disconnect
@ 2003-09-21 18:59 Oleg Drokin
2003-09-24 21:34 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Drokin @ 2003-09-21 18:59 UTC (permalink / raw)
To: marcelo, linux-kernel, greg
Hello!
There is a memleak in devio.c (User space communication with USB devices)
recently added, it forgets to free the buffer if device was disconnected.
The patch is trivial, please apply.
Found with help of smatch.
===== drivers/usb/devio.c 1.17 vs edited =====
--- 1.17/drivers/usb/devio.c Mon Aug 19 20:49:38 2002
+++ edited/drivers/usb/devio.c Sun Sep 21 22:51:15 2003
@@ -1114,7 +1114,7 @@
usb_driver_release_interface (driver, ifp);
up (&driver->serialize);
} else
- return -ENODATA;
+ retval = -ENODATA;
break;
/* let kernel drivers try to (re)bind to the interface */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [2.4] devio.c memleak on unexpected disconnect
2003-09-21 18:59 [PATCH] [2.4] devio.c memleak on unexpected disconnect Oleg Drokin
@ 2003-09-24 21:34 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-09-24 21:34 UTC (permalink / raw)
To: Oleg Drokin; +Cc: marcelo, linux-kernel
On Sun, Sep 21, 2003 at 10:59:22PM +0400, Oleg Drokin wrote:
> Hello!
>
> There is a memleak in devio.c (User space communication with USB devices)
> recently added, it forgets to free the buffer if device was disconnected.
>
> The patch is trivial, please apply.
> Found with help of smatch.
Applied to my trees, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-24 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-21 18:59 [PATCH] [2.4] devio.c memleak on unexpected disconnect Oleg Drokin
2003-09-24 21:34 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).