* [PATCH] ACPI pci irq routing fix
@ 2003-09-27 1:21 Chris Wright
2003-09-27 5:54 ` Nick Piggin
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wright @ 2003-09-27 1:21 UTC (permalink / raw)
To: len.brown; +Cc: linux-kernel, acpi-devel, adq_dvb
If irq.active is set from _CRS, make sure to use it, rather than trying
anything from the from the _PRS list, as some machines don't handle this
properly. This patch is against current linux-acpi-test-2.6.0. It's
been floating about for a while, and fixes bug #1186.
Patch originally from Andrew de Quincey.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
===== drivers/acpi/pci_link.c 1.19 vs edited =====
--- 1.19/drivers/acpi/pci_link.c Thu Sep 18 11:29:36 2003
+++ edited/drivers/acpi/pci_link.c Fri Sep 26 14:36:15 2003
@@ -500,15 +500,15 @@
irq = link->irq.active;
} else {
irq = link->irq.possible[0];
- }
- /*
- * Select the best IRQ. This is done in reverse to promote
- * the use of IRQs 9, 10, 11, and >15.
- */
- for (i=(link->irq.possible_count-1); i>0; i--) {
- if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
- irq = link->irq.possible[i];
+ /*
+ * Select the best IRQ. This is done in reverse to promote
+ * the use of IRQs 9, 10, 11, and >15.
+ */
+ for (i=(link->irq.possible_count-1); i>0; i--) {
+ if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
+ irq = link->irq.possible[i];
+ }
}
/* Attempt to enable the link device at this IRQ. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI pci irq routing fix
2003-09-27 1:21 [PATCH] ACPI pci irq routing fix Chris Wright
@ 2003-09-27 5:54 ` Nick Piggin
2003-09-30 5:17 ` Len Brown
0 siblings, 1 reply; 4+ messages in thread
From: Nick Piggin @ 2003-09-27 5:54 UTC (permalink / raw)
To: Chris Wright, len.brown; +Cc: linux-kernel, acpi-devel, adq_dvb
Chris Wright wrote:
>If irq.active is set from _CRS, make sure to use it, rather than trying
>anything from the from the _PRS list, as some machines don't handle this
>properly. This patch is against current linux-acpi-test-2.6.0. It's
>been floating about for a while, and fixes bug #1186.
>
>Patch originally from Andrew de Quincey.
>
>thanks,
>-chris
>
This fixes my bug #1257.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI pci irq routing fix
2003-09-27 5:54 ` Nick Piggin
@ 2003-09-30 5:17 ` Len Brown
2003-09-30 6:08 ` Chris Wright
0 siblings, 1 reply; 4+ messages in thread
From: Len Brown @ 2003-09-30 5:17 UTC (permalink / raw)
To: Nick Piggin; +Cc: Chris Wright, linux-kernel, acpi-devel, Andrew de Quincey
On Sat, 2003-09-27 at 01:54, Nick Piggin wrote:
> Chris Wright wrote:
>
> >If irq.active is set from _CRS, make sure to use it
...
> and fixes bug #1186.
> >
> >Patch originally from Andrew de Quincey.
> >
>
> This fixes my bug #1257.
>
This fix has been integrated with others in the ACPI patch,
and is available now in these bitkeeper trees:
http://linux-acpi.bkbits.net/linux-acpi-test-2.4.22
http://linux-acpi.bkbits.net/linux-acpi-test-2.4.23
http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0
It is also available as a plain patch "acpi_pci_link_allocate" here:
ftp.kernel.org:/pub/linux/kernel/people/lenb/acpi/patches/test/*
thanks,
-Len
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI pci irq routing fix
2003-09-30 5:17 ` Len Brown
@ 2003-09-30 6:08 ` Chris Wright
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wright @ 2003-09-30 6:08 UTC (permalink / raw)
To: Len Brown
Cc: Nick Piggin, Chris Wright, linux-kernel, acpi-devel, Andrew de Quincey
* Len Brown (len.brown@intel.com) wrote:
>
> This fix has been integrated with others in the ACPI patch,
> and is available now in these bitkeeper trees:
Great, thanks Len.
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-09-30 6:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-27 1:21 [PATCH] ACPI pci irq routing fix Chris Wright
2003-09-27 5:54 ` Nick Piggin
2003-09-30 5:17 ` Len Brown
2003-09-30 6:08 ` Chris Wright
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).